linux-stable.git/drivers/misc/mei, branch linux-3.8.y

mei: fix mismatch in mutex unlock-lock in mei_amthif_read()

2013-01-07T18:28:03+00:00

Users of mei_amthif_read() expect it leaves dev->device_lock held,
while there is a path where mei_amthif_read() unlocks device_lock
and returns -ERESTARTSYS.

The patch move code locking device_lock back before the return.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Cc: Sedat Dilek 
Acked-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

watchdog: mei: avoid oops in watchdog unregister code path

2012-12-19T21:25:11+00:00

With commit c7d3df3 "mei: use internal watchdog device registration
tracking" will crash the kernel on shutdown path on systems
where ME watchdog is not present.
Since the watchdog was never initialized in such case
the WDOG_UNREGISTERED bit is never set and the system
crashes on access to uninitialized variables down the path.

To solve the issue we query for NULL on watchdog driver driver_data
to check whether the device is registered. This is handled in the
driver and doesn't depend on watchdog core internals.

Cc: Borislav Petkov 
Cc: Wanlong Gao 
Signed-off-by: Jerry Snitselaar 
Signed-off-by: Tomas Winkler 
Signed-off-by: Wim Van Sebroeck

misc: remove use of __devexit

2012-11-21T20:53:32+00:00

CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.

Signed-off-by: Bill Pemberton 
Cc: "Michał Mirosław" 
Cc: Wolfram Sang 
Cc: Eric Piel 
Cc: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

misc: remove use of __devinit

2012-11-21T20:51:53+00:00

CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.

Signed-off-by: Bill Pemberton 
Cc: "Michał Mirosław" 
Cc: Eric Piel 
Cc: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

mei: remove use of __devexit_p

2012-11-21T20:43:58+00:00

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.

Signed-off-by: Bill Pemberton 
Cc: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

mei: Simplify the ME client enumeration code

2012-11-21T20:43:58+00:00

After enumerating all ME clients we call the client init functions for
all matching UUIDs from a separate context.
This remove the hackish cascading client initialisation process that was
interleaving properties and connection command replies.

Signed-off-by: Samuel Ortiz 
Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

mei: simplify write complete loop in irq handler

2012-11-21T20:43:58+00:00

extract the common, hence non conditional code
from the if-else statment

Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

mei: don't mix read and write slots

2012-11-21T20:43:58+00:00

Do not pass read slots pointer into function
mei_irq_thread_write_handler, the write
slots management is handled internally in the write
handler

Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

mei: streamline amthif write complete function

2012-11-21T20:43:58+00:00

Rename the function mei_amthif_irq_process_completed
to mei_amthif_irq_write_complete
Remove cl from the parameter list as it
can be extracted from cb block.
Extract the common flow from if statements
and document the logic properly

Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman

mei: streamline write complete flow function

2012-11-21T20:43:58+00:00

Rename the function  _mei_irq_thread_cmpl to
mei_irq_thread_write_complete to make clear it deals
with writing. Remove cl from the parameter list as it
can be extracted from cb block.
Extract the common flow from if statements and document
the logic properly

Signed-off-by: Tomas Winkler 
Signed-off-by: Greg Kroah-Hartman