linux-stable.git/drivers/misc/fastrpc.c, branch v5.5

Merge 5.4-rc3 into char-misc-next

2019-10-14T05:36:49+00:00

We need the char/misc fixes in here as well.

Signed-off-by: Greg Kroah-Hartman

misc: fastrpc: revert max init file size back to 2MB

2019-10-10T13:28:12+00:00

With the integration of the mmap/unmap functionality, it is no longer
necessary to allow large memory allocations upfront since they can be
handled during runtime.

Tested on QCS404 with CDSP Neural Processing test suite.

Signed-off-by: Jorge Ramirez-Ortiz 
Reviewed-by: Srinivas Kandagatla 
Signed-off-by: Srinivas Kandagatla 
Link: https://lore.kernel.org/r/20191009144123.24583-6-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman

misc: fastrpc: handle interrupted contexts

2019-10-10T13:28:12+00:00

Buffers owned by a context that has been interrupted either by a
signal or a timeout might still be being accessed by the DSP.

delegate returning the associated memory to a later time when the
device is released.

Signed-off-by: Jorge Ramirez-Ortiz 
Reviewed-by: Srinivas Kandagatla 
Signed-off-by: Srinivas Kandagatla 
Link: https://lore.kernel.org/r/20191009144123.24583-5-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman

misc: fastrpc: do not interrupt kernel calls

2019-10-10T13:28:11+00:00

the DSP firmware requires some calls to be held until processing has
completed: this is to guarantee that memory continues to be
accessible.

Nevertheless, the fastrpc driver chooses not support the case were
requests need to be held for unbounded amounts of time. If such a
use-case becomes necessary, this timeout will need to be revisited.

Signed-off-by: Jorge Ramirez-Ortiz 
Reviewed-by: Srinivas Kandagatla 
Signed-off-by: Srinivas Kandagatla 
Link: https://lore.kernel.org/r/20191009144123.24583-4-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman

misc: fastrpc: fix memory leak from miscdev->name

2019-10-10T13:28:11+00:00

Fix a memory leak in miscdev->name by using devm_variant

Orignally reported by kmemleak:
    [] kmemleak_alloc+0x50/0x84
    [] __kmalloc_track_caller+0xe8/0x168
    [] kvasprintf+0x78/0x100
    [] kasprintf+0x50/0x74
    [] fastrpc_rpmsg_probe+0xd8/0x20c
    [] rpmsg_dev_probe+0xa8/0x148
    [] really_probe+0x208/0x248
    [] driver_probe_device+0x98/0xc0
    [] __device_attach_driver+0x9c/0xac
    [] bus_for_each_drv+0x60/0x8c
    [] __device_attach+0x8c/0x100
    [] device_initial_probe+0x20/0x28
    [] bus_probe_device+0x34/0x7c
    [] device_add+0x420/0x498
    [] device_register+0x24/0x2c

Signed-off-by: Srinivas Kandagatla 
Reviewed-by: Bjorn Andersson 
Link: https://lore.kernel.org/r/20191009144123.24583-3-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman

misc: fastrpc: add mmap/unmap support

2019-10-10T13:28:10+00:00

Support the allocation/deallocation of buffers mapped to the DSP.

When the memory mapped to the DSP at process creation is not enough,
the fastrpc library can extend it at runtime. This avoids having to do
large preallocations by default.

Signed-off-by: Jorge Ramirez-Ortiz 
Reviewed-by: Srinivas Kandagatla 
Signed-off-by: Srinivas Kandagatla 
Link: https://lore.kernel.org/r/20191009144123.24583-2-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman

misc: fastrpc: prevent memory leak in fastrpc_dma_buf_attach

2019-10-04T16:22:14+00:00

In fastrpc_dma_buf_attach if dma_get_sgtable fails the allocated memory
for a should be released.

Signed-off-by: Navid Emamdoost 
Link: https://lore.kernel.org/r/20190925152742.16258-1-navid.emamdoost@gmail.com
Signed-off-by: Greg Kroah-Hartman

misc: fastrpc: free dma buf scatter list

2019-09-04T11:35:11+00:00

dma buf scatter list is never freed, free it!

Orignally detected by kmemleak:
  backtrace:
    [] kmemleak_alloc+0x50/0x84
    [] sg_kmalloc+0x38/0x60
    [] __sg_alloc_table+0x60/0x110
    [] sg_alloc_table+0x28/0x58
    [] __sg_alloc_table_from_pages+0xc0/0x1ac
    [] sg_alloc_table_from_pages+0x14/0x1c
    [] __iommu_get_sgtable+0x5c/0x8c
    [] fastrpc_dma_buf_attach+0x84/0xf8
    [] dma_buf_attach+0x70/0xc8
    [] fastrpc_map_create+0xf8/0x1e8
    [] fastrpc_device_ioctl+0x508/0x900
    [] compat_SyS_ioctl+0x128/0x200
    [] el0_svc_naked+0x34/0x38
    [] 0xffffffffffffffff

Reported-by: Mayank Chopra 
Signed-off-by: Srinivas Kandagatla 
Link: https://lore.kernel.org/r/20190829092926.12037-6-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman

misc: fastrpc: fix double refcounting on dmabuf

2019-09-04T11:35:11+00:00

dma buf refcount has to be done by the driver which is going to use the fd.
This driver already does refcount on the dmabuf fd if its actively using it
but also does an additional refcounting via extra ioctl.
This additional refcount can lead to memory leak in cases where the
applications fail to call the ioctl to decrement the refcount.

So remove this extra refcount in the ioctl

More info of dma buf usage at drivers/dma-buf/dma-buf.c

Reported-by: Mayank Chopra 
Reported-by: Jorge Ramirez-Ortiz 
Tested-by: Jorge Ramirez-Ortiz 
Signed-off-by: Srinivas Kandagatla 
Link: https://lore.kernel.org/r/20190829092926.12037-5-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman

misc: fastrpc: remove unused definition

2019-09-04T11:35:11+00:00

Remove unused INIT_MEMLEN_MAX define.

Signed-off-by: Jorge Ramirez-Ortiz 
Signed-off-by: Abhinav Asati 
Signed-off-by: Vamsi Singamsetty 
Signed-off-by: Srinivas Kandagatla 
Link: https://lore.kernel.org/r/20190829092926.12037-4-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman