linux-stable.git/drivers/misc/fastrpc.c, branch v5.4

misc: fastrpc: prevent memory leak in fastrpc_dma_buf_attach

2019-10-04T16:22:14+00:00

In fastrpc_dma_buf_attach if dma_get_sgtable fails the allocated memory
for a should be released.

Signed-off-by: Navid Emamdoost 
Link: https://lore.kernel.org/r/20190925152742.16258-1-navid.emamdoost@gmail.com
Signed-off-by: Greg Kroah-Hartman

misc: fastrpc: free dma buf scatter list

2019-09-04T11:35:11+00:00

dma buf scatter list is never freed, free it!

Orignally detected by kmemleak:
  backtrace:
    [] kmemleak_alloc+0x50/0x84
    [] sg_kmalloc+0x38/0x60
    [] __sg_alloc_table+0x60/0x110
    [] sg_alloc_table+0x28/0x58
    [] __sg_alloc_table_from_pages+0xc0/0x1ac
    [] sg_alloc_table_from_pages+0x14/0x1c
    [] __iommu_get_sgtable+0x5c/0x8c
    [] fastrpc_dma_buf_attach+0x84/0xf8
    [] dma_buf_attach+0x70/0xc8
    [] fastrpc_map_create+0xf8/0x1e8
    [] fastrpc_device_ioctl+0x508/0x900
    [] compat_SyS_ioctl+0x128/0x200
    [] el0_svc_naked+0x34/0x38
    [] 0xffffffffffffffff

Reported-by: Mayank Chopra 
Signed-off-by: Srinivas Kandagatla 
Link: https://lore.kernel.org/r/20190829092926.12037-6-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman

misc: fastrpc: fix double refcounting on dmabuf

2019-09-04T11:35:11+00:00

dma buf refcount has to be done by the driver which is going to use the fd.
This driver already does refcount on the dmabuf fd if its actively using it
but also does an additional refcounting via extra ioctl.
This additional refcount can lead to memory leak in cases where the
applications fail to call the ioctl to decrement the refcount.

So remove this extra refcount in the ioctl

More info of dma buf usage at drivers/dma-buf/dma-buf.c

Reported-by: Mayank Chopra 
Reported-by: Jorge Ramirez-Ortiz 
Tested-by: Jorge Ramirez-Ortiz 
Signed-off-by: Srinivas Kandagatla 
Link: https://lore.kernel.org/r/20190829092926.12037-5-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman

misc: fastrpc: remove unused definition

2019-09-04T11:35:11+00:00

Remove unused INIT_MEMLEN_MAX define.

Signed-off-by: Jorge Ramirez-Ortiz 
Signed-off-by: Abhinav Asati 
Signed-off-by: Vamsi Singamsetty 
Signed-off-by: Srinivas Kandagatla 
Link: https://lore.kernel.org/r/20190829092926.12037-4-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman

misc: fastrpc: Don't reference rpmsg_device after remove

2019-09-04T11:35:10+00:00

As fastrpc_rpmsg_remove() returns the rpdev of the channel context is no
longer a valid object, so ensure to update the channel context to no
longer reference the old object and guard in the invoke code path
against dereferencing it.

Signed-off-by: Bjorn Andersson 
Signed-off-by: Mayank Chopra 
Signed-off-by: Abhinav Asati 
Signed-off-by: Vamsi Singamsetty 
Signed-off-by: Srinivas Kandagatla 
Link: https://lore.kernel.org/r/20190829092926.12037-3-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman

misc: fastrpc: Reference count channel context

2019-09-04T11:35:10+00:00

The channel context is referenced from the fastrpc user and might as
user space holds the file descriptor open outlive the fastrpc device,
which is removed when the remote processor is shutting down.

Reference count the channel context in order to retain this object until
all references has been relinquished.

Signed-off-by: Bjorn Andersson 
Signed-off-by: Mayank Chopra 
Signed-off-by: Abhinav Asati 
Signed-off-by: Vamsi Singamsetty 
Signed-off-by: Srinivas Kandagatla 
Link: https://lore.kernel.org/r/20190829092926.12037-2-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman

misc: fastrpc: fix memory leak when out of memory

2019-07-25T12:46:17+00:00

Do the necessary house-keeping if the allocated memory wont be used

Signed-off-by: Jorge Ramirez-Ortiz 
Link: https://lore.kernel.org/r/20190705081303.14170-1-jorge.ramirez-ortiz@linaro.org
Signed-off-by: Greg Kroah-Hartman

Merge 5.1-rc6 into char-misc-next

2019-04-21T21:14:47+00:00

We want the fixes, and this resolves a merge error in the fastrpc
driver.

Signed-off-by: Greg Kroah-Hartman

misc: fastrpc: add checked value for dma_set_mask

2019-04-02T15:56:54+00:00

There be should check return value from dma_set_mask to throw some info
if fail to set dma mask.

Detected by CoverityScan, CID# 1443983:  Error handling issues (CHECKED_RETURN)

Fixes: f6f9279f2bf0 ("misc: fastrpc: Add Qualcomm fastrpc basic driver model")
Signed-off-by: Bo YU 
Signed-off-by: Greg Kroah-Hartman

misc: fastrpc: increase max init file size to 64 MB

2019-03-27T17:09:58+00:00

In some cases where Neural Processing is required the size of init process
exceeds default size of 2MB, increase this size to 64MB which is required
for QCS404 CDSP Neural Processing.

Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Greg Kroah-Hartman