linux-stable.git/drivers/mfd, branch v3.16.52

mfd: omap-usb-tll: Fix register offsets

2017-11-26T13:50:30+00:00

commit 993dc737c0996c163325961fb62a0ed9fd0308b4 upstream.

gcc-8 notices that the register number calculation is wrong
when the offset is an 'u8' but the number is larger than 256:

drivers/mfd/omap-usb-tll.c: In function 'omap_tll_init':
drivers/mfd/omap-usb-tll.c:90:46: error: overflow in conversion from 'int' to 'u8 {aka unsigned char}' chages value from 'i * 256 + 2070' to '22' [-Werror=overflow]

This addresses it by always using a 32-bit offset number for
the register. This is apparently an old problem that previous
compilers did not find.

Fixes: 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
Signed-off-by: Arnd Bergmann 
Signed-off-by: Lee Jones 
Signed-off-by: Ben Hutchings

mfd: max8998: Fix potential NULL pointer dereference

2017-11-26T13:50:30+00:00

commit 2042f3c29f2f11129434de8a610878e8a15b4174 upstream.

if 'max8998_i2c_parse_dt_pdata() fails (when out of memory), a NULL
pointer dereference will occur in the error handling code.

Return directly instead.

Fixes: ee999fb3f17f("mfd: max8998: Add support for Device Tree")
Signed-off-by: Christophe JAILLET 
Signed-off-by: Lee Jones 
Signed-off-by: Ben Hutchings

mfd: arizona: Rid data size incompatibility warn when building for 64bit

2017-11-11T13:33:44+00:00

commit 942786e6e647cef94cf96dcd836d343be55fc452 upstream.

Extinguishes:

../drivers/mfd/arizona-core.c: In function ‘arizona_of_get_type’:
../drivers/mfd/arizona-core.c:505:10:
	warning: cast from pointer to integer of different size

Signed-off-by: Lee Jones 
Signed-off-by: Arnd Bergmann 
Signed-off-by: Ben Hutchings

mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode

2017-08-26T01:14:40+00:00

commit 8b8a84c54aff4256d592dc18346c65ecf6811b45 upstream.

Commit 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
added support for USB TLL, but uses OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
bit the wrong way. The comments in the code are correct, but the inverted
use of OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF causes the register to be
enabled instead of disabled unlike what the comments say.

Without this change the Wrigley 3G LTE modem on droid 4 EHCI bus can
be only pinged few times before it stops responding.

Fixes: 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
Signed-off-by: Tony Lindgren 
Acked-by: Roger Quadros 
Signed-off-by: Lee Jones 
Signed-off-by: Ben Hutchings

mfd: core: Fix device reference leak in mfd_clone_cell

2017-02-23T03:54:34+00:00

commit 722f191080de641f023feaa7d5648caf377844f5 upstream.

Make sure to drop the reference taken by bus_find_device_by_name()
before returning from mfd_clone_cell().

Fixes: a9bbba996302 ("mfd: add platform_device sharing support for mfd")
Signed-off-by: Johan Hovold 
Signed-off-by: Lee Jones 
Signed-off-by: Ben Hutchings

mfd: rtsx_usb: Avoid setting ucr->current_sg.status

2017-02-23T03:54:09+00:00

commit 8dcc5ff8fcaf778bb57ab4448fedca9e381d088f upstream.

Member "status" of struct usb_sg_request is managed by usb core. A
spin lock is used to serialize the change of it. The driver could
check the value of req->status, but should avoid changing it without
the hold of the spinlock. Otherwise, it could cause race or error
in usb core.

This patch could be backported to stable kernels with version later
than v3.14.

Cc: Alan Stern 
Cc: Roger Tseng 
Signed-off-by: Lu Baolu 
Signed-off-by: Lee Jones 
Signed-off-by: Ben Hutchings

mfd: wm8350-i2c: Make sure the i2c regmap functions are compiled

2017-02-23T03:54:09+00:00

commit 88003fb10f1fc606e1704611c62ceae95fd1d7da upstream.

This fixes a compile failure:

	drivers/built-in.o: In function `wm8350_i2c_probe':
	core.c:(.text+0x828b0): undefined reference to `__devm_regmap_init_i2c'
	Makefile:953: recipe for target 'vmlinux' failed

Fixes: 52b461b86a9f ("mfd: Add regmap cache support for wm8350")
Signed-off-by: Uwe Kleine-König 
Acked-by: Charles Keepax 
Signed-off-by: Lee Jones 
Signed-off-by: Ben Hutchings

mfd: omap-usb-tll: Fix scheduling while atomic BUG

2016-08-22T21:38:11+00:00

commit b49b927f16acee626c56a1af4ab4cb062f75b5df upstream.

We shouldn't be calling clk_prepare_enable()/clk_prepare_disable()
in an atomic context.

Fixes the following issue:

[    5.830970] ehci-omap: OMAP-EHCI Host Controller driver
[    5.830974] driver_register 'ehci-omap'
[    5.895849] driver_register 'wl1271_sdio'
[    5.896870] BUG: scheduling while atomic: udevd/994/0x00000002
[    5.896876] 4 locks held by udevd/994:
[    5.896904]  #0:  (&dev->mutex){......}, at: [] __driver_attach+0x60/0xac
[    5.896923]  #1:  (&dev->mutex){......}, at: [] __driver_attach+0x70/0xac
[    5.896946]  #2:  (tll_lock){+.+...}, at: [] omap_tll_enable+0x2c/0xd0
[    5.896966]  #3:  (prepare_lock){+.+...}, at: [] clk_prepare_lock+0x48/0xe0
[    5.897042] Modules linked in: wlcore_sdio(+) ehci_omap(+) dwc3_omap snd_soc_ts3a225e leds_is31fl319x bq27xxx_battery_i2c tsc2007 bq27xxx_battery bq2429x_charger ina2xx tca8418_keypad as5013 leds_tca6507 twl6040_vibra gpio_twl6040 bmp085_i2c(+) palmas_gpadc usb3503 palmas_pwrbutton bmg160_i2c(+) bmp085 bma150(+) bmg160_core bmp280 input_polldev snd_soc_omap_mcbsp snd_soc_omap_mcpdm snd_soc_omap snd_pcm_dmaengine
[    5.897048] Preemption disabled at:[<  (null)>]   (null)
[    5.897051]
[    5.897059] CPU: 0 PID: 994 Comm: udevd Not tainted 4.6.0-rc5-letux+ #233
[    5.897062] Hardware name: Generic OMAP5 (Flattened Device Tree)
[    5.897076] [] (unwind_backtrace) from [] (show_stack+0x10/0x14)
[    5.897087] [] (show_stack) from [] (dump_stack+0x88/0xc0)
[    5.897099] [] (dump_stack) from [] (__schedule_bug+0xac/0xd0)
[    5.897111] [] (__schedule_bug) from [] (__schedule+0x88/0x7e4)
[    5.897120] [] (__schedule) from [] (schedule+0x9c/0xc0)
[    5.897129] [] (schedule) from [] (schedule_preempt_disabled+0x14/0x20)
[    5.897140] [] (schedule_preempt_disabled) from [] (mutex_lock_nested+0x258/0x43c)
[    5.897150] [] (mutex_lock_nested) from [] (clk_prepare_lock+0x48/0xe0)
[    5.897160] [] (clk_prepare_lock) from [] (clk_prepare+0x10/0x28)
[    5.897169] [] (clk_prepare) from [] (omap_tll_enable+0x64/0xd0)
[    5.897180] [] (omap_tll_enable) from [] (usbhs_runtime_resume+0x18/0x17c)
[    5.897192] [] (usbhs_runtime_resume) from [] (pm_generic_runtime_resume+0x2c/0x40)
[    5.897202] [] (pm_generic_runtime_resume) from [] (__rpm_callback+0x38/0x68)
[    5.897210] [] (__rpm_callback) from [] (rpm_callback+0x70/0x88)
[    5.897218] [] (rpm_callback) from [] (rpm_resume+0x4ec/0x7ec)
[    5.897227] [] (rpm_resume) from [] (__pm_runtime_resume+0x4c/0x64)
[    5.897236] [] (__pm_runtime_resume) from [] (driver_probe_device+0x30/0x70)
[    5.897246] [] (driver_probe_device) from [] (__driver_attach+0x88/0xac)
[    5.897256] [] (__driver_attach) from [] (bus_for_each_dev+0x50/0x84)
[    5.897267] [] (bus_for_each_dev) from [] (bus_add_driver+0xcc/0x1e4)
[    5.897276] [] (bus_add_driver) from [] (driver_register+0xac/0xf4)
[    5.897286] [] (driver_register) from [] (do_one_initcall+0x100/0x1b8)
[    5.897296] [] (do_one_initcall) from [] (do_init_module+0x58/0x1c0)
[    5.897304] [] (do_init_module) from [] (SyS_finit_module+0x88/0x90)
[    5.897313] [] (SyS_finit_module) from [] (ret_fast_syscall+0x0/0x1c)
[    5.912697] ------------[ cut here ]------------
[    5.912711] WARNING: CPU: 0 PID: 994 at kernel/sched/core.c:2996 _raw_spin_unlock+0x28/0x58
[    5.912717] DEBUG_LOCKS_WARN_ON(val > preempt_count())

Reported-by: H. Nikolaus Schaller 
Tested-by: H. Nikolaus Schaller 
Signed-off-by: Roger Quadros 
Signed-off-by: Lee Jones 
Signed-off-by: Ben Hutchings

mfd: lp8788-irq: Uninitialized variable in irq handler

2016-08-22T21:37:49+00:00

commit 22aab38e7b59fd79ce1045006be69a9abab58e5a upstream.

Instead to being true/false, the "handled" is true/uninitialized.
Presumably this doesn't cause that many problems in real life because
normally we handle the IRQ.

Fixes: eea6b7cc53aa ('mfd: Add lp8788 mfd driver')
Signed-off-by: Dan Carpenter 
Acked-by: Milo Kim 
Signed-off-by: Lee Jones 
Signed-off-by: Ben Hutchings

mfd: twl6040: Fix deferred probe handling for clk32k

2015-12-13T17:49:39+00:00

commit 75c08f17ec87c2d742487bb87408d6feebc526bd upstream.

Commit 68bab8662f49 ("mfd: twl6040: Optional clk32k clock handling")
added clock handling for the 32k clock from palmas-clk. However, that
patch did not consider a typical situation where twl6040 is built-in,
and palmas-clk is a loadable module like we have in omap2plus_defconfig.

If palmas-clk is not loaded before twl6040 probes, we will get a
"clk32k is not handled" warning during booting. This means that any
drivers relying on this clock will mysteriously fail, including
omap5-uevm WLAN and audio.

Note that for WLAN, we probably should also eventually get
the clk32kgaudio for MMC3 directly as that's shared between
audio and WLAN SDIO at least for omap5-uevm. It seems the
WLAN chip cannot get it as otherwise MMC3 won't get properly
probed.

Fixes: 68bab8662f49 ("mfd: twl6040: Optional clk32k clock handling")
Signed-off-by: Tony Lindgren 
Reviewed-by: Felipe Balbi 
Signed-off-by: Lee Jones 
Signed-off-by: Luis Henriques