linux-stable.git/drivers/mfd, branch v3.16.40

mfd: core: Fix device reference leak in mfd_clone_cell

2017-02-23T03:54:34+00:00

commit 722f191080de641f023feaa7d5648caf377844f5 upstream.

Make sure to drop the reference taken by bus_find_device_by_name()
before returning from mfd_clone_cell().

Fixes: a9bbba996302 ("mfd: add platform_device sharing support for mfd")
Signed-off-by: Johan Hovold 
Signed-off-by: Lee Jones 
Signed-off-by: Ben Hutchings

mfd: rtsx_usb: Avoid setting ucr->current_sg.status

2017-02-23T03:54:09+00:00

commit 8dcc5ff8fcaf778bb57ab4448fedca9e381d088f upstream.

Member "status" of struct usb_sg_request is managed by usb core. A
spin lock is used to serialize the change of it. The driver could
check the value of req->status, but should avoid changing it without
the hold of the spinlock. Otherwise, it could cause race or error
in usb core.

This patch could be backported to stable kernels with version later
than v3.14.

Cc: Alan Stern 
Cc: Roger Tseng 
Signed-off-by: Lu Baolu 
Signed-off-by: Lee Jones 
Signed-off-by: Ben Hutchings

mfd: wm8350-i2c: Make sure the i2c regmap functions are compiled

2017-02-23T03:54:09+00:00

commit 88003fb10f1fc606e1704611c62ceae95fd1d7da upstream.

This fixes a compile failure:

	drivers/built-in.o: In function `wm8350_i2c_probe':
	core.c:(.text+0x828b0): undefined reference to `__devm_regmap_init_i2c'
	Makefile:953: recipe for target 'vmlinux' failed

Fixes: 52b461b86a9f ("mfd: Add regmap cache support for wm8350")
Signed-off-by: Uwe Kleine-König 
Acked-by: Charles Keepax 
Signed-off-by: Lee Jones 
Signed-off-by: Ben Hutchings

mfd: omap-usb-tll: Fix scheduling while atomic BUG

2016-08-22T21:38:11+00:00

commit b49b927f16acee626c56a1af4ab4cb062f75b5df upstream.

We shouldn't be calling clk_prepare_enable()/clk_prepare_disable()
in an atomic context.

Fixes the following issue:

[    5.830970] ehci-omap: OMAP-EHCI Host Controller driver
[    5.830974] driver_register 'ehci-omap'
[    5.895849] driver_register 'wl1271_sdio'
[    5.896870] BUG: scheduling while atomic: udevd/994/0x00000002
[    5.896876] 4 locks held by udevd/994:
[    5.896904]  #0:  (&dev->mutex){......}, at: [] __driver_attach+0x60/0xac
[    5.896923]  #1:  (&dev->mutex){......}, at: [] __driver_attach+0x70/0xac
[    5.896946]  #2:  (tll_lock){+.+...}, at: [] omap_tll_enable+0x2c/0xd0
[    5.896966]  #3:  (prepare_lock){+.+...}, at: [] clk_prepare_lock+0x48/0xe0
[    5.897042] Modules linked in: wlcore_sdio(+) ehci_omap(+) dwc3_omap snd_soc_ts3a225e leds_is31fl319x bq27xxx_battery_i2c tsc2007 bq27xxx_battery bq2429x_charger ina2xx tca8418_keypad as5013 leds_tca6507 twl6040_vibra gpio_twl6040 bmp085_i2c(+) palmas_gpadc usb3503 palmas_pwrbutton bmg160_i2c(+) bmp085 bma150(+) bmg160_core bmp280 input_polldev snd_soc_omap_mcbsp snd_soc_omap_mcpdm snd_soc_omap snd_pcm_dmaengine
[    5.897048] Preemption disabled at:[<  (null)>]   (null)
[    5.897051]
[    5.897059] CPU: 0 PID: 994 Comm: udevd Not tainted 4.6.0-rc5-letux+ #233
[    5.897062] Hardware name: Generic OMAP5 (Flattened Device Tree)
[    5.897076] [] (unwind_backtrace) from [] (show_stack+0x10/0x14)
[    5.897087] [] (show_stack) from [] (dump_stack+0x88/0xc0)
[    5.897099] [] (dump_stack) from [] (__schedule_bug+0xac/0xd0)
[    5.897111] [] (__schedule_bug) from [] (__schedule+0x88/0x7e4)
[    5.897120] [] (__schedule) from [] (schedule+0x9c/0xc0)
[    5.897129] [] (schedule) from [] (schedule_preempt_disabled+0x14/0x20)
[    5.897140] [] (schedule_preempt_disabled) from [] (mutex_lock_nested+0x258/0x43c)
[    5.897150] [] (mutex_lock_nested) from [] (clk_prepare_lock+0x48/0xe0)
[    5.897160] [] (clk_prepare_lock) from [] (clk_prepare+0x10/0x28)
[    5.897169] [] (clk_prepare) from [] (omap_tll_enable+0x64/0xd0)
[    5.897180] [] (omap_tll_enable) from [] (usbhs_runtime_resume+0x18/0x17c)
[    5.897192] [] (usbhs_runtime_resume) from [] (pm_generic_runtime_resume+0x2c/0x40)
[    5.897202] [] (pm_generic_runtime_resume) from [] (__rpm_callback+0x38/0x68)
[    5.897210] [] (__rpm_callback) from [] (rpm_callback+0x70/0x88)
[    5.897218] [] (rpm_callback) from [] (rpm_resume+0x4ec/0x7ec)
[    5.897227] [] (rpm_resume) from [] (__pm_runtime_resume+0x4c/0x64)
[    5.897236] [] (__pm_runtime_resume) from [] (driver_probe_device+0x30/0x70)
[    5.897246] [] (driver_probe_device) from [] (__driver_attach+0x88/0xac)
[    5.897256] [] (__driver_attach) from [] (bus_for_each_dev+0x50/0x84)
[    5.897267] [] (bus_for_each_dev) from [] (bus_add_driver+0xcc/0x1e4)
[    5.897276] [] (bus_add_driver) from [] (driver_register+0xac/0xf4)
[    5.897286] [] (driver_register) from [] (do_one_initcall+0x100/0x1b8)
[    5.897296] [] (do_one_initcall) from [] (do_init_module+0x58/0x1c0)
[    5.897304] [] (do_init_module) from [] (SyS_finit_module+0x88/0x90)
[    5.897313] [] (SyS_finit_module) from [] (ret_fast_syscall+0x0/0x1c)
[    5.912697] ------------[ cut here ]------------
[    5.912711] WARNING: CPU: 0 PID: 994 at kernel/sched/core.c:2996 _raw_spin_unlock+0x28/0x58
[    5.912717] DEBUG_LOCKS_WARN_ON(val > preempt_count())

Reported-by: H. Nikolaus Schaller 
Tested-by: H. Nikolaus Schaller 
Signed-off-by: Roger Quadros 
Signed-off-by: Lee Jones 
Signed-off-by: Ben Hutchings

mfd: lp8788-irq: Uninitialized variable in irq handler

2016-08-22T21:37:49+00:00

commit 22aab38e7b59fd79ce1045006be69a9abab58e5a upstream.

Instead to being true/false, the "handled" is true/uninitialized.
Presumably this doesn't cause that many problems in real life because
normally we handle the IRQ.

Fixes: eea6b7cc53aa ('mfd: Add lp8788 mfd driver')
Signed-off-by: Dan Carpenter 
Acked-by: Milo Kim 
Signed-off-by: Lee Jones 
Signed-off-by: Ben Hutchings

mfd: twl6040: Fix deferred probe handling for clk32k

2015-12-13T17:49:39+00:00

commit 75c08f17ec87c2d742487bb87408d6feebc526bd upstream.

Commit 68bab8662f49 ("mfd: twl6040: Optional clk32k clock handling")
added clock handling for the 32k clock from palmas-clk. However, that
patch did not consider a typical situation where twl6040 is built-in,
and palmas-clk is a loadable module like we have in omap2plus_defconfig.

If palmas-clk is not loaded before twl6040 probes, we will get a
"clk32k is not handled" warning during booting. This means that any
drivers relying on this clock will mysteriously fail, including
omap5-uevm WLAN and audio.

Note that for WLAN, we probably should also eventually get
the clk32kgaudio for MMC3 directly as that's shared between
audio and WLAN SDIO at least for omap5-uevm. It seems the
WLAN chip cannot get it as otherwise MMC3 won't get properly
probed.

Fixes: 68bab8662f49 ("mfd: twl6040: Optional clk32k clock handling")
Signed-off-by: Tony Lindgren 
Reviewed-by: Felipe Balbi 
Signed-off-by: Lee Jones 
Signed-off-by: Luis Henriques

mfd: arizona: Fix initialisation of the PM runtime

2015-08-31T13:14:06+00:00

commit 72e43164fd472f6c2659c8313b87da962322dbcf upstream.

The PM runtime core by default assumes a chip is suspended when runtime
PM is enabled. Currently the arizona driver enables runtime PM when the
chip is fully active and then disables the DCVDD regulator at the end of
arizona_dev_init. This however has several problems, firstly the if we
reach the end of arizona_dev_init, we did not properly follow all the
proceedures for shutting down the chip, and most notably we never marked
the chip as cache only so any writes occurring between then and the next
PM runtime resume will be lost. Secondly, if we are already resumed when
we reach the end of dev_init, then at best we get unbalanced regulator
enable/disables at work we lose DCVDD whilst we need it.

Additionally, since the commit 4f0216409f7c ("mfd: arizona: Add better
support for system suspend"), the PM runtime operations may
disable/enable the IRQ, so the IRQs must now be enabled before we call
any PM operations.

This patch adds a call to pm_runtime_set_active to inform the PM core
that the device is starting up active and moves the PM enabling to
around the IRQ initialisation to avoid any PM callbacks happening until
the IRQs are initialised.

Signed-off-by: Charles Keepax 
Signed-off-by: Lee Jones 
[ luis: backported to 3.16: adjusted context ]
Signed-off-by: Luis Henriques

mfd: kempld-core: Fix callback return value check

2015-04-10T09:03:55+00:00

commit c8648508ebfc597058d2cd00b6c539110264a167 upstream.

On success, callback function returns 0. So invert the if condition
check so that we can break out of loop.

Signed-off-by: Ameya Palande <2ameya@gmail.com>
Signed-off-by: Lee Jones 
Signed-off-by: Luis Henriques

mfd: rtsx_usb: Fix runtime PM deadlock

2015-02-04T10:57:40+00:00

commit b166010f6afbadb896efa37ff85eb681a8f89392 upstream.

sd_set_power_mode() in derived module drivers/mmc/host/rtsx_usb_sdmmc.c
acquires dev_mutex and then calls pm_runtime_get_sync() to make sure the
device is awake while initializing a newly inserted card. Once it is
called during suspending state and explicitly before rtsx_usb_suspend()
acquires the same dev_mutex, both routine deadlock and further hang the
driver because pm_runtime_get_sync() waits the pending PM operations.

Fix this by using an empty suspend method. mmc_core always turns the
LED off after a request is done and thus it is ok to remove the only
rtsx_usb_turn_off_led() here.

Fixes: 730876be2566 ("mfd: Add realtek USB card reader driver")
Signed-off-by: Roger Tseng 
[Lee: Removed newly unused variable]
Signed-off-by: Lee Jones 
Signed-off-by: Luis Henriques

mfd: tps65218: Make INT1 our status_base register

2015-02-04T10:57:39+00:00

commit f29ae369a412942e81035984fa3d7a22ddf91fcb upstream.

If we don't tell regmap-irq that our first status
register is at offset 1, it will try to read offset
zero, which is the chipid register.

Fixes: 44b4dc6 mfd: tps65218: Add driver for the TPS65218 PMIC
Signed-off-by: Felipe Balbi 
Signed-off-by: Lee Jones 
Signed-off-by: Luis Henriques