linux-stable.git/drivers/mfd, branch linux-4.1.y

mfd: palmas: Reset the POWERHOLD mux during power off

2018-05-23T01:33:50+00:00

[ Upstream commit 85fdaf8eb9bbec1f0f8a52fd5d85659d60738816 ]

POWERHOLD signal has higher priority  over the DEV_ON bit.
So power off will not happen if the POWERHOLD is held high.
Hence reset the MUX to GPIO_7 mode to release the POWERHOLD
and the DEV_ON bit to take effect to power off the PMIC.

PMIC Power off happens in dire situations like thermal shutdown
so irrespective of the POWERHOLD setting go ahead and turn off
the powerhold.  Currently poweroff is broken on boards that have
powerhold enabled. This fixes poweroff on those boards.

Signed-off-by: Keerthy 
Signed-off-by: Lee Jones 
Signed-off-by: Sasha Levin

mfd: twl6040: Fix child-node lookup

2018-03-01T00:32:16+00:00

[ Upstream commit 85e9b13cbb130a3209f21bd7933933399c389ffe ]

Fix child-node lookup during probe, which ended up searching the whole
device tree depth-first starting at the parent rather than just matching
on its children.

To make things worse, the parent node was prematurely freed, while the
child node was leaked.

Note that the CONFIG_OF compile guard can be removed as
of_get_child_by_name() provides a !CONFIG_OF implementation which always
fails.

Cc: stable      # 3.5
Fixes: 37e13cecaa14 ("mfd: Add support for Device Tree to twl6040")
Fixes: ca2cad6ae38e ("mfd: Fix twl6040 build failure")
Signed-off-by: Johan Hovold 
Acked-by: Peter Ujfalusi 
Signed-off-by: Lee Jones 
Signed-off-by: Sasha Levin

mfd: twl4030-audio: Fix sibling-node lookup

2018-03-01T00:32:16+00:00

[ Upstream commit 0a423772de2f3d7b00899987884f62f63ae00dcb ]

A helper purported to look up a child node based on its name was using
the wrong of-helper and ended up prematurely freeing the parent of-node
while leaking any matching node.

To make things worse, any matching node would not even necessarily be a
child node as the whole device tree was searched depth-first starting at
the parent.

Fixes: 019a7e6b7b31 ("mfd: twl4030-audio: Add DT support")
Cc: stable      # 3.7
Signed-off-by: Johan Hovold 
Acked-by: Peter Ujfalusi 
Signed-off-by: Lee Jones 
Signed-off-by: Sasha Levin

mfd: ab8500-sysctrl: Handle probe deferral

2017-12-07T02:19:55+00:00

[ Upstream commit 7e9c40c63933a643908d686bd89dfc2315e8c70a ]

In the current boot, clients making use of the AB8500 sysctrl
may be probed before the ab8500-sysctrl driver. This gives them
-EINVAL, but should rather give -EPROBE_DEFER.

Before this, the abx500 clock driver didn't probe properly,
and as a result the codec driver in turn using the clocks did
not probe properly. After this patch, everything probes
properly.

Also add OF compatible-string probing. This driver is all
device tree, so let's just make a drive-by-fix of that as
well.

Signed-off-by: Linus Walleij 
Signed-off-by: Lee Jones 
Signed-off-by: Sasha Levin

mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode

2017-06-26T02:02:21+00:00

[ Upstream commit 8b8a84c54aff4256d592dc18346c65ecf6811b45 ]

Commit 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
added support for USB TLL, but uses OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
bit the wrong way. The comments in the code are correct, but the inverted
use of OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF causes the register to be
enabled instead of disabled unlike what the comments say.

Without this change the Wrigley 3G LTE modem on droid 4 EHCI bus can
be only pinged few times before it stops responding.

Fixes: 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
Signed-off-by: Tony Lindgren 
Acked-by: Roger Quadros 
Signed-off-by: Lee Jones 
Signed-off-by: Sasha Levin

mfd: qcom_rpm: Parametrize also ack selector size

2016-08-16T12:25:09+00:00

[ Upstream commit f37be01e6dc606f2fcc5e95c9933d948ce19bd35 ]

The RPM has two sets of selectors (IPC bit fields): request and
acknowledge. Apparently, some models use 4*32 bit words for select
and some use 7*32 bit words for request, but all use 7*32 words
for acknowledge bits.

So apparently you can on the models with requests of 4*32 select
bits send 4*32 messages and get 7*32 different replies, so on ACK
interrupt, 7*32 bit words need to be read. This is how the vendor
code apparently works.

Cc: stable@vger.kernel.org
Reported-by: Stephen Boyd 
Signed-off-by: Linus Walleij 
Reviewed-by: Bjorn Andersson 
Signed-off-by: Lee Jones 
Signed-off-by: Sasha Levin

mfd: qcom_rpm: Fix offset error for msm8660

2016-08-16T12:25:09+00:00

[ Upstream commit 9835f1b70bb3890d38308b9be4fb9d7451ba67f1 ]

The RPM in MSM8660/APQ8060 has different offsets to the selector
ACK and request context ACK registers. Make all these register
offsets part of the per-SoC data and assign the right values.

The bug was found by verifying backwards to the vendor tree in
the out-of-tree files : all were using
offsets 3,11,15,23 and a select size of 4, except the MSM8660/APQ8060
which was using offsets 3,11,19,27 and a select size of 7.

All other platforms apart from msm8660 were affected by reading
excess registers, since 7 was hardcoded as the number of select
words, this patch makes also this part dynamic so we only write/read
as many select words as the platform actually use.

Symptoms of this bug when using msm8660: the first RPM transaction
would work, but the next would stall or raise an error since the
previous transaction was not properly ACKed as the ACK words were
read at the wrong offset.

Cc: stable@vger.kernel.org
Fixes: 58e214382bdd ("mfd: qcom-rpm: Driver for the Qualcomm RPM")
Signed-off-by: Linus Walleij 
Reviewed-by: Björn Andersson 
Signed-off-by: Lee Jones 
Signed-off-by: Sasha Levin

mfd: omap-usb-tll: Fix scheduling while atomic BUG

2016-06-06T23:12:14+00:00

[ Upstream commit b49b927f16acee626c56a1af4ab4cb062f75b5df ]

We shouldn't be calling clk_prepare_enable()/clk_prepare_disable()
in an atomic context.

Fixes the following issue:

[    5.830970] ehci-omap: OMAP-EHCI Host Controller driver
[    5.830974] driver_register 'ehci-omap'
[    5.895849] driver_register 'wl1271_sdio'
[    5.896870] BUG: scheduling while atomic: udevd/994/0x00000002
[    5.896876] 4 locks held by udevd/994:
[    5.896904]  #0:  (&dev->mutex){......}, at: [] __driver_attach+0x60/0xac
[    5.896923]  #1:  (&dev->mutex){......}, at: [] __driver_attach+0x70/0xac
[    5.896946]  #2:  (tll_lock){+.+...}, at: [] omap_tll_enable+0x2c/0xd0
[    5.896966]  #3:  (prepare_lock){+.+...}, at: [] clk_prepare_lock+0x48/0xe0
[    5.897042] Modules linked in: wlcore_sdio(+) ehci_omap(+) dwc3_omap snd_soc_ts3a225e leds_is31fl319x bq27xxx_battery_i2c tsc2007 bq27xxx_battery bq2429x_charger ina2xx tca8418_keypad as5013 leds_tca6507 twl6040_vibra gpio_twl6040 bmp085_i2c(+) palmas_gpadc usb3503 palmas_pwrbutton bmg160_i2c(+) bmp085 bma150(+) bmg160_core bmp280 input_polldev snd_soc_omap_mcbsp snd_soc_omap_mcpdm snd_soc_omap snd_pcm_dmaengine
[    5.897048] Preemption disabled at:[<  (null)>]   (null)
[    5.897051]
[    5.897059] CPU: 0 PID: 994 Comm: udevd Not tainted 4.6.0-rc5-letux+ #233
[    5.897062] Hardware name: Generic OMAP5 (Flattened Device Tree)
[    5.897076] [] (unwind_backtrace) from [] (show_stack+0x10/0x14)
[    5.897087] [] (show_stack) from [] (dump_stack+0x88/0xc0)
[    5.897099] [] (dump_stack) from [] (__schedule_bug+0xac/0xd0)
[    5.897111] [] (__schedule_bug) from [] (__schedule+0x88/0x7e4)
[    5.897120] [] (__schedule) from [] (schedule+0x9c/0xc0)
[    5.897129] [] (schedule) from [] (schedule_preempt_disabled+0x14/0x20)
[    5.897140] [] (schedule_preempt_disabled) from [] (mutex_lock_nested+0x258/0x43c)
[    5.897150] [] (mutex_lock_nested) from [] (clk_prepare_lock+0x48/0xe0)
[    5.897160] [] (clk_prepare_lock) from [] (clk_prepare+0x10/0x28)
[    5.897169] [] (clk_prepare) from [] (omap_tll_enable+0x64/0xd0)
[    5.897180] [] (omap_tll_enable) from [] (usbhs_runtime_resume+0x18/0x17c)
[    5.897192] [] (usbhs_runtime_resume) from [] (pm_generic_runtime_resume+0x2c/0x40)
[    5.897202] [] (pm_generic_runtime_resume) from [] (__rpm_callback+0x38/0x68)
[    5.897210] [] (__rpm_callback) from [] (rpm_callback+0x70/0x88)
[    5.897218] [] (rpm_callback) from [] (rpm_resume+0x4ec/0x7ec)
[    5.897227] [] (rpm_resume) from [] (__pm_runtime_resume+0x4c/0x64)
[    5.897236] [] (__pm_runtime_resume) from [] (driver_probe_device+0x30/0x70)
[    5.897246] [] (driver_probe_device) from [] (__driver_attach+0x88/0xac)
[    5.897256] [] (__driver_attach) from [] (bus_for_each_dev+0x50/0x84)
[    5.897267] [] (bus_for_each_dev) from [] (bus_add_driver+0xcc/0x1e4)
[    5.897276] [] (bus_add_driver) from [] (driver_register+0xac/0xf4)
[    5.897286] [] (driver_register) from [] (do_one_initcall+0x100/0x1b8)
[    5.897296] [] (do_one_initcall) from [] (do_init_module+0x58/0x1c0)
[    5.897304] [] (do_init_module) from [] (SyS_finit_module+0x88/0x90)
[    5.897313] [] (SyS_finit_module) from [] (ret_fast_syscall+0x0/0x1c)
[    5.912697] ------------[ cut here ]------------
[    5.912711] WARNING: CPU: 0 PID: 994 at kernel/sched/core.c:2996 _raw_spin_unlock+0x28/0x58
[    5.912717] DEBUG_LOCKS_WARN_ON(val > preempt_count())

Cc: 
Reported-by: H. Nikolaus Schaller 
Tested-by: H. Nikolaus Schaller 
Signed-off-by: Roger Quadros 
Signed-off-by: Lee Jones 
Signed-off-by: Sasha Levin

mfd: intel_quark_i2c_gpio: load gpio driver first

2016-06-03T23:15:26+00:00

[ Upstream commit c39dc960e9c5196022cbc46507d4782b6fc314f6 ]

On Intel Galileo boards the GPIO expander is connected to i2c bus. Moreover it
is able to generate interrupt, but interrupt line is connected to GPIO. That's
why we have to have GPIO driver in place when we will probe i2c host with
device connected to it.

Acked-by: Lee Jones 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Wolfram Sang 
Signed-off-by: Sasha Levin

mfd: twl6040: Fix deferred probe handling for clk32k

2015-12-09T19:03:20+00:00

commit 75c08f17ec87c2d742487bb87408d6feebc526bd upstream.

Commit 68bab8662f49 ("mfd: twl6040: Optional clk32k clock handling")
added clock handling for the 32k clock from palmas-clk. However, that
patch did not consider a typical situation where twl6040 is built-in,
and palmas-clk is a loadable module like we have in omap2plus_defconfig.

If palmas-clk is not loaded before twl6040 probes, we will get a
"clk32k is not handled" warning during booting. This means that any
drivers relying on this clock will mysteriously fail, including
omap5-uevm WLAN and audio.

Note that for WLAN, we probably should also eventually get
the clk32kgaudio for MMC3 directly as that's shared between
audio and WLAN SDIO at least for omap5-uevm. It seems the
WLAN chip cannot get it as otherwise MMC3 won't get properly
probed.

Fixes: 68bab8662f49 ("mfd: twl6040: Optional clk32k clock handling")
Signed-off-by: Tony Lindgren 
Reviewed-by: Felipe Balbi 
Signed-off-by: Lee Jones 
Signed-off-by: Greg Kroah-Hartman