linux-stable.git/drivers/mfd, branch linux-3.14.y

mfd: omap-usb-tll: Fix scheduling while atomic BUG

2016-06-01T19:12:47+00:00

commit b49b927f16acee626c56a1af4ab4cb062f75b5df upstream.

We shouldn't be calling clk_prepare_enable()/clk_prepare_disable()
in an atomic context.

Fixes the following issue:

[    5.830970] ehci-omap: OMAP-EHCI Host Controller driver
[    5.830974] driver_register 'ehci-omap'
[    5.895849] driver_register 'wl1271_sdio'
[    5.896870] BUG: scheduling while atomic: udevd/994/0x00000002
[    5.896876] 4 locks held by udevd/994:
[    5.896904]  #0:  (&dev->mutex){......}, at: [] __driver_attach+0x60/0xac
[    5.896923]  #1:  (&dev->mutex){......}, at: [] __driver_attach+0x70/0xac
[    5.896946]  #2:  (tll_lock){+.+...}, at: [] omap_tll_enable+0x2c/0xd0
[    5.896966]  #3:  (prepare_lock){+.+...}, at: [] clk_prepare_lock+0x48/0xe0
[    5.897042] Modules linked in: wlcore_sdio(+) ehci_omap(+) dwc3_omap snd_soc_ts3a225e leds_is31fl319x bq27xxx_battery_i2c tsc2007 bq27xxx_battery bq2429x_charger ina2xx tca8418_keypad as5013 leds_tca6507 twl6040_vibra gpio_twl6040 bmp085_i2c(+) palmas_gpadc usb3503 palmas_pwrbutton bmg160_i2c(+) bmp085 bma150(+) bmg160_core bmp280 input_polldev snd_soc_omap_mcbsp snd_soc_omap_mcpdm snd_soc_omap snd_pcm_dmaengine
[    5.897048] Preemption disabled at:[<  (null)>]   (null)
[    5.897051]
[    5.897059] CPU: 0 PID: 994 Comm: udevd Not tainted 4.6.0-rc5-letux+ #233
[    5.897062] Hardware name: Generic OMAP5 (Flattened Device Tree)
[    5.897076] [] (unwind_backtrace) from [] (show_stack+0x10/0x14)
[    5.897087] [] (show_stack) from [] (dump_stack+0x88/0xc0)
[    5.897099] [] (dump_stack) from [] (__schedule_bug+0xac/0xd0)
[    5.897111] [] (__schedule_bug) from [] (__schedule+0x88/0x7e4)
[    5.897120] [] (__schedule) from [] (schedule+0x9c/0xc0)
[    5.897129] [] (schedule) from [] (schedule_preempt_disabled+0x14/0x20)
[    5.897140] [] (schedule_preempt_disabled) from [] (mutex_lock_nested+0x258/0x43c)
[    5.897150] [] (mutex_lock_nested) from [] (clk_prepare_lock+0x48/0xe0)
[    5.897160] [] (clk_prepare_lock) from [] (clk_prepare+0x10/0x28)
[    5.897169] [] (clk_prepare) from [] (omap_tll_enable+0x64/0xd0)
[    5.897180] [] (omap_tll_enable) from [] (usbhs_runtime_resume+0x18/0x17c)
[    5.897192] [] (usbhs_runtime_resume) from [] (pm_generic_runtime_resume+0x2c/0x40)
[    5.897202] [] (pm_generic_runtime_resume) from [] (__rpm_callback+0x38/0x68)
[    5.897210] [] (__rpm_callback) from [] (rpm_callback+0x70/0x88)
[    5.897218] [] (rpm_callback) from [] (rpm_resume+0x4ec/0x7ec)
[    5.897227] [] (rpm_resume) from [] (__pm_runtime_resume+0x4c/0x64)
[    5.897236] [] (__pm_runtime_resume) from [] (driver_probe_device+0x30/0x70)
[    5.897246] [] (driver_probe_device) from [] (__driver_attach+0x88/0xac)
[    5.897256] [] (__driver_attach) from [] (bus_for_each_dev+0x50/0x84)
[    5.897267] [] (bus_for_each_dev) from [] (bus_add_driver+0xcc/0x1e4)
[    5.897276] [] (bus_add_driver) from [] (driver_register+0xac/0xf4)
[    5.897286] [] (driver_register) from [] (do_one_initcall+0x100/0x1b8)
[    5.897296] [] (do_one_initcall) from [] (do_init_module+0x58/0x1c0)
[    5.897304] [] (do_init_module) from [] (SyS_finit_module+0x88/0x90)
[    5.897313] [] (SyS_finit_module) from [] (ret_fast_syscall+0x0/0x1c)
[    5.912697] ------------[ cut here ]------------
[    5.912711] WARNING: CPU: 0 PID: 994 at kernel/sched/core.c:2996 _raw_spin_unlock+0x28/0x58
[    5.912717] DEBUG_LOCKS_WARN_ON(val > preempt_count())

Reported-by: H. Nikolaus Schaller 
Tested-by: H. Nikolaus Schaller 
Signed-off-by: Roger Quadros 
Signed-off-by: Lee Jones 
Signed-off-by: Greg Kroah-Hartman

mfd: kempld-core: Fix callback return value check

2015-04-13T12:03:04+00:00

commit c8648508ebfc597058d2cd00b6c539110264a167 upstream.

On success, callback function returns 0. So invert the if condition
check so that we can break out of loop.

Signed-off-by: Ameya Palande <2ameya@gmail.com>
Signed-off-by: Lee Jones 
Signed-off-by: Greg Kroah-Hartman

mfd: tc6393xb: Fail ohci suspend if full state restore is required

2015-01-08T18:00:48+00:00

commit 1a5fb99de4850cba710d91becfa2c65653048589 upstream.

Some boards with TC6393XB chip require full state restore during system
resume thanks to chip's VCC being cut off during suspend (Sharp SL-6000
tosa is one of them). Failing to do so would result in ohci Oops on
resume due to internal memory contentes being changed. Fail ohci suspend
on tc6393xb is full state restore is required.

Recommended workaround is to unbind tmio-ohci driver before suspend and
rebind it after resume.

Signed-off-by: Dmitry Eremin-Solenikov 
Signed-off-by: Lee Jones 
Signed-off-by: Greg Kroah-Hartman

mfd: rtsx_pcr: Fix MSI enable error handling

2014-11-14T16:59:50+00:00

commit 5152970538a5e16c03bbcb9f1c780489a795ed40 upstream.

pci_enable_msi() can return failure with both positive and negative
integers -- it returns 0 for success -- but is only tested here for
"if (ret < 0)".  This causes us to try to use MSI on the RTS5249 SD
reader in the Dell XPS 11 when enabling MSI failed, causing:

[    1.737110] rtsx_pci: probe of 0000:05:00.0 failed with error -110

Reported-by: D. Jared Dominguez 
Tested-by: D. Jared Dominguez 
Signed-off-by: Chris Ball 
Signed-off-by: Lee Jones 
Signed-off-by: Greg Kroah-Hartman

mfd: ti_am335x_tscadc: Fix TSC resume

2014-11-14T16:59:50+00:00

commit 6a71f38dd87f255a0586104ce2a14d5a3ddf3401 upstream.

In the resume path, the ADC invokes am335x_tsc_se_set_cache() with 0 as
the steps argument if continous mode is not in use. This in turn disables
all steps and so the TSC is not working until one ADC sampling is
performed.

This patch fixes it by writing the current cached mask instead of the
passed steps.

Fixes: 7ca6740cd1cd ("mfd: input: iio: ti_amm335x: Rework TSC/ADCA
synchronization")
Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Lee Jones 
Signed-off-by: Greg Kroah-Hartman

mfd: ti_am335x_tscadc: Fix TSC operation after ADC continouous mode

2014-11-14T16:59:50+00:00

commit 6ac734d2242949f41eb1346ca0fd4ed010c937aa upstream.

After enabling and disabling ADC continuous mode via sysfs, ts_print_raw
fails to return any data. This is because when ADC is configured for
continuous mode, it disables touch screen steps.These steps are not
re-enabled when ADC continuous mode is disabled. Therefore existing values
of REG_SE needs to be cached before enabling continuous mode and
disabling touch screen steps and enabling ADC steps. The cached value
are to be restored to REG_SE once ADC is disabled.

Fixes: 7ca6740cd1cd ("mfd: input: iio: ti_amm335x: Rework TSC/ADC synchronization")

Signed-off-by: Vignesh R 
Signed-off-by: Lee Jones 
Signed-off-by: Greg Kroah-Hartman

mfd: omap-usb-host: Fix improper mask use.

2014-09-17T16:19:09+00:00

commit 46de8ff8e80a6546aa3d2fdf58c6776666301a0c upstream.

single-ulpi-bypass is a flag used for older OMAP3 silicon.

The flag when set, can excite code that improperly uses the
OMAP_UHH_HOSTCONFIG_UPLI_BYPASS define to clear the corresponding bit.
Instead it clears all of the other bits disabling all of the ports in
the process.

Signed-off-by: Michael Welling 
Signed-off-by: Lee Jones 
Signed-off-by: Greg Kroah-Hartman

mfd: twl-core: Fix accessibility of some twl4030 audio registers

2014-05-06T14:59:26+00:00

commit 56816b700c8c773270f3aaf4c92be53e359a03fd upstream.

There are some unused registers in twl4030 at I2C address 0x49 and function
twl4030_49_nop_reg() is used to check accessibility of that registers. These
registers are written in decimal format but the values are correct in
hexadecimal format. (It can be checked few lines above the patched code -
these registers are marked as unused there.)

As a consequence three registers of audio submodule are treated as
inaccessible (preamplifier carkit right and both handsfree registers).

Signed-off-by: Tomas Novotny 
Signed-off-by: Lee Jones 
Signed-off-by: Greg Kroah-Hartman

mfd: kempld-core: Fix potential hang-up during boot

2014-05-06T14:59:25+00:00

commit 204747c970c0d568721c76ab8a57dde0e5dcf0d5 upstream.

On PXT and COMe-cPC2 boards it is observed that the hardware
mutex is acquired but not being released during initialization.
This can result in a hang-up during boot if the driver is built
into the kernel.

Releasing the mutex twice if it was acquired fixes the problem.
Subsequent request/release cycles work as expected, so the fix is
only needed during initialization.

Reviewed-by: Michael Brunner 
Tested-by: Michael Brunner 
Signed-off-by: Guenter Roeck 
Signed-off-by: Lee Jones 
Signed-off-by: Greg Kroah-Hartman

mfd: tps65910: Fix possible invalid pointer dereference on regmap_add_irq_chip fail

2014-05-06T14:59:25+00:00

commit 483e2dfdbc94751430e41db9973985f5b054d322 upstream.

Fixes: 4aab3fadad32 ("mfd: tps65910: Move interrupt implementation code to mfd file")

tps65910_irq_init() sets 'tps65910->chip_irq' before calling
regmap_add_irq_chip(). If the regmap_add_irq_chip() call fails in
memory allocation of regmap_irq_chip_data members then:

1. The 'tps65910->chip_irq' will still hold some value
2. 'tps65910->irq_data' will be pointing to already freed memory
   (because regmap_add_irq_chip() will free it on error)

This results in invalid memory access during driver remove because the
tps65910_irq_exit() tests whether 'tps65910->chip_irq' is not zero.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Lee Jones 
Signed-off-by: Greg Kroah-Hartman