linux-stable.git/drivers/mfd/ipaq-micro.c, branch linux-4.19.y

mfd: ipaq-micro: Fix error check return value of platform_get_irq()

2022-06-14T14:59:24+00:00

[ Upstream commit 3b49ae380ce1a3054e0c505dd9a356b82a5b48e8 ]

platform_get_irq() return negative value on failure, so null check of
irq is incorrect. Fix it by comparing whether it is less than zero.

Fixes: dcc21cc09e3c ("mfd: Add driver for Atmel Microcontroller on iPaq h3xxx")
Reported-by: Zeal Robot 
Signed-off-by: Lv Ruyi 
Reviewed-by: Linus Walleij 
Signed-off-by: Lee Jones 
Link: https://lore.kernel.org/r/20220412085305.2533030-1-lv.ruyi@zte.com.cn
Signed-off-by: Sasha Levin

mfd: ipaq-micro: Dump debugging hexdumps

2017-07-06T07:29:11+00:00

These hexdumps get printed no matter if CONFIG_DEBUG is set or
not. Just get rid of them.

Signed-off-by: Linus Walleij 
Signed-off-by: Lee Jones

mfd: ipaq-micro: Delete redundant return value check of platform_get_resource()

2017-04-27T08:25:05+00:00

devm_ioremap_resource does checks on the resource. No need to
duplicate this in the driver.

Signed-off-by: Belén Sarabia 
Signed-off-by: Lee Jones

mfd: ipaq-micro: Use __maybe_unused to hide pm functions

2016-03-16T08:50:41+00:00

The ipaq-micro driver uses SET_SYSTEM_SLEEP_PM_OPS() to
remove the reference to its resume function, but does
not use an #ifdef around the definition, so we get
a build warning:

drivers/mfd/ipaq-micro.c:379:12: error: 'micro_resume' defined but not used [-Werror=unused-function]

This adds a __maybe_unused annotation so the compiler knows
it can silently drop it instead of warning.

Signed-off-by: Arnd Bergmann 
Signed-off-by: Lee Jones

mfd: ipaq-micro: Convert to built-in platform driver

2015-08-11T14:09:00+00:00

Signal that this is a built-in driver and call its probe function
immediately on init. Suppress binding attributes and delete the
.remove() function since it is never unloaded. Tag probe() and
functions only called from probe() with __init. Delete all module
macros since this is a pure built-in.

Signed-off-by: Linus Walleij 
Signed-off-by: Lee Jones

mfd: ipaq-micro: Convert prints to debug prints

2015-08-11T14:08:59+00:00

There is a special function for debug prints rather than the
usual hexdump function, let's use it.

Signed-off-by: Linus Walleij 
Signed-off-by: Lee Jones

mfd: ipaq-micro: Clean up development cruft

2015-08-11T14:08:58+00:00

Clean out a misspelled "HW" (MW) and remove commented-out
codeline.

Signed-off-by: Linus Walleij 
Signed-off-by: Lee Jones

mfd: ipaq-micro: Fix coding style errors/warnings reported by checkpatch

2014-07-25T14:31:45+00:00

This is part of an effort to clean-up the MFD subsystem.

ERROR: space required before the open parenthesis '('
+                       if(!micro->msg)

WARNING: unnecessary whitespace before a quoted newline
+                       dev_dbg(micro->dev, "key message ignored, no handle \n");

WARNING: unnecessary whitespace before a quoted newline
+                       dev_dbg(micro->dev, "touchscreen message ignored, no handle \n");

WARNING: space prohibited before semicolon
+               rx->id = (ch & 0xf0) >> 4 ;

total: 1 errors, 3 warnings, 482 lines checked

Signed-off-by: Lee Jones

mfd: ipaq-micro: Make mfd_cell array const

2014-06-03T07:11:43+00:00

mfd_add_devices() expects array of struct mfd_cell to be const.

Signed-off-by: Krzysztof Kozlowski 
Acked-by: Linus Walleij 
Signed-off-by: Lee Jones

mfd: ipaq-micro: Use devm_ioremap_resource()

2014-06-03T07:11:42+00:00

Use devm_ioremap_resource() because devm_request_and_ioremap() is
obsoleted by devm_ioremap_resource().

Signed-off-by: Jingoo Han 
Acked-by: Linus Walleij 
Signed-off-by: Lee Jones