linux-stable.git/drivers/memstick, branch v4.9.166

memstick: Prevent memstick host from getting runtime suspended during card detection

2019-02-12T18:44:55+00:00

[ Upstream commit e03e303edf1c63e6dd455ccd568c74e93ef3ba8c ]

We can use MEMSTICK_POWER_{ON,OFF} along with pm_runtime_{get,put}
helpers to let memstick host support runtime pm.

The rpm count may go down to zero before the memstick host powers on, so
the host can be runtime suspended.

So before doing card detection, increment the rpm count to avoid the
host gets runtime suspended. Balance the rpm count after card detection
is done.

Signed-off-by: Kai-Heng Feng 
Tested-by: Oleksandr Natalenko 
Signed-off-by: Ulf Hansson 
Signed-off-by: Sasha Levin

memstick: rtsx_usb_ms: Manage runtime PM when accessing the device

2016-10-17T13:43:05+00:00

Accesses to the rtsx usb device, which is the parent of the rtsx memstick
device, must not be done unless it's runtime resumed. This is currently not
the case and it could trigger various errors.

Fix this by properly deal with runtime PM in this regards. This means
making sure the device is runtime resumed, when serving requests via the
->request() callback or changing settings via the ->set_param() callbacks.

Cc: 
Cc: Ritesh Raj Sarraf 
Cc: Alan Stern 
Signed-off-by: Ulf Hansson

memstick: rtsx_usb_ms: Runtime resume the device when polling for cards

2016-10-17T13:43:04+00:00

Accesses to the rtsx usb device, which is the parent of the rtsx memstick
device, must not be done unless it's runtime resumed.

Therefore when the rtsx_usb_ms driver polls for inserted memstick cards,
let's add pm_runtime_get|put*() to make sure accesses is done when the
rtsx usb device is runtime resumed.

Reported-by: Ritesh Raj Sarraf 
Tested-by: Ritesh Raj Sarraf 
Signed-off-by: Alan Stern 
Cc: 
Signed-off-by: Ulf Hansson

memstick: don't allocate unused major for ms_block

2016-08-02T21:31:41+00:00

When alloc_disk(0) is used the ->major number is completely ignored.
All devices are allocated with a major of BLOCK_EXT_MAJOR.

So remove registration and deregistration of 'major'.

Link: http://lkml.kernel.org/r/20160602064318.4403.49955.stgit@noble
Signed-off-by: NeilBrown 
Cc: Keith Busch 
Cc: Jens Axboe 
Cc: Maxim Levitsky 
Cc: Greg Kroah-Hartman 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

memstick: don't allow REQ_TYPE_BLOCK_PC requests

2016-07-20T23:38:27+00:00

There is no code to issue or handle REQ_TYPE_BLOCK_PC request in the
memstick drivers, so remove the bogus conditional.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block: convert to device_add_disk()

2016-06-27T19:26:08+00:00

For block drivers that specify a parent device, convert them to use
device_add_disk().

This conversion was done with the following semantic patch:

    @@
    struct gendisk *disk;
    expression E;
    @@

    - disk->driverfs_dev = E;
    ...
    - add_disk(disk);
    + device_add_disk(E, disk);

    @@
    struct gendisk *disk;
    expression E1, E2;
    @@

    - disk->driverfs_dev = E1;
    ...
    E2 = disk;
    ...
    - add_disk(E2);
    + device_add_disk(E1, E2);

...plus some manual fixups for a few missed conversions.

Cc: Jens Axboe 
Cc: Keith Busch 
Cc: Michael S. Tsirkin 
Cc: David Woodhouse 
Cc: David S. Miller 
Cc: James Bottomley 
Cc: Ross Zwisler 
Cc: Konrad Rzeszutek Wilk 
Cc: Martin K. Petersen 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Dan Williams

drivers/memstick/core/mspro_block: use kmemdup

2016-05-24T00:04:14+00:00

Use kmemdup when some other buffer is immediately copied into allocated
region.  It replaces call to allocation followed by memcpy, by a single
call to kmemdup.

[akpm@linux-foundation.org: remove unneeded cast to void*]
Link: http://lkml.kernel.org/r/1463665743-16269-1-git-send-email-falakreyaz@gmail.com
Signed-off-by: Muhammad Falak R Wani 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtsx_usb_ms: use schedule_timeout_idle() in polling loop

2016-05-24T00:04:14+00:00

First version of this patch has already been posted to LKML by Ben
Hutchings ~6 months ago, but no further action were performed.

Ben's original message:

: rtsx_usb_ms creates a task that mostly sleeps, but tasks in
: uninterruptible sleep still contribute to the load average (for
: bug-compatibility with Unix).  A load average of ~1 on a system that
: should be idle is somewhat alarming.
:
: Change the sleep to be interruptible, but still ignore signals.

References: https://bugs.debian.org/765717
Link: http://lkml.kernel.org/r/b49f95ae83057efa5d96f532803cba47@natalenko.name
Signed-off-by: Oleksandr Natalenko 
Cc: Oleg Nesterov 
Cc: Ben Hutchings 
Cc: Lee Jones 
Cc: Wolfram Sang 
Cc: Roger Tseng 
Cc: Greg KH 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

memstick: trivial fix of spelling mistake on management

2016-04-28T08:58:33+00:00

fix spelling mistake, managment -> management in literal
strings, in a variable and a macro.

Signed-off-by: Colin Ian King 
Signed-off-by: Jiri Kosina

drivers/memstick/host/r592.c: avoid gcc-6 warning

2016-03-25T23:37:42+00:00

The r592 driver relies on behavior of the DMA mapping API that is
normally observed but not guaranteed by the API.  Instead it uses a
runtime check to fail transfers if the API ever behaves

When CONFIG_NEED_SG_DMA_LENGTH is not set, one of the checks turns into a
comparison of a variable with itself, which gcc-6.0 now warns about:

drivers/memstick/host/r592.c: In function 'r592_transfer_fifo_dma':
drivers/memstick/host/r592.c:302:31: error: self-comparison always evaluates to false [-Werror=tautological-compare]
    (sg_dma_len(&dev->req->sg) < dev->req->sg.length)) {
                               ^

The check itself is not a problem, so this patch just rephrases the
condition in a way that gcc does not consider an indication of a mistake.
We already know that dev->req->sg.length was initially R592_LFIFO_SIZE, so
we can compare it to that constant again.

Signed-off-by: Arnd Bergmann 
Cc: Maxim Levitsky 
Cc: Quentin Lambert 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds