linux-stable.git/drivers/memstick, branch v3.12.52

memstick: mspro_block: add missing curly braces

2015-05-15T07:10:40+00:00

commit 13f6b191aaa11c7fd718d35a0c565f3c16bc1d99 upstream.

Using the indenting we can see the curly braces were obviously intended.
This is a static checker fix, but my guess is that we don't read enough
bytes, because we don't calculate "t_len" correctly.

Fixes: f1d82698029b ('memstick: use fully asynchronous request processing')
Signed-off-by: Dan Carpenter 
Cc: Alex Dubov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Jiri Slaby

drivers/memstick/host/rtsx_pci_ms.c: add cancel_work when remove driver

2014-11-19T17:45:04+00:00

commit b6226b45c66196e14ef628d3aead2139700db1ad upstream.

Add cancel_work_sync() in rtsx_pci_ms_drv_remove() to cancel pending
request work when removing the driver.

Signed-off-by: Micky Ching 
Cc: Samuel Ortiz  says:
Cc: Maxim Levitsky 
Cc: Greg Kroah-Hartman 
Cc: Alex Dubov 
Cc: Roger Tseng 
Cc: Wei WANG 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Jiri Slaby

drivers/memstick/core/ms_block.c: fix unreachable state in h_msb_read_page()

2013-11-29T19:28:06+00:00

commit a0e5a12fd18d47aa87a7a8c60ca5bc422b136564 upstream.

In h_msb_read_page() in ms_block.c, flow never reaches case
MSB_RP_RECIVE_STATUS_REG.  This causes error when MEMSTICK_INT_ERR is
encountered and status error bits are going to be examined, but the status
will never be copied back.

Fix it by transitioning to MSB_RP_RECIVE_STATUS_REG right after
MSB_RP_SEND_READ_STATUS_REG.

Signed-off-by: Roger Tseng 
Acked-by: Maxim Levitsky 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

memstick: add support for legacy memorysticks

2013-09-11T22:59:35+00:00

Based partially on MS standard spec quotes from Alex Dubov.

As any code that works with user data this driver isn't recommended to use
to write cards that contain valuable data.

It tries its best though to avoid data corruption and possible damage to
the card.

Tested on MS DUO 64 MB card on Ricoh R592 card reader.

Signed-off-by: Maxim Levitsky 
Cc: Valdis Kletnieks 
Cc: Jens Axboe 
Cc: Alex Dubov 
Cc: Tejun Heo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/memstick/host/rtsx_pci_ms.c: remove unnecessary platform_set_drvdata()

2013-09-11T22:59:34+00:00

The driver core clears the driver data to NULL after device_release or on
probe failure.  Thus, it is not needed to manually clear the device driver
data to NULL.

Signed-off-by: Jingoo Han 
Cc: Maxim Levitsky 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

mmc: memstick: rtsx: Modify copyright comments

2013-08-30T12:25:10+00:00

Update copyright date, and remove author address.

Signed-off-by: Wei WANG 
Acked-by: Chris Ball 
Signed-off-by: Samuel Ortiz

drivers/memstick/host/r592.c: convert to module_pci_driver

2013-07-03T23:08:06+00:00

Signed-off-by: Libo Chen 
Cc: Maxim Levitsky 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/memstick/host/jmb38x_ms: convert to module_pci_driver

2013-07-03T23:08:06+00:00

Use module_pci_driver instead of init/exit, make code clean.

Signed-off-by: Libo Chen 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

block_device_operations->release() should return void

2013-05-07T06:16:21+00:00

The value passed is 0 in all but "it can never happen" cases (and those
only in a couple of drivers) *and* it would've been lost on the way
out anyway, even if something tried to pass something meaningful.
Just don't bother.

Signed-off-by: Al Viro

drivers/memstick/host/r592.c: make r592_pm_ops static

2013-05-01T00:04:08+00:00

r592_pm_ops is not exported. Also, CONFIG_PM_SLEEP is used to
remove unnecessary ifdefs.

Signed-off-by: Jingoo Han 
Cc: Maxim Levitsky 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds