linux-stable.git/drivers/memory/samsung, branch linux-5.4.y

memory: samsung: exynos-srom: Fix of_iomap leak in exynos_srom_probe

2025-10-29T13:00:00+00:00

[ Upstream commit 6744085079e785dae5f7a2239456135407c58b25 ]

The of_platform_populate() call at the end of the function has a
possible failure path, causing a resource leak.

Replace of_iomap() with devm_platform_ioremap_resource() to ensure
automatic cleanup of srom->reg_base.

This issue was detected by smatch static analysis:
drivers/memory/samsung/exynos-srom.c:155 exynos_srom_probe()warn:
'srom->reg_base' from of_iomap() not released on lines: 155.

Fixes: 8ac2266d8831 ("memory: samsung: exynos-srom: Add support for bank configuration")
Cc: stable@vger.kernel.org
Signed-off-by: Zhen Ni 
Link: https://lore.kernel.org/r/20250806025538.306593-1-zhen.ni@easystack.cn
Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

memory: samsung: exynos-srom: Correct alignment

2025-10-29T13:00:00+00:00

[ Upstream commit 90de1c75d8acd83e9a699b93153307a1e411ef3a ]

Align indentation with open parenthesis (or fix existing alignment).

Signed-off-by: Krzysztof Kozlowski 
Stable-dep-of: 6744085079e7 ("memory: samsung: exynos-srom: Fix of_iomap leak in exynos_srom_probe")
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

memory: Convert to using %pOFn instead of device_node.name

2018-11-27T16:54:39+00:00

In preparation to remove the node name pointer from struct device_node,
convert printf users to use the %pOFn format specifier.

Cc: Roger Quadros 
Cc: Kukjin Kim 
Cc: Jonathan Hunter 
Cc: linux-omap@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Acked-by: Thierry Reding 
Acked-by: Tony Lindgren 
Acked-by: Krzysztof Kozlowski 
Signed-off-by: Rob Herring

memory: samsung: Add SPDX license identifiers

2018-02-12T18:55:34+00:00

Replace GPL license statements with SPDX GPL-2.0 license identifiers.

Signed-off-by: Krzysztof Kozlowski

memory: samsung: exynos-srom: Fix wrong count of registers

2016-07-06T06:16:56+00:00

This patch fixes wrong count of array for SROM registers from probe
function.

Signed-off-by: Seung-Woo Kim 
Reviewed-by: Chanwoo Choi 
Signed-off-by: Krzysztof Kozlowski

memory: samsung: exynos-srom: make it explicitly non-modular

2016-06-20T07:48:59+00:00

The Kconfig currently controlling compilation of this code is:

memory/samsung/Kconfig:config EXYNOS_SROM
memory/samsung/Kconfig: bool "Exynos SROM controller driver" if COMPILE_TEST

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

We explicitly disallow a driver unbind, since that doesn't have a
sensible use case anyway, and it allows us to drop the ".remove"
code for non-modular drivers.

Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Cc: Pankaj Dubey 
Signed-off-by: Paul Gortmaker 
Signed-off-by: Krzysztof Kozlowski

memory: samsung: endian fixes for IO

2016-06-20T07:43:34+00:00

Use the relaxed versions of the IO accessors to avoid any issues
if running in big endian.

Signed-off-by: Ben Dooks 
Signed-off-by: Krzysztof Kozlowski

memory: samsung: exynos-srom: Add support for bank configuration

2016-04-18T12:25:29+00:00

Implement handling properties in subnodes and adding child devices to the
system. Child devices will not be added if configuration fails.

Since the driver now does more than suspend-resume support, dependency on
CONFIG_PM is removed.

Signed-off-by: Pavel Fedin 
Reviewed-by: Krzysztof Kozlowski 
Signed-off-by: Pankaj Dubey 
Signed-off-by: Krzysztof Kozlowski

memory: Add support for Exynos SROM driver

2016-04-18T12:25:27+00:00

This patch adds Exynos SROM controller driver which will handle
save restore of SROM registers during S2R.

Signed-off-by: Pankaj Dubey 
Reviewed-by: Krzysztof Kozlowski 
[p.fedin@samsung.com: tested on SMDK5410]
Tested-by: Pavel Fedin 
Signed-off-by: Kukjin Kim 
[k.kozlowski: Minor COMPILE_TEST adjustments in Kconfig entries]
Signed-off-by: Krzysztof Kozlowski