linux-stable.git/drivers/media/platform/mem2mem_testdev.c, branch linux-3.16.y

[media] vb2: stop_streaming should return void

2014-04-23T13:12:51+00:00

The vb2 core ignores any return code from the stop_streaming op.
And there really isn't anything it can do anyway in case of an error.
So change the return type to void and update any drivers that implement it.

The int return gave drivers the idea that this operation could actually
fail, but that's really not the case.

The pwc amd sdr-msi3101 drivers both had this construction:

        if (mutex_lock_interruptible(&s->v4l2_lock))
                return -ERESTARTSYS;

This has been updated to just call mutex_lock(). The stop_streaming op
expects this to really stop streaming and I very much doubt this will
work reliably if stop_streaming just returns without really stopping the
DMA.

Signed-off-by: Hans Verkuil 
Acked-by: Pawel Osciak 
Acked-by: Sakari Ailus 
Signed-off-by: Mauro Carvalho Chehab

[media] mem2mem_testdev: improve field handling

2014-03-11T13:34:56+00:00

try_fmt should just set field to NONE and not return an error if
a different field was passed.

buf_prepare should check if the field passed in from userspace has a
supported field value. At the moment only NONE is supported and ANY
is mapped to NONE.

Signed-off-by: Hans Verkuil 
Signed-off-by: Kamil Debski 
Signed-off-by: Mauro Carvalho Chehab

[media] mem2mem_testdev: fix field, sequence and time copying

2014-03-11T13:34:36+00:00

- Set the sequence counters correctly.
- Copy timestamps, timecode, relevant buffer flags and field from
  the received buffer to the outgoing buffer.

Signed-off-by: Hans Verkuil 
Signed-off-by: Kamil Debski 
Signed-off-by: Mauro Carvalho Chehab

[media] mem2mem_testdev: return pending buffers in stop_streaming()

2014-03-11T13:31:45+00:00

To keep the vb2 buffer administration in balance stop_streaming() must
return any pending buffers to the vb2 framework.

Signed-off-by: Hans Verkuil 
Signed-off-by: Kamil Debski 
Signed-off-by: Mauro Carvalho Chehab

[media] mem2mem_testdev: add USERPTR support

2014-03-11T13:31:19+00:00

There is no reason why we shouldn't enable this here.

Signed-off-by: Hans Verkuil 
Signed-off-by: Kamil Debski 
Signed-off-by: Mauro Carvalho Chehab

[media] mem2mem_testdev: set priv to 0

2014-03-11T13:31:04+00:00

v4l2_compliance fix.

Signed-off-by: Hans Verkuil 
Signed-off-by: Kamil Debski 
Signed-off-by: Mauro Carvalho Chehab

[media] mem2mem_testdev: pick default format with try_fmt

2014-03-11T13:30:08+00:00

This resolves an issue raised by v4l2-compliance: if the given format does
not exist, then pick a default format.

While there is an exception regarding this for TV capture drivers, this
m2m driver should do the right thing.

Signed-off-by: Hans Verkuil 
Signed-off-by: Kamil Debski 
Signed-off-by: Mauro Carvalho Chehab

[media] mem2mem_testdev: use 40ms default transfer time

2014-03-11T13:29:38+00:00

The default of 1 second is a bit painful, switch to a 25 Hz framerate.

Signed-off-by: Hans Verkuil 
Signed-off-by: Kamil Debski 
Signed-off-by: Mauro Carvalho Chehab

[media] v4l: Copy timestamp source flags to destination on m2m devices

2014-03-05T19:47:15+00:00

Copy the flags containing the timestamp source from source buffer flags to
the destination buffer flags on memory-to-memory devices. This is analogous
to copying the timestamp field from source to destination.

Signed-off-by: Sakari Ailus 
Acked-by: Kamil Debski 
Signed-off-by: Mauro Carvalho Chehab

[media] v4l: Rename vb2_queue.timestamp_type as timestamp_flags

2014-03-05T19:34:14+00:00

The timestamp_type field used to contain only the timestamp type. Soon it
will be used for timestamp source flags as well. Rename the field
accordingly.

[m.chehab@samsung.com: do the change also to drivers/staging/media and at s2255]
Signed-off-by: Sakari Ailus 
Acked-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab