linux-stable.git/drivers/media/common, branch linux-6.5.y

media: vb2: frame_vector.c: replace WARN_ONCE with a comment

2023-10-06T11:16:16+00:00

[ Upstream commit 735de5caf79e06cc9fb96b1b4f4974674ae3e917 ]

The WARN_ONCE was issued also in cases that had nothing to do with VM_IO
(e.g. if the start address was just a random value and uaccess fails with
-EFAULT).

There are no reports of WARN_ONCE being issued for actual VM_IO cases, so
just drop it and instead add a note to the comment before the function.

Signed-off-by: Hans Verkuil 
Reviewed-by: David Hildenbrand 
Reported-by: Yikebaer Aizezi 
Signed-off-by: Sasha Levin

media: common: saa7146: Avoid a leak in vmalloc_to_sg()

2023-05-25T14:21:20+00:00

Commit in Fixes turned a BUG() into a "normal" memory allocation failure.
While at it, it introduced a memory leak.
So fix it.

Also update the comment on top of the function to reflect what has been
change by the commit in Fixes.

Fixes: 40e986c99624 ("media: common: saa7146: replace BUG_ON by WARN_ON")
Signed-off-by: Christophe JAILLET 
Signed-off-by: Hans Verkuil

media: common: saa7146: add support for missing .vidioc_try_fmt_vbi_cap

2023-04-15T07:55:16+00:00

Support for VIDIOC_TRY_FMT for the vbi device was missing.
Add it.

This fixes a V4L2 compliance issue.

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: common: saa7146: allow S_STD(G_STD)

2023-04-15T07:54:35+00:00

If the requested TV standard is identical to the current
TV standard, then return 0, even when the vb2 queues are
busy.

This fixes a V4L2 compliance issue.

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: common: saa7146: check minimum video format size

2023-04-15T07:54:09+00:00

There was no check for the minimum width and height, so
0 values were just passed on. Fix this.

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: common: saa7146: fix compliance problems with field handling

2023-04-15T07:53:53+00:00

The initial field value of the format is ANY, which isn't allowed.
Change to INTERLACED.

VIDIOC_TRY_FMT will overwrite vv->last_field, which is an
unwanted side-effect, so drop this.

And finally vidioc_s_fmt_vid_cap didn't initialize vv->last_field
correctly.

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: saa7146: convert to vb2

2023-04-15T07:53:31+00:00

Convert this driver from the old videobuf framework to the vb2
frame.

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: common: saa7146: use for_each_sg_dma_page

2023-04-15T07:52:32+00:00

When building the pgtables, use for_each_sg_dma_page.

Also clean up the code a bit.

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: common: saa7146: fix broken V4L2_PIX_FMT_YUV422P support

2023-04-15T07:52:06+00:00

The U and V components were swapped. Drop the FORMAT_BYTE_SWAP
to fix this.

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

media: common: saa7146: replace BUG_ON by WARN_ON

2023-04-15T07:51:21+00:00

No need for BUG_ON, WARN_ON is a lot friendlier.

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab