linux-stable.git/drivers/media/common, branch linux-3.10.y

media: siano: fix divide error on 0 counters

2013-09-27T00:18:27+00:00

commit ec532503209053bbee0c7dac410031e50835e01a upstream.

GIT_AUTHOR_DATE=1376465691
I took a quick look at the code and wonder if the problem is caused by
an initial zero statistics message?  This is all just a wild guess, but
if it is correct, then the attached untested patch might fix it...
Bjørn
>From d78a0599d5b5d4da384eae08bf7da316389dfbe5 Mon Sep 17 00:00:00 2001
ts_packets and ets_packets counters can be 0.  Don't fall over
if they are. Fixes:
[  846.851711] divide error: 0000 [#1] SMP
[  846.851806] Modules linked in: smsdvb dvb_core ir_lirc_codec lirc_dev ir_sanyo_decoder ir_mce_kbd_decoder ir_sony_decoder ir_jvc_decoder ir_rc6_decoder ir_rc5_decoder ir_nec_decoder rc_hauppauge smsusb smsmdtv rc_core pci_stub vboxpci(O) vboxnetadp(O) vboxnetflt(O) vboxdrv(O) parport_pc ppdev lp parport cpufreq_userspace cpufreq_powersave cpufreq_stats cpufreq_conservative rfcomm bnep binfmt_misc uinput nfsd auth_rpcgss oid_registry nfs_acl nfs lockd dns_resolver fscache sunrpc ext4 jbd2 fuse tp_smapi(O) thinkpad_ec(O) loop firewire_sbp2 dm_crypt snd_hda_codec_conexant snd_hda_intel snd_hda_codec snd_hwdep snd_pcm_oss snd_mixer_oss snd_pcm thinkpad_acpi nvram snd_page_alloc hid_generic snd_seq_midi snd_seq_midi_event arc4 usbhid snd_rawmidi uvcvideo hid iwldvm coretemp kvm_intel mac8021
 1 cdc_wdm
[  846.853477]  cdc_acm snd_seq videobuf2_vmalloc videobuf2_memops videobuf2_core videodev media kvm radeon r852 ttm joydev cdc_ether usbnet pcmcia mii sm_common nand btusb drm_kms_helper tpm_tis acpi_cpufreq bluetooth iwlwifi nand_ecc drm nand_ids i2c_i801 mtd snd_seq_device iTCO_wdt iTCO_vendor_support r592 memstick lpc_ich mperf tpm yenta_socket pcmcia_rsrc pcmcia_core cfg80211 snd_timer snd pcspkr i2c_algo_bit crc16 i2c_core tpm_bios processor mfd_core wmi psmouse mei_me rfkill mei serio_raw soundcore evdev battery button video ac microcode ext3 mbcache jbd md_mod dm_mirror dm_region_hash dm_log dm_mod sg sr_mod sd_mod cdrom crc_t10dif firewire_ohci sdhci_pci sdhci mmc_core firewire_core crc_itu_t thermal thermal_sys ahci libahci ehci_pci uhci_hcd ehci_hcd libata scsi_mod usbcore e1000
 e usb_common
[  846.855310]  ptp pps_core
[  846.855356] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G           O 3.10-2-amd64 #1 Debian 3.10.5-1
[  846.855490] Hardware name: LENOVO 4061WFA/4061WFA, BIOS 6FET92WW (3.22 ) 12/14/2011
[  846.855609] task: ffffffff81613400 ti: ffffffff81600000 task.ti: ffffffff81600000
[  846.855636] RIP: 0010:[]  [] smsdvb_onresponse+0x264/0xa86 [smsdvb]
[  846.863906] RSP: 0018:ffff88013bc03cf0  EFLAGS: 00010046
[  846.863906] RAX: 0000000000000000 RBX: ffff880133bf6000 RCX: 0000000000000000
[  846.863906] RDX: 0000000000000000 RSI: ffff88005d3b58c0 RDI: ffff880133bf6000
[  846.863906] RBP: ffff88005d1da000 R08: 0000000000000058 R09: 0000000000000015
[  846.863906] R10: 0000000000001a0d R11: 000000000000021a R12: ffff88005d3b58c0
[  846.863906] R13: ffff88005d1da008 R14: 00000000ffffff8d R15: ffff880036cf5060
[  846.863906] FS:  0000000000000000(0000) GS:ffff88013bc00000(0000) knlGS:0000000000000000
[  846.863906] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[  846.863906] CR2: 00007f3a4b69ae50 CR3: 0000000036dac000 CR4: 00000000000407f0
[  846.863906] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[  846.863906] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[  846.863906] Stack:
[  846.863906]  ffff88007a102000 ffff88005d1da000 ffff88005d3b58c0 0000000000085824
[  846.863906]  ffffffffa08c5aa3 ffff88005d1da000 ffff8800a6907390 ffff8800a69073b0
[  846.863906]  ffff8800a6907000 ffffffffa08b642c 000000000000021a ffff8800a69073b0
[  846.863906] Call Trace:
[  846.863906]  
[  846.863906]
[  846.863906]  [] ? smscore_onresponse+0x1d5/0x353 [smsmdtv]
[  846.863906]  [] ? smsusb_onresponse+0x146/0x192 [smsusb]
[  846.863906]  [] ? usb_hcd_giveback_urb+0x6c/0xac [usbcore]
[  846.863906]  [] ? ehci_urb_done+0x62/0x72 [ehci_hcd]
[  846.863906]  [] ? qh_completions+0x91/0x364 [ehci_hcd]
[  846.863906]  [] ? ehci_work+0x8a/0x68e [ehci_hcd]
[  846.863906]  [] ? timekeeping_get_ns.constprop.10+0xd/0x31
[  846.863906]  [] ? update_cfs_rq_blocked_load+0xde/0xec
[  846.863906]  [] ? run_posix_cpu_timers+0x25/0x575
[  846.863906]  [] ? ehci_irq+0x211/0x23d [ehci_hcd]
[  846.863906]  [] ? usb_hcd_irq+0x31/0x48 [usbcore]
[  846.863906]  [] ? handle_irq_event_percpu+0x49/0x1a4
[  846.863906]  [] ? handle_irq_event+0x32/0x4b
[  846.863906]  [] ? handle_fasteoi_irq+0x80/0xb6
[  846.863906]  [] ? handle_irq+0x18/0x20
[  846.863906]  [] ? do_IRQ+0x40/0x95
[  846.863906]  [] ? common_interrupt+0x6d/0x6d
[  846.863906]  
[  846.863906]
[  846.863906]  [] ? arch_local_irq_enable+0x4/0x8
[  846.863906]  [] ? cpuidle_enter_state+0x52/0xc1
[  846.863906]  [] ? cpuidle_idle_call+0xd4/0x143
[  846.863906]  [] ? arch_cpu_idle+0x5/0x17
[  846.863906]  [] ? cpu_startup_entry+0x10d/0x187
[  846.863906]  [] ? start_kernel+0x3e8/0x3f3
[  846.863906]  [] ? repair_env_string+0x54/0x54
[  846.863906]  [] ? x86_64_start_kernel+0xf2/0xfd
[  846.863906] Code: 25 09 00 00 c6 83 da 08 00 00 03 8b 45 54 48 01 83 b6 08 00 00 8b 45 50 48 01 83 db 08 00 00 8b 4d 18 69 c1 ff ff 00 00 03 4d 14 <48> f7 f1 89 83 a8 09 00 00 e9 68 fe ff ff 48 8b 7f 10 e8 79 92
[  846.863906] RIP  [] smsdvb_onresponse+0x264/0xa86 [smsdvb]
[  846.863906]  RSP 
Reference: http://bugs.debian.org/719623

Reported-by: Johannes Rohr 
Signed-off-by: Bjørn Mork 
Signed-off-by: Mauro Carvalho Chehab 
Signed-off-by: Greg Kroah-Hartman

[media] media: Fix randconfig error

2013-04-14T23:04:08+00:00

Fix randconfig error when USB is not enabled:
ERROR: "usb_control_msg" [drivers/media/common/cypress_firmware.ko] undefined!

Signed-off-by: Randy Dunlap 
Reviewed-by: Antti Palosaari 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

[media] cx88: kernel bz#9476: Fix tone setting for Nova-S+ model 92001

2013-04-08T09:56:47+00:00

Hauppauge Nova-S-Plus DVB-S model 92001 does not lock on horizontal
polarisation. According with the info provided at the BZ, model
92002 does.

The difference is that, on model 92001, the tone select is done via
isl6421, while, on other devices, this is done via cx24123 code.
This patch adds a way to override the demod's set_tone at isl6421
driver. In order to avoid regressions, the override is enabled
only for cx88 Nova S plus model 92001. For all other models and
devices, the set_tone is provided by the demod driver.

Patch originally proposed at bz@9476[1] by Michel Meyers and
John Donoghue but applying the original patch would break support
for all other devices based on isl6421.

[1] https://bugzilla.kernel.org/show_bug.cgi?id=9476

Tested-by: Adam Sampson 
Tested-by: Hans-Peter Jansen 
Signed-off-by: Mauro Carvalho Chehab

[media] siano: Fix array boundary at smscore_translate_msg()

2013-04-04T17:35:40+00:00

As reported by Dan Carpenter:
	FYI, there are new smatch warnings show up in

	tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next master
	head:   da17d7bda957ae4697b6abc0793f74fb9b50b58f
	commit: 4c3bdb5e2f5612ceb99ac17dbbe673b59a94d105 [media] siano: better debug send/receive messages

	drivers/media/common/siano/smscoreapi.c:396 smscore_translate_msg() error: buffer overflow 'siano_msgs' 401 <= 401

While it is almost impossible for this error to happen in
practice, as it would require the siano's firmware to return
an special invalid answer to a message request, fixing it
is trivial. So, let's do it.

Reported-by: Dan Carpenter 
Signed-off-by: Mauro Carvalho Chehab

[media] media: move dvb-usb-v2/cypress_firmware.c to media/common

2013-03-29T14:35:06+00:00

Loading the cypress firmware is not dvb specific and should be common
functionality. Move the source to media/common and make it a standalone
module.
As a result we can remove the dependency on dvb-usb in go7007, which has
nothing to do with dvb.

Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

[media] v4l2: pass std by value to the write-only s_std ioctl

2013-03-24T09:47:00+00:00

This ioctl is defined as IOW, so pass the argument by value instead of by
reference. I could have chosen to add const instead, but this is 1) easier
to handle in drivers and 2) consistent with the s_std subdev operation.

Signed-off-by: Hans Verkuil 
Acked-by: Laurent Pinchart 
Acked-by: Jonathan Corbet 
Acked-by: Guennadi Liakhovetski 
Acked-by: Lad, Prabhakar 
Signed-off-by: Mauro Carvalho Chehab

[media] siano: remove the ir protocol field

2013-03-22T12:46:46+00:00

This field is unused. Remove it.

Signed-off-by: Mauro Carvalho Chehab

[media] siano: use do_div() for 64-bits division

2013-03-22T12:46:31+00:00

As reported by Frank Schäfer :
	ERROR: "__divdi3" [drivers/media/common/siano/smsdvb.ko] undefined!

Reported-by: Frank Schäfer 
Tested-by: Gianluca Gennari 
Signed-off-by: Mauro Carvalho Chehab

[media] siano: make some functions static

2013-03-21T13:04:01+00:00

drivers/media/common/siano/smsdvb-debugfs.c:51:6: warning: no previous prototype for 'smsdvb_print_dvb_stats' [-Wmissing-prototypes]
drivers/media/common/siano/smsdvb-debugfs.c:154:6: warning: no previous prototype for 'smsdvb_print_isdb_stats' [-Wmissing-prototypes]
drivers/media/common/siano/smsdvb-debugfs.c:244:6: warning: no previous prototype for 'smsdvb_print_isdb_stats_ex' [-Wmissing-prototypes]
drivers/media/common/siano/smscoreapi.c:832:5: warning: no previous prototype for 'smscore_configure_board' [-Wmissing-prototypes]
drivers/media/common/siano/smscoreapi.c:1301:5: warning: no previous prototype for 'smscore_init_device' [-Wmissing-prototypes]

Signed-off-by: Mauro Carvalho Chehab

[media] siano: Fix the remaining checkpatch.pl compliants

2013-03-21T13:03:53+00:00

Fix all other remaining checkpatch.pl compliants on the Siano driver,
except for the 80-cols (soft) limit. Those are harder to fix, and
probably not worth to do right now.

Signed-off-by: Mauro Carvalho Chehab