linux-stable.git/drivers/md/raid10.h, branch linux-3.4.y

md/raid10: ensure device failure recorded before write request returns.

2016-04-27T10:55:21+00:00

commit 95af587e95aacb9cfda4a9641069a5244a540dc8 upstream.

When a write to one of the legs of a RAID10 fails, the failure is
recorded in the metadata of the other legs so that after a restart
the data on the failed drive wont be trusted even if that drive seems
to be working again (maybe a cable was unplugged).

Currently there is no interlock between the write request completing
and the metadata update.  So it is possible that the write will
complete, the app will confirm success in some way, and then the
machine will crash before the metadata update completes.

This is an extremely small hole for a racy to fit in, but it is
theoretically possible and so should be closed.

So:
 - set MD_CHANGE_PENDING when requesting a metadata update for a
   failed device, so we can know with certainty when it completes
 - queue requests that experienced an error on a new queue which
   is only processed after the metadata update completes
 - call raid_end_bio_io() on bios in that queue when the time comes.

Signed-off-by: NeilBrown 
[lizf: Backported to 3.4: adjust context]
Signed-off-by: Zefan Li

md/raid10: fix problem with on-stack allocation of r10bio structure.

2012-10-02T17:30:33+00:00

commit e0ee778528bbaad28a5c69d2e219269a3a096607 upstream.

A 'struct r10bio' has an array of per-copy information at the end.
This array is declared with size [0] and r10bio_pool_alloc allocates
enough extra space to store the per-copy information depending on the
number of copies needed.

So declaring a 'struct r10bio on the stack isn't going to work.  It
won't allocate enough space, and memory corruption will ensue.

So in the two places where this is done, declare a sufficiently large
structure and use that instead.

The two call-sites of this bug were introduced in 3.4 and 3.5
so this is suitable for both those kernels.  The patch will have to
be modified for 3.4 as it only has one bug.

Reported-by: Ivan Vasilyev 
Tested-by: Ivan Vasilyev 
Signed-off-by: NeilBrown 
Signed-off-by: Greg Kroah-Hartman

md/raid10: prepare data structures for handling replacement.

2011-12-22T23:17:54+00:00

Allow each slot in the RAID10 to have 2 devices, the want_replacement
and the replacement.

Also an r10bio to have 2 bios, and for resync/recovery allocate the
second bio if there are any replacement devices.

Signed-off-by: NeilBrown

md: add proper write-congestion reporting to RAID1 and RAID10.

2011-10-11T05:50:01+00:00

RAID1 and RAID10 handle write requests by queuing them for handling by
a separate thread.  This is because when a write-intent-bitmap is
active we might need to update the bitmap first, so it is good to
queue a lot of writes, then do one big bitmap update for them all.

However writeback request devices to appear to be congested after a
while so it can make some guesstimate of throughput.  The infinite
queue defeats that (note that RAID5 has already has a finite queue so
it doesn't suffer from this problem).

So impose a limit on the number of pending write requests.  By default
it is 1024 which seems to be generally suitable.  Make it configurable
via module option just in case someone finds a regression.

Signed-off-by: NeilBrown

md/raid10: typedef removal: conf_t -> struct r10conf

2011-10-11T05:49:02+00:00

Signed-off-by: NeilBrown

md: remove typedefs: mirror_info_t -> struct mirror_info

2011-10-11T05:48:46+00:00

Signed-off-by: NeilBrown

md: remove typedefs: r10bio_t -> struct r10bio and r1bio_t -> struct r1bio

2011-10-11T05:48:43+00:00

Signed-off-by: NeilBrown

md: remove typedefs: mdk_thread_t -> struct md_thread

2011-10-11T05:48:23+00:00

Signed-off-by: NeilBrown

md: remove typedefs: mddev_t -> struct mddev

2011-10-11T05:47:53+00:00

Having mddev_t and 'struct mddev_s' is ugly and not preferred

Signed-off-by: NeilBrown

md: removing typedefs: mdk_rdev_t -> struct md_rdev

2011-10-11T05:45:26+00:00

The typedefs are just annoying. 'mdk' probably refers to 'md_k.h'
which used to be an include file that defined this thing.

Signed-off-by: NeilBrown