linux-stable.git/drivers/md/linear.c, branch linux-2.6.26.y

linear: correct disk numbering error check

2008-08-06T16:03:14+00:00

[ Upstream commit 13864515f7bf6cabd60e63c62e09d311386ae1f1 ]

From: "Nikanth Karthikesan" 

Correct disk numbering problem check.

Signed-off-by: Nikanth Karthikesan 
Signed-off-by: Neil Brown 
CC: Oliver Pinter 
Signed-off-by: Greg Kroah-Hartman

Remove blkdev warning triggered by using md

2008-05-15T02:11:15+00:00

As setting and clearing queue flags now requires that we hold a spinlock
on the queue, and as blk_queue_stack_limits is called without that lock,
get the lock inside blk_queue_stack_limits.

For blk_queue_stack_limits to be able to find the right lock, each md
personality needs to set q->queue_lock to point to the appropriate lock.
Those personalities which didn't previously use a spin_lock, us
q->__queue_lock.  So always initialise that lock when allocated.

With this in place, setting/clearing of the QUEUE_FLAG_PLUGGED bit will no
longer cause warnings as it will be clear that the proper lock is held.

Thanks to Dan Williams for review and fixing the silly bugs.

Signed-off-by: NeilBrown 
Cc: Dan Williams 
Cc: Jens Axboe 
Cc: Alistair John Strachan 
Cc: Nick Piggin 
Cc: "Rafael J. Wysocki" 
Cc: Jacek Luczak 
Cc: Prakash Punnoor 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

md: change ITERATE_RDEV to rdev_for_each

2008-02-06T18:41:19+00:00

As this is more in line with common practice in the kernel.  Also swap the
args around to be more like list_for_each.

Signed-off-by: Neil Brown 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Add UNPLUG traces to all appropriate places

2007-11-09T12:41:32+00:00

Added blk_unplug interface, allowing all invocations of unplugs to result
in a generated blktrace UNPLUG.

Signed-off-by: Alan D. Brunelle 
Signed-off-by: Jens Axboe

block: convert blkdev_issue_flush() to use empty barriers

2007-10-16T09:05:02+00:00

Then we can get rid of ->issue_flush_fn() and all the driver private
implementations of that.

Signed-off-by: Jens Axboe

Drop 'size' argument from bio_endio and bi_end_io

2007-10-10T07:25:57+00:00

As bi_end_io is only called once when the reqeust is complete,
the 'size' argument is now redundant.  Remove it.

Now there is no need for bio_endio to subtract the size completed
from bi_size.  So don't do that either.

While we are at it, change bi_end_io to return void.

Signed-off-by: Neil Brown 
Signed-off-by: Jens Axboe

[BLOCK] Get rid of request_queue_t typedef

2007-07-24T07:28:11+00:00

Some of the code has been gradually transitioned to using the proper
struct request_queue, but there's lots left. So do a full sweet of
the kernel and get rid of this typedef and replace its uses with
the proper type.

Signed-off-by: Jens Axboe

md: fix bug with linear hot-add and elsewhere

2007-05-24T03:14:14+00:00

Adding a drive to a linear array seems to have stopped working, due to changes
elsewhere in md, and insufficient ongoing testing...

So the patch to make linear hot-add work in the first place introduced a
subtle bug elsewhere that interracts poorly with older version of mdadm.

This fixes it all up.

Signed-off-by: Neil Brown 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] fix read past end of array in md/linear.c

2007-03-17T02:25:03+00:00

When iterating through an array, one must be careful to test one's index
variable rather than another similarly-named variable.

The loop will read off the end of conf->disks[] in the following
(pathological) case:

  % dd bs=1 seek=840716287 if=/dev/zero of=d1 count=1
  % for i in 2 3 4; do dd if=/dev/zero of=d$i bs=1k count=$(($i+150)); done
  % ./vmlinux ubd0=root ubd1=d1 ubd2=d2 ubd3=d3 ubd4=d4
  # mdadm -C /dev/md0 --level=linear --raid-devices=4 /dev/ubd[1234]

adding some printks, I saw this:

  [42949374.960000] hash_spacing = 821120
  [42949374.960000] cnt          = 4
  [42949374.960000] min_spacing  = 801
  [42949374.960000] j=0 size=820928 sz=820928
  [42949374.960000] i=0 sz=820928 hash_spacing=820928
  [42949374.960000] j=1 size=64 sz=64
  [42949374.960000] j=2 size=64 sz=128
  [42949374.960000] j=3 size=64 sz=192
  [42949374.960000] j=4 size=1515870810 sz=1515871002

Cc: Gautham R Shenoy 
Acked-by: Neil Brown 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] md: define backing_dev_info.congested_fn for raid0 and linear

2006-10-03T15:04:18+00:00

Each backing_dev needs to be able to report whether it is congested, either by
modulating BDI_*_congested in ->state, or by defining a ->congested_fn.
md/raid did neither of these.  This patch add a congested_fn which simply
checks all component devices to see if they are congested.

Signed-off-by: Neil Brown 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds