linux-stable.git/drivers/md/dm-writecache.c, branch v5.13.2

dm writecache: fix flexible_array.cocci warnings

2021-03-26T18:53:41+00:00

Zero-length and one-element arrays are deprecated, see
Documentation/process/deprecated.rst
Flexible-array members should be used instead.

Generated by: scripts/coccinelle/misc/flexible_array.cocci

CC: Denis Efremov 
Reported-by: kernel test robot 
Signed-off-by: kernel test robot 
Signed-off-by: Julia Lawall 
Signed-off-by: Mike Snitzer

block: rename BIO_MAX_PAGES to BIO_MAX_VECS

2021-03-11T14:47:48+00:00

Ever since the addition of multipage bio_vecs BIO_MAX_PAGES has been
horribly confusingly misnamed.  Rename it to BIO_MAX_VECS to stop
confusing users of the bio API.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Matthew Wilcox (Oracle) 
Reviewed-by: Martin K. Petersen 
Link: https://lore.kernel.org/r/20210311110137.1132391-2-hch@lst.de
Signed-off-by: Jens Axboe

dm writecache: use bdev_nr_sectors() instead of open-coded equivalent

2021-02-09T22:09:02+00:00

Signed-off-by: Mike Snitzer

dm writecache: fix writing beyond end of underlying device when shrinking

2021-02-09T22:09:02+00:00

Do not attempt to write any data beyond the end of the underlying data
device while shrinking it.

The DM writecache device must be suspended when the underlying data
device is shrunk.

Signed-off-by: Mikulas Patocka 
Cc: stable@vger.kernel.org
Signed-off-by: Mike Snitzer

dm writecache: return the exact table values that were set

2021-02-08T16:32:54+00:00

LVM doesn't like it when the target returns different values from what
was set in the constructor. Fix dm-writecache so that the returned
table values are exactly the same as requested values.

Signed-off-by: Mikulas Patocka 
Cc: stable@vger.kernel.org # v4.18+
Signed-off-by: Mike Snitzer

dm writecache: fix unnecessary NULL check warnings

2021-02-03T15:10:05+00:00

Remove NULL checks before vfree() to fix these warnings:
./drivers/md/dm-writecache.c:2008:2-7: WARNING: NULL check before some
freeing functions is not needed.
./drivers/md/dm-writecache.c:2024:2-7: WARNING: NULL check before some
freeing functions is not needed.

Signed-off-by: Tian Tao 
Signed-off-by: Mike Snitzer

dm writecache: fix performance degradation in ssd mode

2021-02-03T15:10:05+00:00

Fix a thinko in ssd_commit_superblock. region.count is in sectors, not
bytes. This bug doesn't corrupt data, but it causes performance
degradation.

Signed-off-by: Mikulas Patocka 
Fixes: dc8a01ae1dbd ("dm writecache: optimize superblock write")
Cc: stable@vger.kernel.org # v5.7+
Reported-by: J. Bruce Fields 
Signed-off-by: Mike Snitzer

dm writecache: remove BUG() and fail gracefully instead

2020-12-01T20:43:39+00:00

Building on arch/s390/ results in this build error:

cc1: some warnings being treated as errors
../drivers/md/dm-writecache.c: In function 'persistent_memory_claim':
../drivers/md/dm-writecache.c:323:1: error: no return statement in function returning non-void [-Werror=return-type]

Fix this by replacing the BUG() with an -EOPNOTSUPP return.

Fixes: 48debafe4f2f ("dm: add writecache target")
Reported-by: Randy Dunlap 
Signed-off-by: Mike Snitzer

dm writecache: fix the maximum number of arguments

2020-11-17T15:45:06+00:00

Advance the maximum number of arguments to 16.
This fixes issue where certain operations, combined with table
configured args, exceed 10 arguments.

Signed-off-by: Mikulas Patocka 
Fixes: 48debafe4f2f ("dm: add writecache target")
Cc: stable@vger.kernel.org # v4.18+
Signed-off-by: Mike Snitzer

dm writecache: advance the number of arguments when reporting max_age

2020-11-17T15:45:06+00:00

When reporting the "max_age" value the number of arguments must
advance by two.

Signed-off-by: Mikulas Patocka 
Fixes: 3923d4854e18 ("dm writecache: implement gradual cleanup")
Cc: stable@vger.kernel.org # v5.7+
Signed-off-by: Mike Snitzer