linux-stable.git/drivers/md/dm-raid.c, branch v4.8

dm raid: support raid0 with missing metadata devices

2016-08-17T14:42:39+00:00

The raid0 MD personality does not start a raid0 array with any of its
data devices missing.

dm-raid was removing data/metadata device pairs unconditionally if it
failed to read a superblock off the respective metadata device of such
pair, resulting in failure to start arrays with the raid0 personality.

Avoid removing any data/metadata device pairs in case of raid0
(e.g. lvm2 segment type 'raid0_meta') thus allowing MD to start the
array.

Also, avoid region size validation for raid0.

Signed-off-by: Heinz Mauelshagen 
Signed-off-by: Mike Snitzer

dm raid: enhance attempt_restore_of_faulty_devices() to support more devices

2016-08-16T20:22:24+00:00

attempt_restore_of_faulty_devices() is limited to 64 when it should support
the new maximum of 253 when identifying any failed devices. It clears any
revivable devices via an MD personality hot remove and add cylce to allow
for their recovery.

Address by using existing functions to retrieve and update all failed
devices' bitfield members in the dm raid superblocks on all RAID devices
and check for any devices to clear in it.

Whilst on it, don't call attempt_restore_of_faulty_devices() for any MD
personality not providing disk hot add/remove methods (i.e. raid0 now),
because such personalities don't support reviving of failed disks.

Signed-off-by: Heinz Mauelshagen 
Signed-off-by: Mike Snitzer

dm raid: fix restoring of failed devices regression

2016-08-16T20:21:31+00:00

'lvchange --refresh RaidLV' causes a mapped device suspend/resume cycle
aiming at device restore and resync after transient device failures.  This
failed because flag RT_FLAG_RS_RESUMED was always cleared in the suspend path,
thus the device restore wasn't performed in the resume path.

Solve by removing RT_FLAG_RS_RESUMED from the suspend path and resume
unconditionally.  Also, remove superfluous comment from raid_resume().

Signed-off-by: Heinz Mauelshagen 
Signed-off-by: Mike Snitzer

dm raid: fix frozen recovery regression

2016-08-16T20:18:19+00:00

On LVM2 conversions via lvconvert(8), the target keeps mapped devices in
frozen state when requesting RAID devices be resynchronized.  This
applies to e.g. adding legs to a raid1 device or taking over from raid0
to raid4 when the rebuild flag's set on the new raid1 legs or the added
dedicated parity stripe.

Also, fix frozen recovery for reshaping as well.

Signed-off-by: Heinz Mauelshagen 
Signed-off-by: Mike Snitzer

dm raid: fix use of wrong status char during resynchronization

2016-08-04T14:05:30+00:00

During a resynchronization, device status char 'a' is output on the raid
status line for every device of a RAID set.  It changes from 'a' to 'A'
(unless device failure) when the resynchronization completes.

Interrupting and restarting a resynchronization, by reloading the DM
table, erroneously lead to status char 'A'.

Fix this by avoiding setting the MD_RECOVERY_REQUESTED flag in
raid_preresume().

Signed-off-by: Heinz Mauelshagen 
Signed-off-by: Mike Snitzer

dm raid: constructor fails on non-zero incompat_features

2016-08-03T16:36:54+00:00

When lvm2 userspace requests a RaidLV repair, it sets the rebuild
constructor flag on the new replacement DataLVs but does not clear the
respective MetaLVs.  Hence the superblock that is loaded from such new
MetaLVs may have a non-zero incompat_features member and the constructor
will fail with false-positive on incompat_features.

Solve by initializing the incompat_features member properly.

Signed-off-by: Heinz Mauelshagen 
Signed-off-by: Mike Snitzer

dm raid: fix processing of max_recovery_rate constructor flag

2016-08-03T14:30:52+00:00

__CTR_FLAG_MIN_RECOVERY_RATE was used instead of __CTR_FLAG_MAX_RECOVERY_RATE
thus causing max_recovery_rate to be rejected in case min_recovery_rate
was already set.

Signed-off-by: Heinz Mauelshagen 
Signed-off-by: Mike Snitzer

dm raid: fix random optimal_io_size for raid0

2016-07-19T15:37:08+00:00

raid_io_hints() was retrieving the number of data stripes used for the
calculation of io_opt from struct r5conf, which is not defined for raid0
mappings.

Base the calculation on the in-core raid_set structure instead.

Also, adjust to use to_bytes() for the sector -> bytes conversion
throughout.

Signed-off-by: Heinz Mauelshagen 
Signed-off-by: Mike Snitzer

dm raid: address checkpatch.pl complaints

2016-07-19T15:37:07+00:00

Use 'unsigned int' where appropriate.
Return negative errors.
Correct an indentation.

Signed-off-by: Heinz Mauelshagen 
Signed-off-by: Mike Snitzer

dm raid: change logical functions to actually return bool

2016-07-18T19:37:33+00:00

Signed-off-by: Heinz Mauelshagen 
Signed-off-by: Mike Snitzer