linux-stable.git/drivers/md/dm-raid.c, branch linux-6.4.y

dm raid: protect md_stop() with 'reconfig_mutex'

2023-08-03T08:25:58+00:00

[ Upstream commit 7d5fff8982a2199d49ec067818af7d84d4f95ca0 ]

__md_stop_writes() and __md_stop() will modify many fields that are
protected by 'reconfig_mutex', and all the callers will grab
'reconfig_mutex' except for md_stop().

Also, update md_stop() to make certain 'reconfig_mutex' is held using
lockdep_assert_held().

Fixes: 9d09e663d550 ("dm: raid456 basic support")
Signed-off-by: Yu Kuai 
Signed-off-by: Mike Snitzer 
Signed-off-by: Sasha Levin

dm raid: clean up four equivalent goto tags in raid_ctr()

2023-08-03T08:25:58+00:00

[ Upstream commit e74c874eabe2e9173a8fbdad616cd89c70eb8ffd ]

There are four equivalent goto tags in raid_ctr(), clean them up to
use just one.

There is no functional change and this is preparation to fix
raid_ctr()'s unprotected md_stop().

Signed-off-by: Yu Kuai 
Signed-off-by: Mike Snitzer 
Stable-dep-of: 7d5fff8982a2 ("dm raid: protect md_stop() with 'reconfig_mutex'")
Signed-off-by: Sasha Levin

dm raid: fix missing reconfig_mutex unlock in raid_ctr() error paths

2023-08-03T08:25:58+00:00

[ Upstream commit bae3028799dc4f1109acc4df37c8ff06f2d8f1a0 ]

In the error paths 'bad_stripe_cache' and 'bad_check_reshape',
'reconfig_mutex' is still held after raid_ctr() returns.

Fixes: 9dbd1aa3a81c ("dm raid: add reshaping support to the target")
Signed-off-by: Yu Kuai 
Signed-off-by: Mike Snitzer 
Signed-off-by: Sasha Levin

dm: add helper macro for simple DM target module init and exit

2023-04-11T16:09:08+00:00

Eliminate duplicate boilerplate code for simple modules that contain
a single DM target driver without any additional setup code.

Add a new module_dm() macro, which replaces the module_init() and
module_exit() with template functions that call dm_register_target()
and dm_unregister_target() respectively.

Signed-off-by: Yangtao Li 
Signed-off-by: Mike Snitzer

dm raid: remove unused d variable

2023-04-11T16:01:01+00:00

clang with W=1 reports
drivers/md/dm-raid.c:2212:15: error: variable
  'd' set but not used [-Werror,-Wunused-but-set-variable]
        unsigned int d;
                     ^
This variable is not used so remove it.

Signed-off-by: Tom Rix 
Signed-off-by: Mike Snitzer

dm: fix suspect indent whitespace

2023-02-14T19:23:07+00:00

Signed-off-by: Heinz Mauelshagen 
Signed-off-by: Mike Snitzer

dm: add missing blank line after declarations/fix those

2023-02-14T19:23:07+00:00

Signed-off-by: Heinz Mauelshagen 
Signed-off-by: Mike Snitzer

dm: correct block comments format.

2023-02-14T19:23:06+00:00

Signed-off-by: Heinz Mauelshagen 
Signed-off-by: Mike Snitzer

dm: address indent/space issues

2023-02-14T19:23:06+00:00

Signed-off-by: Heinz Mauelshagen 
Signed-off-by: Mike Snitzer

dm: avoid initializing static variables

2023-02-14T19:23:06+00:00

Signed-off-by: Heinz Mauelshagen 
Signed-off-by: Mike Snitzer