linux-stable.git/drivers/mcb, branch linux-4.9.y

mcb: mcb-parse: fix error handing in chameleon_parse_gdd()

2023-01-07T11:07:26+00:00

[ Upstream commit 728ac3389296caf68638628c987aeae6c8851e2d ]

If mcb_device_register() returns error in chameleon_parse_gdd(), the refcount
of bus and device name are leaked. Fix this by calling put_device() to give up
the reference, so they can be released in mcb_release_dev() and kobject_cleanup().

Fixes: 3764e82e5150 ("drivers: Introduce MEN Chameleon Bus")
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Yang Yingliang 
Signed-off-by: Johannes Thumshirn 
Link: https://lore.kernel.org/r/ebfb06e39b19272f0197fa9136b5e4b6f34ad732.1669624063.git.johannes.thumshirn@wdc.com
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Sasha Levin

drivers: mcb: fix resource leak in mcb_probe()

2023-01-07T11:07:26+00:00

[ Upstream commit d7237462561fcd224fa687c56ccb68629f50fc0d ]

When probe hook function failed in mcb_probe(), it doesn't put the device.
Compiled test only.

Fixes: 7bc364097a89 ("mcb: Acquire reference to device in probe")
Signed-off-by: Zhengchao Shao 
Signed-off-by: Johannes Thumshirn 
Link: https://lore.kernel.org/r/9f87de36bfb85158b506cb78c6fc9db3f6a3bad1.1669624063.git.johannes.thumshirn@wdc.com
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Sasha Levin

mcb: fix error handling in mcb_alloc_bus()

2021-10-06T08:23:39+00:00

commit 25a1433216489de4abc889910f744e952cb6dbae upstream.

There are two bugs:
1) If ida_simple_get() fails then this code calls put_device(carrier)
   but we haven't yet called get_device(carrier) and probably that
   leads to a use after free.
2) After device_initialize() then we need to use put_device() to
   release the bus.  This will free the internal resources tied to the
   device and call mcb_free_bus() which will free the rest.

Fixes: 5d9e2ab9fea4 ("mcb: Implement bus->dev.release callback")
Fixes: 18d288198099 ("mcb: Correctly initialize the bus's device")
Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter 
Signed-off-by: Johannes Thumshirn 
Link: https://lore.kernel.org/r/32e160cf6864ce77f9d62948338e24db9fd8ead9.1630931319.git.johannes.thumshirn@wdc.com
Signed-off-by: Greg Kroah-Hartman

MCB: add support for SC31 to mcb-lpc

2017-09-09T15:39:41+00:00

commit acf5e051ac44d5dc60b21bc4734ef1b844d55551 upstream.

This patch adds the resources and DMI ID's for the MEN SC31,
which uses a different address region to map the LPC bus than
the one used for the existing SC24.

Signed-off-by: Michael Moese 
[jth add stable tag]
Signed-off-by: Johannes Thumshirn 
Signed-off-by: Greg Kroah-Hartman

mcb: Add a dma_device to mcb_device

2016-09-27T10:33:47+00:00

When performing DMA operations on a MCB device, the device needed
for using the DMA API is "mcb_device->bus_carrier".
This is rather lengthy, so a shortcut is introduced to struct mcb_device
in order to ensure the MCB device driver uses the correct device for DMA
operations.

Signed-off-by: Michael Moese 
Signed-off-by: Johannes Thumshirn 
Signed-off-by: Greg Kroah-Hartman

mcb: Enable PCI bus mastering by default

2016-09-27T10:33:47+00:00

In order to successfully perform DMA operations on PCI devices,
it is necessary to enble PCI bus mastering, so enable it by default.

Signed-off-by: Michael Moese 
Signed-off-by: Johannes Thumshirn 
Signed-off-by: Greg Kroah-Hartman

mcb: remove sub-device handling code

2016-08-31T11:16:24+00:00

The MEN Chameleon specification states that a chameleon FPGA can include a
bridge descriptor, which then opens up a new bus behind this bridge. MCB
included subdevice handling code in the core, but no support for bus
descriptors in the parser, due to a lack of hardware access.

As this is technically dead code, but it gets executed on a device add,
I've decided to remove it.

Signed-off-by: Johannes Thumshirn 
Signed-off-by: Greg Kroah-Hartman

mcb: Added bar descriptor support for non PCI bus MCB carrier

2016-08-31T11:16:24+00:00

Added support for the bar descriptor. This type is used for FPGAs
connect to the LPC or to a non PCI bus.

The Bar descriptor could have a maximum of 6 BARs. Each of the
devices within the FPGA could be mapped to a different BAR.
The BAR descriptor is comparable to the PCI header.

Signed-off-by: Andreas Werner 
[ free bar descriptor in the non-error case ]
Signed-off-by: Johannes Thumshirn 
Signed-off-by: Greg Kroah-Hartman

mcb: Added support for LPC or non PCI based MCB carrier

2016-08-31T11:16:24+00:00

Add support for MCB bases FPGAs connected to the LPC or
non PCI Bus.

This driver currently supports the SC24 board. The FPGA
is connected to the LPC bus and is identified using the BIOS
DMI string.

Signed-off-by: Andreas Werner 
Signed-off-by: Johannes Thumshirn 
Signed-off-by: Greg Kroah-Hartman

mcb: Acquire reference to carrier module in core

2016-06-14T01:49:30+00:00

Acquire a reference to the carrier's kernel module in bus code, so
it can't be removed from the kernel while it still has a bus and thus
possibly devices attached to it.

Signed-off-by: Johannes Thumshirn 
Reported-by: Andreas Werner 
Tested-by: Andreas Werner 
Signed-off-by: Greg Kroah-Hartman