linux-stable.git/drivers/mcb/mcb-parse.c, branch linux-6.3.y

mcb: mcb-parse: fix error handing in chameleon_parse_gdd()

2022-12-02T16:48:04+00:00

If mcb_device_register() returns error in chameleon_parse_gdd(), the refcount
of bus and device name are leaked. Fix this by calling put_device() to give up
the reference, so they can be released in mcb_release_dev() and kobject_cleanup().

Fixes: 3764e82e5150 ("drivers: Introduce MEN Chameleon Bus")
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Yang Yingliang 
Signed-off-by: Johannes Thumshirn 
Link: https://lore.kernel.org/r/ebfb06e39b19272f0197fa9136b5e4b6f34ad732.1669624063.git.johannes.thumshirn@wdc.com
Signed-off-by: Greg Kroah-Hartman

drivers: mcb: use symbol namespaces

2019-11-03T18:54:53+00:00

Now that we have symbol namespaces, use them in MCB to not pollute the
default namespace with MCB internals.

Signed-off-by: Johannes Thumshirn 
Reviewed-by: Jessica Yu 
Reviewed-by: Michael Moese 
Link: https://lore.kernel.org/r/20191016100158.1400-1-jthumshirn@suse.de
Signed-off-by: Greg Kroah-Hartman

treewide: Add SPDX license identifier for missed files

2019-05-21T08:50:45+00:00

Add SPDX license identifiers to all files which:

 - Have no license information of any form

 - Have EXPORT_.*_SYMBOL_GPL inside which was used in the
   initial scan/conversion to ignore the file

These files fall under the project license, GPL v2 only. The resulting SPDX
license identifier is:

  GPL-2.0-only

Signed-off-by: Thomas Gleixner 
Signed-off-by: Greg Kroah-Hartman

mcb: Fix an error handling path in 'chameleon_parse_cells()'

2017-08-31T16:49:41+00:00

If 'chameleon_get_bar()' fails, we will return 0, which mean success.
We should return the corresponding error code instead.

Remove the useless initialisation of 'ret' which was hiding the issue.
(if 'ret' is not set, gcc generates a warning ("warning: ‘ret’ may be used
uninitialized in this function"))

Signed-off-by: Christophe JAILLET 
Signed-off-by: Johannes Thumshirn 
Signed-off-by: Greg Kroah-Hartman

mcb: fix compiler warning logical-op in mcb-parse.c

2016-11-15T09:52:37+00:00

The expression was clearly wrong, the logical AND of expressions
must be changed to a logical OR.

Reported-by: David Binderman 
Signed-off-by: Michael Moese 
Signed-off-by: Johannes Thumshirn 
Signed-off-by: Greg Kroah-Hartman

mcb: Added bar descriptor support for non PCI bus MCB carrier

2016-08-31T11:16:24+00:00

Added support for the bar descriptor. This type is used for FPGAs
connect to the LPC or to a non PCI bus.

The Bar descriptor could have a maximum of 6 BARs. Each of the
devices within the FPGA could be mapped to a different BAR.
The BAR descriptor is comparable to the PCI header.

Signed-off-by: Andreas Werner 
[ free bar descriptor in the non-error case ]
Signed-off-by: Johannes Thumshirn 
Signed-off-by: Greg Kroah-Hartman

mcb: Fixed bar number assignment for the gdd

2016-05-03T22:52:28+00:00

The bar number is found in reg2 within the gdd. Therefore
we need to change the assigment from reg1 to reg2 which
is the correct location.

Signed-off-by: Andreas Werner 
Fixes: '3764e82e5' drivers: Introduce MEN Chameleon Bus
Cc: stable@vger.kernel.org # v3.15+
Signed-off-by: Johannes Thumshirn 
Signed-off-by: Greg Kroah-Hartman

mcb: export bus information via sysfs

2016-05-03T22:07:35+00:00

Export information about the bus stored in the FPGA's header to userspace via
sysfs, instead of hiding it in pr_debug()s from everyone.

Signed-off-by: Johannes Thumshirn 
Reviewed-by: Andreas Werner 
Tested-by: Andreas Werner 
Signed-off-by: Greg Kroah-Hartman

drivers: mcb: fix memory leak in chameleon_parse_cells() error path

2014-04-16T19:28:47+00:00

chameleon_parse_cells() bails out if chameleon descriptor type is
invalid but does not free the storage 'header' points to.

Signed-off-by: Christoph Jaeger 
Signed-off-by: Johannes Thumshirn 
Signed-off-by: Greg Kroah-Hartman

drivers: Introduce MEN Chameleon Bus

2014-02-28T23:36:37+00:00

The MCB (MEN Chameleon Bus) is a Bus specific to MEN Mikroelektronik
FPGA based devices. It is used to identify MCB based IP-Cores within
an FPGA and provide the necessary framework for instantiating drivers
for these devices.

Signed-off-by: Johannes Thumshirn 
Signed-off-by: Greg Kroah-Hartman