linux-stable.git/drivers/mailbox, branch v4.1.45 Linux kernel stable tree mailbox: handle empty message in tx_tick 2017-09-10T20:35:49+00:00 Sudeep Holla sudeep.holla@arm.com 2017-03-21T11:30:16+00:00 98b946e27788df95847b0bdf88595a63f4de5a1d [ Upstream commit cb710ab1d8a23f68ff8f45aedf3e552bb90e70de ] We already check if the message is empty before calling the client tx_done callback. Calling completion on a wait event is also invalid if the message is empty. This patch moves the existing empty message check earlier. Fixes: 2b6d83e2b8b7 ("mailbox: Introduce framework for mailbox") Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> 
[ Upstream commit cb710ab1d8a23f68ff8f45aedf3e552bb90e70de ]

We already check if the message is empty before calling the client
tx_done callback. Calling completion on a wait event is also invalid
if the message is empty.

This patch moves the existing empty message check earlier.

Fixes: 2b6d83e2b8b7 ("mailbox: Introduce framework for mailbox")
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
mailbox: skip complete wait event if timer expired 2017-09-10T20:35:49+00:00 Sudeep Holla sudeep.holla@arm.com 2017-03-21T11:30:15+00:00 4dba76fe6a694b95f937e9be1717335de48650c3 [ Upstream commit cc6eeaa3029a6dbcb4ad41b1f92876483bd88965 ] If a wait_for_completion_timeout() call returns due to a timeout, complete() can get called after returning from the wait which is incorrect and can cause subsequent transmissions on a channel to fail. Since the wait_for_completion_timeout() sees the completion variable is non-zero caused by the erroneous/spurious complete() call, and it immediately returns without waiting for the time as expected by the client. This patch fixes the issue by skipping complete() call for the timer expiry. Fixes: 2b6d83e2b8b7 ("mailbox: Introduce framework for mailbox") Reported-by: Alexey Klimov <alexey.klimov@arm.com> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> 
[ Upstream commit cc6eeaa3029a6dbcb4ad41b1f92876483bd88965 ]

If a wait_for_completion_timeout() call returns due to a timeout,
complete() can get called after returning from the wait which is
incorrect and can cause subsequent transmissions on a channel to fail.
Since the wait_for_completion_timeout() sees the completion variable
is non-zero caused by the erroneous/spurious complete() call, and
it immediately returns without waiting for the time as expected by the
client.

This patch fixes the issue by skipping complete() call for the timer
expiry.

Fixes: 2b6d83e2b8b7 ("mailbox: Introduce framework for mailbox")
Reported-by: Alexey Klimov <alexey.klimov@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
mailbox: always wait in mbox_send_message for blocking Tx mode 2017-09-10T20:35:49+00:00 Sudeep Holla sudeep.holla@arm.com 2017-03-21T11:30:14+00:00 c7d4b67dc3c8bdce8ba7d4037b7cf41dc478cb72 [ Upstream commit c61b781ee084e69855477d23dd33e7e6caad652c ] There exists a race when msg_submit return immediately as there was an active request being processed which may have completed just before it's checked again in mbox_send_message. This will result in return to the caller without waiting in mbox_send_message even when it's blocking Tx. This patch fixes the issue by waiting for the completion always if Tx is in blocking mode. Fixes: 2b6d83e2b8b7 ("mailbox: Introduce framework for mailbox") Reported-by: Alexey Klimov <alexey.klimov@arm.com> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> Reviewed-by: Alexey Klimov <alexey.klimov@arm.com> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> 
[ Upstream commit c61b781ee084e69855477d23dd33e7e6caad652c ]

There exists a race when msg_submit return immediately as there was an
active request being processed which may have completed just before it's
checked again in mbox_send_message. This will result in return to the
caller without waiting in mbox_send_message even when it's blocking Tx.

This patch fixes the issue by waiting for the completion always if Tx
is in blocking mode.

Fixes: 2b6d83e2b8b7 ("mailbox: Introduce framework for mailbox")
Reported-by: Alexey Klimov <alexey.klimov@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Reviewed-by: Alexey Klimov <alexey.klimov@arm.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
mailbox: arm_mhu: add driver for ARM MHU controller 2015-03-17T05:42:01+00:00 Jassi Brar jaswinder.singh@linaro.org 2014-06-26T13:39:42+00:00 ee23d66af9219dfe2407a9b08ef9a165dbe6f994 Add driver for the ARM Primecell Message-Handling-Unit(MHU) controller. Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org> Signed-off-by: Andy Green <andy.green@linaro.org> Signed-off-by: Vincent Yang <vincent.yang@socionext.com> Signed-off-by: Tetsuya Nuriya <nuriya.tetsuya@socionext.com> 
Add driver for the ARM Primecell Message-Handling-Unit(MHU) controller.

Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
Signed-off-by: Andy Green <andy.green@linaro.org>
Signed-off-by: Vincent Yang <vincent.yang@socionext.com>
Signed-off-by: Tetsuya Nuriya <nuriya.tetsuya@socionext.com>
Mailbox: Restructure and simplify PCC mailbox code 2015-03-04T15:34:22+00:00 Ashwin Chaugule ashwin.chaugule@linaro.org 2015-01-27T21:03:57+00:00 33350e6b1833b15cf9c9c4c84d8534ad68b0c7b8 Previously the PCC driver depended on the client side to map the communication space base address. This region was was then used in the PCC driver and the client side. The client side used this region to read and write its data and the PCC driver used it to only write the PCC command. Removing this split simplifies the PCC driver a lot. This patch moves all communication region read/writes to the client side. The PCC clients can now drive the PCC mailbox controller via the mbox_client_txdone() method. Signed-off-by: Ashwin Chaugule <ashwin.chaugule@linaro.org> 
Previously the PCC driver depended on the client
side to map the communication space base address. This region
was was then used in the PCC driver and the client side.
The client side used this region to read and write its data
and the PCC driver used it to only write the PCC command.
Removing this split simplifies the PCC driver a lot. This patch
moves all communication region read/writes to the client side.
The PCC clients can now drive the PCC mailbox controller via the
mbox_client_txdone() method.

Signed-off-by: Ashwin Chaugule <ashwin.chaugule@linaro.org>
Merge branch 'mailbox-devel' of git://git.linaro.org/landing-teams/working/fujitsu/integration 2015-02-11T20:56:40+00:00 Linus Torvalds torvalds@linux-foundation.org 2015-02-11T20:56:40+00:00 bfe9183fdcc0575a648d1401facc649888a1f49a Pull mailbox framework updates from Jassi Brar. * 'mailbox-devel' of git://git.linaro.org/landing-teams/working/fujitsu/integration: mailbox: Add Altera mailbox driver mailbox: check for bit set before polling Mailbox: Fix return value check in pcc_init() 
Pull mailbox framework updates from Jassi Brar.

* 'mailbox-devel' of git://git.linaro.org/landing-teams/working/fujitsu/integration:
  mailbox: Add Altera mailbox driver
  mailbox: check for bit set before polling
  Mailbox: Fix return value check in pcc_init()
mailbox: Add Altera mailbox driver 2015-02-06T05:28:27+00:00 Ley Foon Tan lftan@altera.com 2015-02-04T08:32:18+00:00 f62092f6d77dfd9214ae753a24b76ba4ecd801d7 The Altera mailbox allows for interprocessor communication. It supports only one channel and work as either sender or receiver. Signed-off-by: Ley Foon Tan <lftan@altera.com> 
The Altera mailbox allows for interprocessor communication. It supports
only one channel and work as either sender or receiver.

Signed-off-by: Ley Foon Tan <lftan@altera.com>
mailbox: check for bit set before polling 2015-02-06T05:28:05+00:00 Jassi Brar jassisinghbrar@gmail.com 2014-12-12T09:52:49+00:00 01340df8d3cd4d8f1773d5f1f569b77bbfce31ad Before polling we just need to see if the TXDONE_BY_POLL bit is set in txdone_method. There may be another bit (method) specified as well, like TXDONE_BY_ACK. Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com> 
Before polling we just need to see if the TXDONE_BY_POLL bit
is set in txdone_method. There may be another bit (method)
specified as well, like TXDONE_BY_ACK.

Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
Mailbox: Fix return value check in pcc_init() 2015-02-06T05:27:56+00:00 Wei Yongjun yongjun_wei@trendmicro.com.cn 2015-01-14T01:10:56+00:00 356d5d28f2cd45ee1956ee868de6f5d37bb9f7dd In case of error, the function platform_create_bundle() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> 
In case of error, the function platform_create_bundle() returns
ERR_PTR() and never returns NULL. The NULL test in the return value
check should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
ACPI / PCC: Use pr_debug() for debug messages in pcc_init() 2015-02-04T23:40:08+00:00 Rafael J. Wysocki rafael.j.wysocki@intel.com 2015-02-04T23:40:08+00:00 efd756daf4ddae3cec2404c4e0b680b7cfdd6a45 pcc_init() uses pr_err() to print two messages that are really debug and not interesting to users. Replace those pr_err() with pr_debug(). Reported-by: Cristian <caravena@gmail.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> 
pcc_init() uses pr_err() to print two messages that are really debug
and not interesting to users.  Replace those pr_err() with pr_debug().

Reported-by: Cristian <caravena@gmail.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>