linux-stable.git/drivers/lightnvm, branch v4.12.2

lightnvm: fix bad back free on error path

2017-05-04T13:53:04+00:00

Free memory correctly when an allocation fails on a loop and we free
backwards previously successful allocations.

Signed-off-by: Javier González 
Reviewed-by: Matias Bjørling 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

lightnvm: fix possible memory leak in pblk_bb_discovery()

2017-04-25T16:44:29+00:00

'blks' is malloced in pblk_bb_discovery() and should be freed
before leaving from the nvm_get_tgt_bb_tbl() error handling cases,
otherwise it will cause memory leak. Also skip assign blks to
rlun->bb_list when error.

Fixes: a4bd217b4326 ("lightnvm: physical block device (pblk) target")
Signed-off-by: Wei Yongjun 
Reviewed-by: Javier GonzÃ¡lez 
Signed-off-by: Jens Axboe

lightnvm: pblk: fix erase counters on error fail

2017-04-23T22:57:52+00:00

When block erases fail, these blocks are marked bad. The number of valid
blocks in the line was not updated, which could cause an infinite loop
on the erase path.

Fix this atomic counter and, in order to avoid taking an irq lock on the
interrupt context, make the erase counters atomic too.

Also, in the case that a significant number of blocks become bad in a
line, the result is the double shared metadata buffer (emeta) to stop
the pipeline until all metadata is flushed to the media. Increase the
number of metadata lines from 2 to 4 to avoid this case.

Fixes: a4bd217b4326 "lightnvm: physical block device (pblk) target"

Signed-off-by: Javier González 
Reviewed-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: pblk: free metadata on line alloc failure

2017-04-23T22:57:52+00:00

When a line allocation fails, for example, due to having too many bad
blocks, free its metadata correctly.

Fixes: a4bd217b4326 "lightnvm: physical block device (pblk) target"

Signed-off-by: Javier González 
Reviewed-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: pblk: fix memory leak on error path

2017-04-23T22:57:52+00:00

When write recovery fails, Free memory for the recovery structure.

Fixes: a4bd217b4326 "lightnvm: physical block device (pblk) target"

Signed-off-by: Javier González 
Reviewed-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: pblk: fix bad error check

2017-04-23T22:57:52+00:00

Fix bad error check

Fixes: a4bd217b4326 "lightnvm: physical block device (pblk) target"

Signed-off-by: Javier González 
Reviewed-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: pblk: fix race condition on line retry

2017-04-23T22:57:52+00:00

When a pblk line fails (or is recovered), make sure to take the line
management lock.

Fixes: a4bd217b4326 "lightnvm: physical block device (pblk) target"

Signed-off-by: Javier González 
Reviewed-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: don't print a warning for ADDR_EMPTY

2017-04-21T22:49:56+00:00

Reading from ADDR_EMPTY is out of bounds.  The current code generates a
static checker warning because we check for out of bounds "lba" before
we check for ADDR_EMPTY, so the second check is always false.  It looks
like we intended ADDR_EMPTY to be a no-op without printing a warning.

Fixes: a4bd217b4326 ("lightnvm: physical block device (pblk) target")
Signed-off-by: Dan Carpenter 
Reviewed-by: Javier González 
Signed-off-by: Jens Axboe

lightnvm: potential underflow in pblk_read_rq()

2017-04-21T22:48:40+00:00

This is a static checker fix, and perhaps not a real bug.  The static
checker thinks that nr_secs could be negative.  It would result in
zeroing more memory than intended.  Anyway, even if it's not a bug,
changing this variable to unsigned makes the code easier to audit.

Fixes: a4bd217b4326 ("lightnvm: physical block device (pblk) target")
Signed-off-by: Dan Carpenter 
Reviewed-by: Javier González 
Signed-off-by: Jens Axboe

lightnvm: propagate pblk_init return to userspace

2017-04-21T18:40:41+00:00

From userspace calling ioctl(NVM_DEV_CREATE) was returning ENOMEM for
invalid arguments even though pblk (pblk_init) was returning correctly
-EINVAL to nvm_create_tgt inside core.  This patch propagates the
correct return value to userspace.

Because pblk was introduced recently this only needs to go in 4.12.

Fixes: a4bd217b4326 ("lightnvm: physical block device (pblk) target")
Signed-off-by: Rakesh Pandit 
Signed-off-by: Jens Axboe