linux-stable.git/drivers/lightnvm, branch linux-4.8.y

block: get rid of bio_rw and READA

2016-07-20T23:37:01+00:00

These two are confusing leftover of the old world order, combining
values of the REQ_OP_ and REQ_ namespaces.  For callers that don't
special case we mostly just replace bi_rw with bio_data_dir or
op_is_write, except for the few cases where a switch over the REQ_OP_
values makes more sense.  Any check for READA is replaced with an
explicit check for REQ_RAHEAD.  Also remove the READA alias for
REQ_RAHEAD.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Mike Christie 
Signed-off-by: Jens Axboe

lightnvm: make __nvm_submit_ppa static

2016-07-07T14:51:52+00:00

The __nvm_submit_ppa() function is not used outside lightnvm core.

Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: make ppa_list const in nvm_set_rqd_list

2016-07-07T14:51:52+00:00

The passed by reference ppa list in nvm_set_rqd_list() is updated when
multiple planes are available. In that case, each PPA plane is
incremented when the device side PPA list is created. This prevents the
caller to rely on the PPA list to be unmodified after a call.

Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: fix lun offset calculation for mark blk

2016-07-07T14:51:52+00:00

The gen_mark_blk_bad function marks the wrong block when a block is on
a different channel. Fix the index calculation, so that it updates the
correct block.

Reported-by: Javier Gonzalez 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: make rrpc_map_page call nvm_get_blk outside locks

2016-07-07T14:51:52+00:00

The nvm_get_blk() function is called with rlun->lock held. This is ok
when the media manager implementation doesn't go out of its atomic
context. However, if a media manager persists its metadata, and
guarantees that the block is given to the target, this is no longer
a viable approach. Therefore, clean up the flow of rrpc_map_page,
and make sure that nvm_get_blk() is called without any locks acquired.

Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: remove _unlocked variant of [get/put]_blk

2016-07-07T14:51:52+00:00

The [get/put]_blk API enables targets to get ownership of blocks at
runtime. This information is currently not recorded on disk, and the
information is therefore lost on power failure. To restore the
metadata, the [get/put]_blk must persist its metadata. In that case,
we need to control the outer lock, so that we can disable them while
updating the on-disk metadata. Fortunately, the _unlocked versions can
be removed, which allows us to move the lock into the [get/put]_blk
functions.

Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: remove unused lists from struct rrpc_block

2016-07-07T14:51:52+00:00

The ->list, ->open_list, and ->closed_list lists were previously used
for statistics. However, their usage have been removed, and thus these
can safely be removed.

Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: remove nested lock conflict with mm

2016-07-07T14:51:52+00:00

If a media manager tries to initialize it targets upon media manager
initialization, the media manager will need to know which target types
are available in LightNVM. The lists of which managers and target types
are available shares the same lock.

Therefore, on initialization, the nvm_lock is taken by LightNVM core,
which later leads to a deadlock when target types are enumerated by the
media manager.

Add an exclusive lock for target types to resolve this conflict.

Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: move target mgmt into media mgr

2016-07-07T14:51:52+00:00

To enable persistent block management to easily control creation and
removal of targets, we move target management into the media
manager. The LightNVM core continues to maintain which target types are
registered, while the media manager now keeps track of its initialized
targets.

Two new callbacks for the media manager are introduced. create_tgt and
remove_tgt. Note that remove_tgt returns 0 on successfully removing a
target, and returns 1 if the target was not found.

Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: rename gennvm and update description

2016-07-07T14:51:52+00:00

The generic manager should be called the general media manager, and
instead of using the rather long name of "gennvm" in front of each data
structures, use "gen" instead to shorten it. Update the description of
the media manager as well to make the media manager purpose clearer.

Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe