linux-stable.git/drivers/lightnvm/rrpc.c, branch linux-4.5.y

lightnvm: update closed list outside of intr context

2016-05-11T09:21:27+00:00

commit 6adb03de406e8c92579c2e4b11640841fa908277 upstream.

When an I/O finishes, full blocks are moved from the open to the closed
list - a lock is taken to protect the list. This happens at the moment
in the interrupt context, which is not correct.

This patch moves this logic to the block workqueue instead, avoiding
holding a spinlock without interrupt save in an interrupt context.

Signed-off-by: Javier González 
Fixes: ff0e498bfa18 ("lightnvm: manage open and closed blocks sepa...")
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe 
Signed-off-by: Greg Kroah-Hartman

lightnvm: put bio before return

2016-02-04T16:19:45+00:00

The bio is not returned if the data page cannot be allocated.

Signed-off-by: Wenwei Tao 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: manage open and closed blocks separately

2016-01-12T15:21:17+00:00

LightNVM targets need to know the state of the flash block when doing
flash optimizations. An example is implementing a write buffer to
respect the flash page size. Currently, block state is not accounted
for; the media manager only differentiates among free, bad and in-use
blocks.

This patch adds the logic in the generic media manager to enable
targets manage blocks into open and close separately, and it implements
such management in rrpc. It also adds a set of flags to describe the
state of the block (open, closed, free, bad).

In order to avoid taking two locks (nvm_lun and rrpc_lun) consecutively,
we introduce lockless get_/put_block primitives so that the open and
close list locks and future common logic is handled within the nvm_lun
lock.

Signed-off-by: Javier González 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: reference rrpc lun in rrpc block

2016-01-12T15:21:17+00:00

Currently, a rrpc block only points to its nvm_lun. If a user wants to
find the associated rrpc lun, it will have to calculate the index and
look it up manually. By referencing the rrpc lun directly, this step can
be omitted, at the cost of a larger memory footprint.

This is important for upcoming patches that implement write buffering in
rrpc.

Signed-off-by: Javier González 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: move rq->error to nvm_rq->error

2016-01-12T15:21:17+00:00

Instead of passing request error into the LightNVM modules, incorporate
it into the nvm_rq.

Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: move the pages per block check out of the loop

2016-01-12T15:21:17+00:00

There is no need to check whether dev's pages per block is
beyond rrpc support every time we init a lun, we only need
to check it once before enter the lun init loop.

Signed-off-by: Wenwei Tao 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: fix locking and mempool in rrpc_lun_gc

2016-01-12T15:21:16+00:00

This patch fix two issues in rrpc_lun_gc

1. prio_list is protected by rrpc_lun's lock not nvm_lun's, so
acquire rlun's lock instead of lun's before operate on the list.

2. we delete block from prio_list before allocating gcb, but gcb
allocation may fail, we end without putting it back to the list,
this makes the block won't get reclaimed in the future. To solve
this issue, delete block after gcb allocation.

Signed-off-by: Wenwei Tao 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: put block back to gc list on its reclaim fail

2016-01-12T15:21:16+00:00

We delete a block from the gc list before reclaim it, so
put it back to the list on its reclaim fail, otherwise
this block will not get reclaimed and be programmable
in the future.

Signed-off-by: Wenwei Tao 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: check bi_error in gc

2016-01-12T15:21:16+00:00

We should check last io completion status before
starting another one.

Signed-off-by: Wenwei Tao 
Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe

lightnvm: refactor end_io functions for sync

2016-01-12T15:21:16+00:00

To implement sync I/O support within the LightNVM core, the end_io
functions are refactored to take an end_io function pointer instead of
testing for initialized media manager, followed by calling its end_io
function.

Sync I/O can then be implemented using a callback that signal I/O
completion. This is similar to the logic found in blk_to_execute_io().
By implementing it this way, the underlying device I/Os submission logic
is abstracted away from core, targets, and media managers.

Signed-off-by: Matias Bjørling 
Signed-off-by: Jens Axboe