linux-stable.git/drivers/leds, branch v4.9.166

leds: lp5523: fix a missing check of return value of lp55xx_read

2019-02-27T09:07:00+00:00

[ Upstream commit 248b57015f35c94d4eae2fdd8c6febf5cd703900 ]

When lp55xx_read() fails, "status" is an uninitialized variable and thus
may contain random value; using it leads to undefined behaviors.

The fix inserts a check for the return value of lp55xx_read: if it
fails, returns with its error code.

Signed-off-by: Kangjie Lu 
Signed-off-by: Jacek Anaszewski 
Signed-off-by: Sasha Levin

leds: pca955x: Correct I2C Functionality

2018-04-13T17:48:03+00:00

[ Upstream commit aace34c0bb8ea3c8bdcec865b6a4be4db0a68e33 ]

The driver checks an incorrect flag of functionality of adapter.
When a driver requires i2c_smbus_read_byte_data and
i2c_smbus_write_byte_data, it should check I2C_FUNC_SMBUS_BYTE_DATA
instead I2C_FUNC_I2C.
This patch fixes the problem.

Signed-off-by: Tin Huynh 
Signed-off-by: Jacek Anaszewski 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

led: core: Clear LED_BLINK_SW flag in led_blink_set()

2018-03-24T10:00:08+00:00

[Only needed in 4.9.y due to other fixes in mainline - gregkh]

With the current code, the following sequence won't work :
echo timer > trigger

echo 0 >  delay_off
* at this point we call
** led_delay_off_store
** led_blink_set

Revert "led: core: Fix brightness setting when setting delay_off=0"

2018-03-24T10:00:08+00:00

This reverts commit 86b9fa2190907f4f550d9d6bf490c5f89ca33836 which was
commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c upstream.

The commit being reverted has two flaws:
 - it introduces a regression, fixed in the upstream
   commit 7b6af2c53192f1766892ef40c8f48a413509ed72.
 - it has truncated commit message

Reported-by: Sasha Levin 
Reported-by: Matthias Schiffer 
Signed-off-by: Jacek Anaszewski 
Signed-off-by: Greg Kroah-Hartman

leds: pm8058: Silence pointer to integer size warning

2018-03-22T08:17:55+00:00

[ Upstream commit 8f52df50d9366f770a894d14ef724e5e04574e98 ]

The pointer returned by of_device_get_match_data() doesn't have the same
size as u32 on 64-bit architectures, causing a compile warning when
compile-testing the driver on such platform.

Cast the return value of of_device_get_match_data() to unsigned long and
then to u32 to silence this warning.

Fixes: 7f866986e705 ("leds: add PM8058 LEDs driver")
Signed-off-by: Bjorn Andersson 
Reviewed-by: Linus Walleij 
Acked-by: Pavel Machek 
Signed-off-by: Lee Jones 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

led: core: Fix brightness setting when setting delay_off=0

2018-03-03T09:23:24+00:00

[ Upstream commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c ]

With the current code, the following sequence won't work :
echo timer > trigger

echo 0 >  delay_off
* at this point we call
** led_delay_off_store
** led_blink_set

Revert "leds: handle suspend/resume in heartbeat trigger"

2017-08-30T08:21:51+00:00

commit 436c4c45b5b9562b59cedbb51b7343ab4a6dd8cc upstream.

This reverts commit 5ab92a7cb82c66bf30685583a38a18538e3807db.

System cannot enter suspend mode because of heartbeat led trigger.
In autosleep_wq, try_to_suspend function will try to enter suspend
mode in specific period. it will get wakeup_count then call pm_notifier
chain callback function and freeze processes.
Heartbeat_pm_notifier is called and it call led_trigger_unregister to
change the trigger of led device to none. It will send uevent message
and the wakeup source count changed. As wakeup_count changed, suspend
will abort.

Fixes: 5ab92a7cb82c ("leds: handle suspend/resume in heartbeat trigger")
Signed-off-by: Zhang Bo 
Acked-by: Pavel Machek 
Reviewed-by: Linus Walleij 
Signed-off-by: Jacek Anaszewski 
Cc: Geert Uytterhoeven 
Signed-off-by: Greg Kroah-Hartman

leds: ktd2692: avoid harmless maybe-uninitialized warning

2017-05-14T12:00:15+00:00

commit cbe99c538d1776009e8710755bb6e726f7fffa9b upstream.

gcc gets confused about the control flow in ktd2692_parse_dt(), causing
it to warn about what seems like a potential bug:

drivers/leds/leds-ktd2692.c: In function 'ktd2692_probe':
drivers/leds/leds-ktd2692.c:244:15: error: '*((void *)&led_cfg+8)' may be used uninitialized in this function [-Werror=maybe-uninitialized]
drivers/leds/leds-ktd2692.c:225:7: error: 'led_cfg.flash_max_microamp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
drivers/leds/leds-ktd2692.c:232:3: error: 'led_cfg.movie_max_microamp' may be used uninitialized in this function [-Werror=maybe-uninitialized]

The code is fine, and slightly reworking it in an equivalent way lets
gcc figure that out too, which gets rid of the warning.

Fixes: 77e7915b15bb ("leds: ktd2692: Add missing of_node_put")
Signed-off-by: Arnd Bergmann 
Acked-by: Pavel Machek 
Signed-off-by: Jacek Anaszewski 
Signed-off-by: Greg Kroah-Hartman

leds: triggers: Check return value of kobject_uevent_env()

2016-09-20T08:22:10+00:00

Log error message if kobject_uevent_env() fails in led_trigger_set().

Signed-off-by: Jacek Anaszewski 
Acked-by: Greg Kroah-Hartman

leds: triggers: Return from led_trigger_set() if there is nothing to do

2016-09-20T08:21:17+00:00

If led_trigger_set() is called with "trig" argument set to NULL, and there
is no trigger to remove then the function should return immediately so
as to avoid doing unnecessary allocation and sending uevent.

Signed-off-by: Jacek Anaszewski 
Reported-by: Daniel Romell 
Acked-by Daniel Romell