linux-stable.git/drivers/leds/flash, branch v6.4.2

leds: flash: Set variables mvflash_{3,4}ch_regs storage-class-specifier to static

2023-03-30T12:58:24+00:00

Smatch reports:

  drivers/leds/flash/leds-qcom-flash.c:103:18: warning:
    symbol 'mvflash_3ch_regs' was not declared. Should it be static?
  drivers/leds/flash/leds-qcom-flash.c:115:18: warning:
    symbol 'mvflash_4ch_regs' was not declared. Should it be static?

These variables are only used locally, so it should be static.

Signed-off-by: Tom Rix 
Acked-by: Pavel Machek 
Signed-off-by: Lee Jones 
Link: https://lore.kernel.org/r/20230317191341.1670660-1-trix@redhat.com

leds: flash: mt6370: Add MediaTek MT6370 flashlight support

2023-03-23T14:54:08+00:00

The MediaTek MT6370 is a highly-integrated smart power management IC,
which includes a single cell Li-Ion/Li-Polymer switching battery
charger, a USB Type-C & Power Delivery (PD) controller, dual Flash
LED current sources, a RGB LED driver, a backlight WLED driver,
a display bias driver and a general LDO for portable devices.

Add support for the MT6370 Flash LED driver. Flash LED in MT6370
has 2 channels and support torch/strobe mode.

Co-developed-by: Alice Chen 
Signed-off-by: Alice Chen 
Signed-off-by: ChiYuan Huang 
Signed-off-by: ChiaEn Wu 
Acked-by: Jacek Anaszewski 
Signed-off-by: Lee Jones 
Link: https://lore.kernel.org/r/52480420a160e5a4c71715fbbf105e684a16e7c2.1678430444.git.chiaen_wu@richtek.com

leds: flash: Add driver to support flash LED module in QCOM PMICs

2023-03-16T15:08:45+00:00

Add initial driver to support flash LED module found in Qualcomm
Technologies, Inc. PMICs. The flash module can have 3 or 4 channels
and each channel can be controlled indepedently and support full scale
current up to 1.5 A. It also supports connecting two channels together
to supply one LED component with full scale current up to 2 A. In that
case, the current will be split on each channel symmetrically and the
channels will be enabled and disabled at the same time.

Signed-off-by: Fenglin Wu 
Tested-by: Luca Weiss  # sm7225-fairphone-fp4 + pm6150l
Signed-off-by: Lee Jones 
Link: https://lore.kernel.org/r/20230303095023.538917-2-quic_fenglinw@quicinc.com

leds: mt6360: Get rid of custom led_init_default_state_get()

2023-01-30T08:03:39+00:00

LED core provides a helper to parse default state from firmware node.
Use it instead of custom implementation.

Signed-off-by: Andy Shevchenko 
Reviewed-by: Matthias Brugger 
Reviewed-by: AngeloGioacchino Del Regno 
Signed-off-by: Lee Jones 
Link: https://lore.kernel.org/r/20230103131256.33894-8-andriy.shevchenko@linux.intel.com

i2c: Make remove callback return void

2022-08-16T10:46:26+00:00

The value returned by an i2c driver's remove function is mostly ignored.
(Only an error message is printed if the value is non-zero that the
error is ignored.)

So change the prototype of the remove function to return no value. This
way driver authors are not tempted to assume that passing an error to
the upper layer is a good idea. All drivers are adapted accordingly.
There is no intended change of behaviour, all callbacks were prepared to
return 0 before.

Reviewed-by: Peter Senna Tschudin 
Reviewed-by: Jeremy Kerr 
Reviewed-by: Benjamin Mugnier 
Reviewed-by: Javier Martinez Canillas 
Reviewed-by: Crt Mori 
Reviewed-by: Heikki Krogerus 
Acked-by: Greg Kroah-Hartman 
Acked-by: Marek Behún  # for leds-turris-omnia
Acked-by: Andy Shevchenko 
Reviewed-by: Petr Machata  # for mlxsw
Reviewed-by: Maximilian Luz  # for surface3_power
Acked-by: Srinivas Pandruvada  # for bmc150-accel-i2c + kxcjk-1013
Reviewed-by: Hans Verkuil  # for media/* + staging/media/*
Acked-by: Miguel Ojeda  # for auxdisplay/ht16k33 + auxdisplay/lcd2s
Reviewed-by: Luca Ceresoli  # for versaclock5
Reviewed-by: Ajay Gupta  # for ucsi_ccg
Acked-by: Jonathan Cameron  # for iio
Acked-by: Peter Rosin  # for i2c-mux-*, max9860
Acked-by: Adrien Grassein  # for lontium-lt8912b
Reviewed-by: Jean Delvare  # for hwmon, i2c-core and i2c/muxes
Acked-by: Corey Minyard  # for IPMI
Reviewed-by: Vladimir Oltean 
Acked-by: Dmitry Torokhov 
Acked-by: Sebastian Reichel  # for drivers/power
Acked-by: Krzysztof Hałasa 
Signed-off-by: Uwe Kleine-König 
Signed-off-by: Wolfram Sang

leds: lm3601x: Improve error reporting for problems during .remove()

2022-08-16T10:34:04+00:00

Returning an error value in an i2c remove callback results in a generic
error message being emitted by the i2c core, but otherwise it doesn't
make a difference. The device goes away anyhow and the devm cleanups are
called.

So instead of triggering the generic i2c error message, emit a more
helpful message if a problem occurs and return 0 to suppress the generic
message.

This patch is a preparation for making i2c remove callbacks return void.

Acked-by: Pavel Machek 
Signed-off-by: Uwe Kleine-König 
Signed-off-by: Wolfram Sang

leds: lm3601x: Don't use mutex after it was destroyed

2022-08-16T10:33:55+00:00

The mutex might still be in use until the devm cleanup callback
devm_led_classdev_flash_release() is called. This only happens some time
after lm3601x_remove() completed.

Fixes: e63a744871a3 ("leds: lm3601x: Convert class registration to device managed")
Acked-by: Pavel Machek 
Signed-off-by: Uwe Kleine-König 
Signed-off-by: Wolfram Sang

leds: ktd2692: Make aux-gpios optional

2022-05-07T21:12:19+00:00

Make the AUX pin optional, since it isn't a core part of functionality,
and the device is designed to be operational with only one CTRL pin.

Reviewed-by: Andy Shevchenko 
Signed-off-by: Markuss Broks 
Signed-off-by: Pavel Machek

leds: ktd2692: Avoid duplicate error messages on probe deferral

2022-05-07T21:12:18+00:00

Use dev_err_probe instead of dev_err to avoid duplicate error
messages if the GPIO allocation makes the probe defer.

Signed-off-by: Markuss Broks 
Signed-off-by: Pavel Machek

leds: sgm3140: Add ocs,ocp8110 compatible

2022-02-12T11:27:53+00:00

Orient-Chip's ocp8110 has the same pin configuration as the sgm3140.
The data sheet can be found at:
https://cdn.datasheetspdf.com/pdf-down/O/C/P/OCP8110-OrientChip.pdf

Signed-off-by: André Apitzsch 
Signed-off-by: Pavel Machek