linux-stable.git/drivers/ipack, branch v4.9.282

ipack: tpci200: fix many double free issues in tpci200_pci_probe

2021-08-26T12:37:28+00:00

[ Upstream commit 57a1681095f912239c7fb4d66683ab0425973838 ]

The function tpci200_register called by tpci200_install and
tpci200_unregister called by tpci200_uninstall are in pair. However,
tpci200_unregister has some cleanup operations not in the
tpci200_register. So the error handling code of tpci200_pci_probe has
many different double free issues.

Fix this problem by moving those cleanup operations out of
tpci200_unregister, into tpci200_pci_remove and reverting
the previous commit 9272e5d0028d ("ipack/carriers/tpci200:
Fix a double free in tpci200_pci_probe").

Fixes: 9272e5d0028d ("ipack/carriers/tpci200: Fix a double free in tpci200_pci_probe")
Cc: stable@vger.kernel.org
Reported-by: Dongliang Mu 
Signed-off-by: Dongliang Mu 
Link: https://lore.kernel.org/r/20210810100323.3938492-1-mudongliangabcd@gmail.com
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Sasha Levin

ipack/carriers/tpci200: Fix a double free in tpci200_pci_probe

2021-07-20T14:21:10+00:00

commit 9272e5d0028d45a3b45b58c9255e6e0df53f7ad9 upstream.

In the out_err_bus_register error branch of tpci200_pci_probe,
tpci200->info->cfg_regs is freed by tpci200_uninstall()->
tpci200_unregister()->pci_iounmap(..,tpci200->info->cfg_regs)
in the first time.

But later, iounmap() is called to free tpci200->info->cfg_regs
again.

My patch sets tpci200->info->cfg_regs to NULL after tpci200_uninstall()
to avoid the double free.

Fixes: cea2f7cdff2af ("Staging: ipack/bridges/tpci200: Use the TPCI200 in big endian mode")
Cc: stable 
Acked-by: Samuel Iglesias Gonsalvez 
Signed-off-by: Lv Yunlong 
Link: https://lore.kernel.org/r/20210524093205.8333-1-lyl2019@mail.ustc.edu.cn
Signed-off-by: Greg Kroah-Hartman

ipack: print a hex number after a 0x prefix

2016-10-28T01:43:43+00:00

It makes the result hard to interpret correctly if a base 10 number is
prefixed by 0x.  So change to a hex number.

Link: http://lkml.kernel.org/r/20161026125658.25728-4-u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König 
Cc: Samuel Iglesias Gonsalvez 
Cc: Jens Taprogge 
Cc: Greg Kroah-Hartman 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

tty: Replace ASYNC_INITIALIZED bit and update atomically

2016-04-30T16:26:55+00:00

Replace ASYNC_INITIALIZED bit in the tty_port::flags field with
TTY_PORT_INITIALIZED bit in the tty_port::iflags field. Introduce helpers
tty_port_set_initialized() and tty_port_initialized() to abstract
atomic bit ops.

Note: the transforms for test_and_set_bit() and test_and_clear_bit()
are unnecessary as the state transitions are already mutually exclusive;
the tty lock prevents concurrent open/close/hangup.

Signed-off-by: Peter Hurley 
Signed-off-by: Greg Kroah-Hartman

ipoctal: clear break interrupt as soon as it occurs

2014-09-24T06:26:42+00:00

In some condition we receive the break interrupt but nothing is putted
in the Rx FIFO and the correspondend bit in the status register is not
set. Thus, no-one clear the interrupt and the handler will be called
forever.

This patch clear the break interrupt as soon as it occurs. Then, if the
break character '\0' is putted in the fifo we will manage it.

We can also unmask the Break interrupt but its bit in ISR is still set
on break. So I think is better to keep the registers clean.

Signed-off-by: Federico Vaga 
Acked-by: Samuel Iglesias Gonsalvez 
Signed-off-by: Greg Kroah-Hartman

ipoctal: get carrier driver to avoid rmmod

2014-09-24T06:13:13+00:00

Signed-off-by: Federico Vaga 
Acked-by: Samuel Iglesias Gonsalvez 
Signed-off-by: Greg Kroah-Hartman

ipack: save carrier owner to allow device to get it

2014-09-24T06:13:13+00:00

There was not any kind of protection against carrier driver removal.
In this way, device driver can 'get' the carrier driver when it is
using it.

Signed-off-by: Federico Vaga 
Acked-by: Samuel Iglesias Gonsalvez 
Signed-off-by: Greg Kroah-Hartman

ipoctal: reset function istead of duplicate code

2014-09-24T06:13:13+00:00

Signed-off-by: Federico Vaga 
Acked-by: Samuel Iglesias Gonsalvez 
Signed-off-by: Greg Kroah-Hartman

drivers/ipack/devices/ipoctal.h: Fix typo in include guard

2014-09-24T06:13:13+00:00

Signed-off-by: Rasmus Villemoes 
Acked-by: Samuel Iglesias Gonsalvez 
Signed-off-by: Greg Kroah-Hartman

ipack: Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18T23:50:55+00:00

We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet
kernel coding style guidelines. This issue was reported by checkpatch.

Signed-off-by: Benoit Taine 
Acked-by: Samuel Iglesias Gonsalvez 
Signed-off-by: Greg Kroah-Hartman