linux-stable.git/drivers/input/touchscreen/sur40.c, branch linux-4.9.y

Input: sur40 - fix interface sanity checks

2020-01-29T09:24:39+00:00

commit 6b32391ed675827f8425a414abbc6fbd54ea54fe upstream.

Make sure to use the current alternate setting when verifying the
interface descriptors to avoid binding to an invalid interface.

This in turn could cause the driver to misbehave or trigger a WARN() in
usb_submit_urb() that kernels with panic_on_warn set would choke on.

Fixes: bdb5c57f209c ("Input: add sur40 driver for Samsung SUR40 (aka MS Surface 2.0/Pixelsense)")
Signed-off-by: Johan Hovold 
Acked-by: Vladis Dronov 
Link: https://lore.kernel.org/r/20191210113737.4016-8-johan@kernel.org
Signed-off-by: Dmitry Torokhov 
Signed-off-by: Greg Kroah-Hartman

Input: sur40 - validate number of endpoints before using them

2017-03-30T07:41:23+00:00

commit 92461f5d723037530c1f36cce93640770037812c upstream.

Make sure to check the number of endpoints to avoid dereferencing a
NULL-pointer or accessing memory that lie beyond the end of the endpoint
array should a malicious device lack the expected endpoints.

Fixes: bdb5c57f209c ("Input: add sur40 driver for Samsung SUR40... ")
Signed-off-by: Johan Hovold 
Signed-off-by: Dmitry Torokhov 
Signed-off-by: Greg Kroah-Hartman

[media] sur40: properly report a single frame rate of 60 FPS

2016-08-24T13:07:06+00:00

The device hardware is always running at 60 FPS, so report this both via
PARM_IOCTL and ENUM_FRAMEINTERVALS.

[hans.verkuil@cisco.com: fix suspect indent checkpatch warning]
[mchehab@s-opensource.com: fix a trivial merge conflict]

Signed-off-by: Martin Kaltenbrunner 
Signed-off-by: Florian Echtler 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

[media] Input: sur40 - use new V4L2 touch input type

2016-08-23T19:34:29+00:00

Support both V4L2_TCH_FMT_TU08 and V4L2_PIX_FMT_GREY for backwards
compatibility.

Signed-off-by: Nick Dyer 
Signed-off-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab 
Acked-by: Dmitry Torokhov

[media] sur40: drop unnecessary format description

2016-07-08T19:16:58+00:00

Don't fill in the format description. This is now done in the V4L2 core to ensure
consistent descriptions.

Signed-off-by: Hans Verkuil 
Acked-by: Nick Dyer 
Signed-off-by: Mauro Carvalho Chehab

[media] sur40: fix occasional oopses on device close

2016-07-08T19:16:57+00:00

Closing the V4L2 device sometimes triggers a kernel oops.
Present patch fixes this.

Signed-off-by: Martin Kaltenbrunner 
Signed-off-by: Florian Echtler 
Signed-off-by: Hans Verkuil 
Cc:       # for v4.2 and up
Signed-off-by: Mauro Carvalho Chehab

[media] sur40: lower poll interval to fix occasional FPS drops to ~56 FPS

2016-07-08T19:16:56+00:00

The framerate sometimes drops below 60 Hz if the poll interval is too high.
Lowering it to the minimum of 1 ms fixes this.

Signed-off-by: Martin Kaltenbrunner 
Signed-off-by: Florian Echtler 
Signed-off-by: Hans Verkuil 
Cc:       # for v4.2 and up
Signed-off-by: Mauro Carvalho Chehab

[media] vb2: replace void alloc_ctxs by struct device alloc_devs

2016-07-08T17:45:07+00:00

Make this a proper typed array. Drop the old allocate context code since
that is no longer used.

Note that the memops functions now get a struct device pointer instead of
the struct device ** that was there initially (actually a void pointer to
a struct containing only a struct device pointer).

This code is now a lot cleaner.

Signed-off-by: Hans Verkuil 
Reviewed-by: Laurent Pinchart 
Cc: Sakari Ailus 
Signed-off-by: Mauro Carvalho Chehab

[media] sur40: set q->dev instead of allocating a context

2016-07-08T17:35:23+00:00

Stop using alloc_ctx and just fill in the device pointer.

Signed-off-by: Hans Verkuil 
Cc: Florian Echtler 
Signed-off-by: Mauro Carvalho Chehab

Input: sur40 - fix DMA on stack

2016-03-24T00:29:30+00:00

During the initialisation the driver uses a buffer on the stack for DMA.
That violates the cache coherency rules. The fix is to allocate the buffer
with kmalloc().

Signed-off-by: Oliver Neukum 
Signed-off-by: Dmitry Torokhov