linux-stable.git/drivers/input/rmi4, branch v4.8 Linux kernel stable tree Input: synaptics-rmi4 - fix register descriptor subpacket map construction 2016-08-22T21:14:46+00:00 Andrew Duggan aduggan@synaptics.com 2016-08-22T18:28:11+00:00 3e29d6bb6433ebfa4e187b1164b80baf720d58c3 The map_offset variable is specific to the register and needs to be reset in the loop. Otherwise, subsequent register's subpacket maps will have their bits set at the wrong index. Signed-off-by: Andrew Duggan <aduggan@synaptics.com> Tested-by: Nitin Chaudhary <nitinchaudhary1289@gmail.com> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
The map_offset variable is specific to the register and needs to be reset
in the loop. Otherwise, subsequent register's subpacket maps will have
their bits set at the wrong index.

Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
Tested-by: Nitin Chaudhary <nitinchaudhary1289@gmail.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
 Merge branch 'next' into for-linus 2016-08-04T01:16:10+00:00 Dmitry Torokhov dmitry.torokhov@gmail.com 2016-08-04T01:16:10+00:00 326a50f5734c228873eb33c6db6c5240c44f2ecc Prepare second round of input updates for 4.8 merge window. 
Prepare second round of input updates for 4.8 merge window.
Input: synaptics-rmi4 - do not check for NULL when calling of_node_put() 2016-07-26T19:09:55+00:00 Markus Elfring elfring@users.sourceforge.net 2016-07-25T18:29:59+00:00 887ec0bfbd146c08e34ccb65a8f4251dc110e52f The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
The of_node_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
 Merge branch 'next' into for-linus 2016-07-26T19:07:15+00:00 Dmitry Torokhov dmitry.torokhov@gmail.com 2016-07-26T19:07:15+00:00 0808882863774ab69066d83f49f511606be024e0 Prepare first round of input updates for 4.8 merge window. 
Prepare first round of input updates for 4.8 merge window.
Input: synaptics-rmi4 - fix maximum size check for F12 control register 8 2016-07-20T00:56:35+00:00 Andrew Duggan aduggan@synaptics.com 2016-07-20T00:53:59+00:00 e4add7b6beaff4061693d0632bc1dcb306edba10 According to the RMI4 spec the maximum size of F12 control register 8 is 15 bytes. The current code incorrectly reports an error if control 8 is greater then 14. Making sensors with a control register 8 with 15 bytes unusable. Signed-off-by: Andrew Duggan <aduggan@synaptics.com> Reported-by: Chris Healy <cphealy@gmail.com> Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
According to the RMI4 spec the maximum size of F12 control register 8 is
15 bytes. The current code incorrectly reports an error if control 8 is
greater then 14. Making sensors with a control register 8 with 15 bytes
unusable.

Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
Reported-by: Chris Healy <cphealy@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
 Merge branch 'for-linus' into next 2016-07-19T18:02:56+00:00 Dmitry Torokhov dmitry.torokhov@gmail.com 2016-07-19T18:02:56+00:00 8c57a5e7b2820f349c95b8c8393fec1e0f4070d2 Sync up to bring in wacom_w8001 changes to avoid merge conflicts later. 
Sync up to bring in wacom_w8001 changes to avoid merge conflicts later.
Input: synaptics-rmi4 - use the RMI_F11_REL_BYTES define in rmi_f11_rel_pos_report 2016-07-14T16:43:44+00:00 Andrew Duggan aduggan@synaptics.com 2016-07-14T16:38:59+00:00 345ded8ef489a888f6921c999f872848c96b5af8 The size of relative data in F11 is already defined by RMI_F11_REL_BYTES. Use the define in rmi_f11_rel_pos_report() to be consistent. Signed-off-by: Andrew Duggan <aduggan@synaptics.com> Reviewed-by: Nick Dyer <nick@shmanahar.org> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
The size of relative data in F11 is already defined by RMI_F11_REL_BYTES.
Use the define in rmi_f11_rel_pos_report() to be consistent.

Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
Reviewed-by: Nick Dyer <nick@shmanahar.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
 Input: synaptics-rmi4 - remove unneeded variable 2016-07-14T16:43:43+00:00 Andrew Duggan aduggan@synaptics.com 2016-07-14T16:38:04+00:00 546ae1085b2772de47221c8780c000ee9829545d Remove the data_base_addr_offset variable in rmi_f11_attention(). The f11 data is read as a single block so there is no need to store an offset to the data address. Signed-off-by: Andrew Duggan <aduggan@synaptics.com> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Reviewed-by: Nick Dyer <nick@shmanahar.org> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
Remove the data_base_addr_offset variable in rmi_f11_attention(). The
f11 data is read as a single block so there is no need to store an offset
to the data address.

Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Reviewed-by: Nick Dyer <nick@shmanahar.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
 Input: synaptics-rmi4 - remove pointer to rmi_function in f12_data 2016-07-14T16:43:42+00:00 Andrew Duggan aduggan@synaptics.com 2016-07-14T16:37:11+00:00 e21582956005bb1677b0c2f9caf1042020f45408 The pointer to struct rmi_function in f12_data is never set and was never used. The fn pointer is also stored in rmi_2d_sensor which is a member of f12_data. Signed-off-by: Andrew Duggan <aduggan@synaptics.com> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Reviewed-by: Nick Dyer <nick@shmanahar.org> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
The pointer to struct rmi_function in f12_data is never set and was never
used. The fn pointer is also stored in rmi_2d_sensor which is a member of
f12_data.

Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Reviewed-by: Nick Dyer <nick@shmanahar.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Input: synaptics-rmi4 - use of_get_child_by_name() to fix refcount 2016-07-14T16:40:39+00:00 Andrew Duggan aduggan@synaptics.com 2016-07-14T16:35:44+00:00 9624516db0f3ffcbd1ba1007775d068f54049773 Calling of_find_node_by_name() assumes that the caller has incremented the refcount of the of_node being passed in. Currently, the caller is not incrementing the refcount of the of_node which results in the node being prematurely freed when of_find_node_by_name() calls of_node_put() on it. Instead use of_get_child_by_name() which does not call put on the of_node. Signed-off-by: Andrew Duggan <aduggan@synaptics.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
Calling of_find_node_by_name() assumes that the caller has incremented
the refcount of the of_node being passed in. Currently, the caller is
not incrementing the refcount of the of_node which results in the node
being prematurely freed when of_find_node_by_name() calls of_node_put()
on it. Instead use of_get_child_by_name() which does not call put on the
of_node.

Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>