linux-stable.git/drivers/input/mousedev.c, branch linux-4.9.y

Input: mousedev - fix implicit conversion warning

2018-04-08T10:12:43+00:00

commit dae1a432ab1fe79ae53129ededeaece35a2dc14d upstream.

Clang warns:

drivers/input/mousedev.c:653:63: error: implicit conversion from 'int'
to 'signed char' changes value from 200 to -56
[-Wconstant-conversion]
  client->ps2[1] = 0x60; client->ps2[2] = 3; client->ps2[3] = 200;
                                                            ~ ^~~
As the PS2 data is really a stream of bytes, let's switch to using u8 type
for it, which silences this warning.

Signed-off-by: Nick Desaulniers 
Signed-off-by: Dmitry Torokhov 
Cc: Nathan Chancellor 
Signed-off-by: Greg Kroah-Hartman

Input: mousedev - fix race when creating mixed device

2014-03-29T21:44:23+00:00

We should not be using static variable mousedev_mix in methods that can be
called before that singleton gets assigned. While at it let's add open and
close methods to mousedev structure so that we do not need to test if we
are dealing with multiplexor or normal device and simply call appropriate
method directly.

This fixes: https://bugzilla.kernel.org/show_bug.cgi?id=71551

Reported-by: GiulioDP 
Tested-by: GiulioDP 
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov

Input: mousedev - move /dev/input/mice to the correct minor

2012-11-19T07:15:16+00:00

When doing conversion to dynamic input numbers I inadvertently moved
/dev/input/mice from c,13,63 to c,13,31. We need to fix this so that
setups with statically populated /dev continue working.

Tested-by: Krzysztof Mazur 
Tested-by: Pavel Machek 
Signed-off-by: Dmitry Torokhov

Input: fix use-after-free introduced with dynamic minor changes

2012-10-22T05:50:37+00:00

Commit 7f8d4cad1e4e ("Input: extend the number of event (and other)
devices") made evdev, joydev and mousedev to embed struct cdev into
their respective structures representing input devices.

Unfortunately character device structure may outlive the parent
structure unless we do not set it up as parent of character device so
that it will stay pinned until character device is freed.

Also, now that parent structure is pinned while character device exists
we do not need to pin and unpin it every time user opens or closes it.

Reported-by: Dave Jones 
Signed-off-by: Dmitry Torokhov 
Acked-by: Al Viro 
Signed-off-by: Linus Torvalds

Input: extend the number of event (and other) devices

2012-10-08T16:37:55+00:00

Extend the amount of character devices, such as eventX, mouseX and jsX,
from a hard limit of 32 per input handler to about 1024 shared across
all handlers.

To be compatible with legacy installations input handlers will start
creating char devices with minors in their legacy range, however once
legacy range is exhausted they will start allocating minors from the
dynamic range 256-1024.

Reviewed-by: David Herrmann 
Signed-off-by: Dmitry Torokhov

Input: mousedev - mark mousedev interfaces as non-seekable

2012-10-08T16:37:50+00:00

Seeking does not make sense for mousedev, so let's use nonseekable_open()
to mark its devices as non-seekable.

Reviewed-by: David Herrmann 
Signed-off-by: Dmitry Torokhov

Input: mousedev - rename mixdev_open to opened_by_mixdev

2012-10-08T16:37:45+00:00

Do the rename to make the logic more clear and also change it to bool
while at it.

Reviewed-by: David Herrmann 
Signed-off-by: Dmitry Torokhov

Input: mousedev - reformat structure initializers

2012-10-08T16:37:41+00:00

Reformat structure initializers to match the rest of input handlers

Reviewed-by: David Herrmann 
Signed-off-by: Dmitry Torokhov

Input: mousedev - factor out psaux code to reduce #ifdefery

2012-10-08T16:37:38+00:00

Reviewed-by: David Herrmann 
Signed-off-by: Dmitry Torokhov

Input: random formatting fixes

2012-08-22T05:29:49+00:00

Fixes for some coding style issues reported by scripts/checkpatch.pl
utility.

Signed-off-by: Baodong Chen 
Signed-off-by: Dmitry Torokhov