linux-stable.git/drivers/input/mouse/alps.c, branch linux-3.4.y

Input: alps - allow up to 2 invalid packets without resetting device

2015-02-02T09:05:19+00:00

commit 9d720b34c0a432639252f63012e18b0507f5b432 upstream.

On some Dell Latitude laptops ALPS device or Dell EC send one invalid byte
in 6 bytes ALPS packet. In this case psmouse driver enter out of sync
state. It looks like that all other bytes in packets are valid and also
device working properly. So there is no need to do full device reset, just
need to wait for byte which match condition for first byte (start of
packet). Because ALPS packets are bigger (6 or 8 bytes) default limit is
small.

This patch increase number of invalid bytes to size of 2 ALPS packets which
psmouse driver can drop before do full reset.

Resetting ALPS devices take some time and when doing reset on some Dell
laptops touchpad, trackstick and also keyboard do not respond. So it is
better to do it only if really necessary.

Signed-off-by: Pali Rohár 
Tested-by: Pali Rohár 
Reviewed-by: Hans de Goede 
Signed-off-by: Dmitry Torokhov 
Signed-off-by: Zefan Li

Input: alps - ignore potential bare packets when device is out of sync

2015-02-02T09:05:18+00:00

commit 4ab8f7f320f91f279c3f06a9795cfea5c972888a upstream.

5th and 6th byte of ALPS trackstick V3 protocol match condition for first
byte of PS/2 3 bytes packet. When driver enters out of sync state and ALPS
trackstick is sending data then driver match 5th, 6th and next 1st bytes as
PS/2.

It basically means if user is using trackstick when driver is in out of
sync state driver will never resync. Processing these bytes as 3 bytes PS/2
data cause total mess (random cursor movements, random clicks) and make
trackstick unusable until psmouse driver decide to do full device reset.

Lot of users reported problems with ALPS devices on Dell Latitude E6440,
E6540 and E7440 laptops. ALPS device or Dell EC for unknown reason send
some invalid ALPS PS/2 bytes which cause driver out of sync. It looks like
that i8042 and psmouse/alps driver always receive group of 6 bytes packets
so there are no missing bytes and no bytes were inserted between valid
ones.

This patch does not fix root of problem with ALPS devices found in Dell
Latitude laptops but it does not allow to process some (invalid)
subsequence of 6 bytes ALPS packets as 3 bytes PS/2 when driver is out of
sync.

So with this patch trackstick input device does not report bogus data when
also driver is out of sync, so trackstick should be usable on those
machines.

Signed-off-by: Pali Rohár 
Tested-by: Pali Rohár 
Reviewed-by: Hans de Goede 
Signed-off-by: Dmitry Torokhov 
Signed-off-by: Zefan Li

Input: ALPS - fix touchpad detection when buttons are pressed

2012-02-24T08:46:45+00:00

ALPS touchpad detection fails if some buttons of ALPS are pressed.
The reason is that the "E6" query response byte is different from
what is expected.

This was tested on a Toshiba Portege R500.

Cc: stable 
Signed-off-by: Akio Idehara 
Tested-by: Seth Forshee 
Signed-off-by: Dmitry Torokhov

Input: ALPS - add semi-MT support for v3 protocol

2011-11-08T06:22:11+00:00

Signed-off-by: Seth Forshee 
Acked-by: Chase Douglas 
Signed-off-by: Dmitry Torokhov

Input: ALPS - add support for protocol versions 3 and 4

2011-11-08T06:22:11+00:00

This patch adds support for two ALPS touchpad protocols not
supported currently by the driver, which I am arbitrarily naming
version 3 and version 4. Support is single-touch only at this time,
although both protocols are capable of limited multitouch support.

Thanks to Andrew Skalski, who did the initial reverse-engineering
of the v3 protocol.

Signed-off-by: Seth Forshee 
Acked-by: Chase Douglas 
Signed-off-by: Dmitry Torokhov

Input: ALPS - remove assumptions about packet size

2011-11-08T06:22:10+00:00

In preparation for version 4 protocol support, which has 8-byte
data packets, remove all hard-coded assumptions about packet size
and use psmouse->pktsize instead.

Signed-off-by: Seth Forshee 
Acked-by: Chase Douglas 
Signed-off-by: Dmitry Torokhov

Input: ALPS - add protocol version field in alps_model_info

2011-11-08T06:22:10+00:00

In preparation for adding support for more ALPS protocol versions,
add a field for the protocol version to the model info instead of
using a field in the flags. OLDPROTO and !OLDPROTO are now called
version 1 and version 2, repsectively.

Signed-off-by: Seth Forshee 
Acked-by: Chase Douglas 
Signed-off-by: Dmitry Torokhov

Input: ALPS - move protocol information to Documentation

2011-11-08T06:22:09+00:00

In preparation for new protocol support, move the protocol
information currently documented in alps.c to
Documentation/input/alps.txt, where it can be expanded without
cluttering up the driver.

Signed-off-by: Seth Forshee 
Acked-by: Chase Douglas 
Signed-off-by: Dmitry Torokhov

Input: psmouse - switch to using dev_*() for messages

2011-10-11T01:28:16+00:00

This will ensure our reporting is consistent with the rest of the system
and we do not refer to obsolete source file names.

Reviewed-by: Wanlong Gao 
Reviewed-by: JJ Ding 
Reviewed-by: Daniel Kurtz 
Signed-off-by: Dmitry Torokhov

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input

2010-05-05T14:53:18+00:00

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input:
  Input: joydev - allow binding to button-only devices
  Input: elantech - ignore high bits in the position coordinates
  Input: elantech - allow forcing Elantech protocol
  Input: elantech - fix firmware version check
  Input: ati_remote - add some missing devices from lirc_atiusb
  Input: eeti_ts - cancel pending work when going to suspend
  Input: Add support of Synaptics Clickpad device
  Revert "Input: ALPS - add signature for HP Pavilion dm3 laptops"
  Input: psmouse - ignore parity error for basic protocols