linux-stable.git/drivers/infiniband, branch v4.7.2

IB/core, RDMA RW API: Do not exceed QP SGE send limit

2016-08-20T16:11:02+00:00

commit 632bc3f65081dd1e2e5394a9161580a0f78e8839 upstream.

Compute the SGE limit for RDMA READ and WRITE requests in
ib_create_qp(). Use that limit in the RDMA RW API implementation.

Signed-off-by: Bart Van Assche 
Cc: Christoph Hellwig 
Cc: Sagi Grimberg 
Cc: Steve Wise 
Cc: Parav Pandit 
Cc: Nicholas Bellinger 
Cc: Laurence Oberman 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Doug Ledford 
Signed-off-by: Greg Kroah-Hartman

IB/core: Make rdma_rw_ctx_init() initialize all used fields

2016-08-20T16:11:02+00:00

commit eaa74ec7329a48a4b724d8de440b3a2cbaabf7c8 upstream.

Some but not all callers of rdma_rw_ctx_init() zero-initialize
struct rdma_rw_ctx. Hence make rdma_rw_ctx_init() initialize all
work request fields that will be read by ib_post_send().

Fixes: a060b5629ab0 ("IB/core: generic RDMA READ/WRITE API")
Signed-off-by: Bart Van Assche 
Reviewed-by: Sagi Grimberg 
Reviewed-by: Christoph Hellwig 
Tested-by: Steve Wise 
Tested-by: Laurence Oberman 
Cc: Parav Pandit 
Cc: Nicholas Bellinger 
Signed-off-by: Doug Ledford 
Signed-off-by: Greg Kroah-Hartman

IB/srpt: Limit the number of SG elements per work request

2016-08-20T16:11:02+00:00

commit 30c6d8773de06878f920666d8c945f81cb2081b3 upstream.

Limit the number of SG elements per work request to what the HCA
and the queue pair support.

Fixes: 34693573fde0 ("IB/srpt: Reduce QP buffer size")
Reported-by: Parav Pandit 
Signed-off-by: Bart Van Assche 
Cc: Christoph Hellwig 
Cc: Sagi Grimberg 
Cc: Steve Wise 
Cc: Parav Pandit 
Cc: Nicholas Bellinger 
Cc: Laurence Oberman 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Doug Ledford 
Signed-off-by: Greg Kroah-Hartman

IB/rdmavt: Add missing spin_lock_init call for rdi->n_cqs_lock

2016-08-20T16:11:02+00:00

commit a6580f4310ded039fc9f682cbf027fbba217652b upstream.

This fixes the following warning with PROV_LOCKING enabled kernel:

INFO: trying to register non-static key.
the code is fine but needs lockdep annotation.
turning off the locking correctness validator.
CPU: 15 PID: 12286 Comm: modprobe Not tainted 4.7.0-rc5.prove_rcu+ #1
Hardware name: Intel Corporation S2600WT2R/S2600WT2R,
......
Call Trace:
[] dump_stack+0x85/0xc8
[] register_lock_class+0x415/0x4b0
[] ? __lock_acquire+0x40c/0x1960
[] __lock_acquire+0x99/0x1960
[] ? find_vmap_area+0x42/0x60
[] ? find_vmap_area+0x19/0x60
[] lock_acquire+0xd3/0x200
[] ? rvt_create_cq+0xc8/0x250 [rdmavt]
[] _raw_spin_lock+0x31/0x40
[] ? rvt_create_cq+0xc8/0x250 [rdmavt]
[] rvt_create_cq+0xc8/0x250 [rdmavt]
[] ? static_obj+0x36/0x50
[] ib_alloc_cq+0x49/0x180 [ib_core]
[] ib_mad_init_device+0x204/0x6d0 [ib_core]
[] ? up_write+0x1f/0x40
[] ib_register_device+0x3d0/0x510 [ib_core]
[] ? read_cc_setting_bin+0x200/0x200 [hfi1]
[] ? static_obj+0x36/0x50
[] ? lockdep_init_map+0x88/0x200
[] rvt_register_device+0x17f/0x320 [rdmavt]
[] hfi1_register_ib_device+0x6ca/0x7c0 [hfi1]
[] init_one+0x2b4/0x430 [hfi1]
[] local_pci_probe+0x45/0xa0
[] ? pci_match_device+0xe0/0x110
[] pci_device_probe+0xfc/0x140
[] driver_probe_device+0x239/0x460
[] __driver_attach+0xcd/0xf0
[] ? driver_probe_device+0x460/0x460
[] bus_for_each_dev+0x73/0xc0
[] driver_attach+0x1e/0x20
[] bus_add_driver+0x1d3/0x290
[] ? dev_init+0x114/0x114 [hfi1]
[] driver_register+0x60/0xe0
[] ? dev_init+0x114/0x114 [hfi1]
[] __pci_register_driver+0x60/0x70
[] hfi1_mod_init+0x196/0x1fe [hfi1]
[] do_one_initcall+0x50/0x190
[] ? rcu_read_lock_sched_held+0x62/0x70
[] ? kmem_cache_alloc_trace+0x23a/0x2a0
[] ? do_init_module+0x27/0x1dc
[] do_init_module+0x60/0x1dc
[] load_module+0x132c/0x1ac0
[] ? __symbol_put+0x60/0x60
[] ? ima_post_read_file+0x3d/0x80

Reviewed-by: Mike Marciniszyn 
Signed-off-by: Jianxin Xiong 
Signed-off-by: Dennis Dalessandro 
Signed-off-by: Doug Ledford 
Signed-off-by: Greg Kroah-Hartman

IB/rdmavt: Disable by default

2016-08-20T16:11:02+00:00

commit 378fc3201eae07ab0fa7fb4133da141c3072f995 upstream.

There is a strict policy in the Linux kernel that new drivers must be
disabled by default. Hence leave out the "default m" line from Kconfig.

Fixes: 0194621b2253 ("IB/rdmavt: Create module framework and handle driver registration")
Signed-off-by: Bart Van Assche 
Cc: Jubin John 
Cc: Dennis Dalessandro 
Cc: Ira Weiny 
Cc: Mike Marciniszyn 
Signed-off-by: Doug Ledford 
Signed-off-by: Greg Kroah-Hartman

IB/mlx5: Fix iteration overrun in GSI qps

2016-08-20T16:11:01+00:00

commit b0ffeb537f3a726931d962ab6d03e34a2f070ea4 upstream.

Number of outstanding_pi may overflow and as a result may indicate that
there are no elements in the queue. The effect of doing this is that the
MAD layer will get stuck waiting for completions. The MAD layer will
think that the QP is full - because it didn't receive these completions.

This fix changes it so the outstanding_pi number is increased
with 32-bit wraparound and is not limited to max_send_wr so
that the difference between outstanding_pi and outstanding_ci will
really indicate the number of outstanding completions.

Fixes: ea6dc2036224 ('IB/mlx5: Reorder GSI completions')
Signed-off-by: Slava Shwartsman 
Signed-off-by: Leon Romanovsky 
Reviewed-by: Haggai Eran 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Doug Ledford 
Signed-off-by: Greg Kroah-Hartman

IB/hfi1: Disable by default

2016-08-16T07:34:58+00:00

commit a154a8cd080b437969ef194dee365bbb60a3b38a upstream.

There is a strict policy in the Linux kernel that new drivers must be
disabled by default. Hence leave out the "default m" line from Kconfig.

Fixes: f48ad614c100 ("IB/hfi1: Move driver out of staging")
Signed-off-by: Bart Van Assche 
Cc: Jubin John 
Cc: Dennis Dalessandro 
Cc: Ira Weiny 
Cc: Mike Marciniszyn 
Acked-by: Dennis Dalessandro 
Signed-off-by: Doug Ledford 
Signed-off-by: Greg Kroah-Hartman

i40iw: Enable remote access rights for stag allocation

2016-07-12T14:46:34+00:00

Fix to enable remote access rights when allocating stag.

Fixes: b7aee855d3b9 ("RDMA/i40iw: Add base memory management extensions")
Signed-off-by: Shiraz Saleem 
Signed-off-by: Doug Ledford

i40iw: do not print unitialized variables in error message

2016-07-12T14:46:34+00:00

i40iw_create_cqp() printed the contents of variables maj_err and min_err
in an error message before they could be initialized (by calling
dev->cqp_ops->cqp_create).

Signed-off-by: Nicolas Iooss 
Signed-off-by: Doug Ledford

IB core: Add port_xmit_wait counter

2016-07-12T14:46:24+00:00

Add the missing port_xmit_wait counter. This counter is displayed through
some tools like perfquery but is not available via sysfs.

For the PORT_PMA_ATTR macro the _counter field is set to zero
allowing us to specify the offset directly like with PORT_PMA_ATTR_EXT

See also the earlier work in 2008 by Vladimir Skolovsky

https://www.mail-archive.com/general@lists.openfabrics.org/msg20313.html

Signed-off-by: Vladimir Sokolvsky 
Signed-off-by: Christoph Lameter 
Signed-off-by: Doug Ledford