linux-stable.git/drivers/infiniband, branch v3.5.3 Linux kernel stable tree IB/srp: Fix a race condition 2012-08-26T02:31:45+00:00 Bart Van Assche bvanassche@acm.org 2012-08-14T13:18:53+00:00 16ff8d53da93e20c57e88067a254d3106b7aed5f commit 220329916c72ee3d54ae7262b215a050f04a18fc upstream. Avoid a crash caused by the scmnd->scsi_done(scmnd) call in srp_process_rsp() being invoked with scsi_done == NULL. This can happen if a reply is received during or after a command abort. Reported-by: Joseph Glanville <joseph.glanville@orionvm.com.au> Reference: http://marc.info/?l=linux-rdma&m=134314367801595 Acked-by: David Dillow <dillowda@ornl.gov> Signed-off-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Roland Dreier <roland@purestorage.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
commit 220329916c72ee3d54ae7262b215a050f04a18fc upstream.

Avoid a crash caused by the scmnd->scsi_done(scmnd) call in
srp_process_rsp() being invoked with scsi_done == NULL.  This can
happen if a reply is received during or after a command abort.

Reported-by: Joseph Glanville <joseph.glanville@orionvm.com.au>
Reference: http://marc.info/?l=linux-rdma&m=134314367801595
Acked-by: David Dillow <dillowda@ornl.gov>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
IPoIB: fix skb truesize underestimatiom 2012-07-11T06:33:12+00:00 Eric Dumazet edumazet@google.com 2012-07-10T10:03:41+00:00 b28ba72665356438e3a6e3be365c3c3071496840 Or Gerlitz reported triggering of WARN_ON_ONCE(delta < len); in skb_try_coalesce() This warning tracks drivers that incorrectly set skb->truesize IPoIB indeed allocates a full page to store a fragment, but only accounts in skb->truesize the used part of the page (frame length) This patch fixes skb truesize underestimation, and also fixes a performance issue, because RX skbs have not enough tailroom to allow IP and TCP stacks to pull their header in skb linear part without an expensive call to pskb_expand_head() Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: Or Gerlitz <ogerlitz@mellanox.com> Cc: Erez Shitrit <erezsh@mellanox.com> Cc: Shlomo Pongartz <shlomop@mellanox.com> Cc: Roland Dreier <roland@purestorage.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Or Gerlitz reported triggering of WARN_ON_ONCE(delta < len); in
skb_try_coalesce()
This warning tracks drivers that incorrectly set skb->truesize

IPoIB indeed allocates a full page to store a fragment, but only
accounts in skb->truesize the used part of the page (frame length)

This patch fixes skb truesize underestimation, and
also fixes a performance issue, because RX skbs have not enough tailroom
to allow IP and TCP stacks to pull their header in skb linear part
without an expensive call to pskb_expand_head()

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Or Gerlitz <ogerlitz@mellanox.com>
Cc: Erez Shitrit <erezsh@mellanox.com>
Cc: Shlomo Pongartz <shlomop@mellanox.com>
Cc: Roland Dreier <roland@purestorage.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Merge branches 'cma' and 'ocrdma' into for-linus 2012-06-24T11:59:59+00:00 Roland Dreier roland@purestorage.com 2012-06-24T11:59:59+00:00 2e51fd3c13e330d9364a211ddcd3e38771eeb4b4 






RDMA/cma: QP type check on received REQs should be AND not OR
2012-06-20T03:04:04+00:00

Sean Hefty
sean.hefty@intel.com

2012-06-14T20:49:09+00:00

4dd81e895655c59bd19d7a8f03a5de1310f4aeb6

Change || check to the intended && when checking the QP type in a
received connection request against the listening endpoint.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>





Change || check to the intended && when checking the QP type in a
received connection request against the listening endpoint.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>







RDMA/ocrdma: Fix off by one in ocrdma_query_gid()
2012-06-14T20:30:41+00:00

Dan Carpenter
dan.carpenter@oracle.com

2012-06-14T18:36:09+00:00

7b33dc2b050b71de0e202885a26caffbc864d072

The dev->sgid_tbl[] array is allocated in ocrdma_alloc_resources().
It has OCRDMA_MAX_SGID elements so the test here is off by one.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>





The dev->sgid_tbl[] array is allocated in ocrdma_alloc_resources().
It has OCRDMA_MAX_SGID elements so the test here is off by one.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>







RDMA/ocrdma: Fixed RQ error CQE polling
2012-06-11T16:38:36+00:00

Parav Pandit
parav.pandit@emulex.com

2012-06-11T11:09:20+00:00

a3698a9b919d2a54e3348be48ab65d102b2f105d

Fix RQ/SRQ error CQE polling.  Return error CQE to consumer for error
case which was not returned previously.

Signed-off-by: Parav Pandit <parav.pandit@emulex.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>





Fix RQ/SRQ error CQE polling.  Return error CQE to consumer for error
case which was not returned previously.

Signed-off-by: Parav Pandit <parav.pandit@emulex.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>







RDMA/ocrdma: Correct queue SGE calculation
2012-06-11T16:38:35+00:00

Mahesh Vardhamanaiah
mahesh.vardhamanaiah@emulex.com

2012-06-08T15:56:11+00:00

634c5796a5c60964faf9d51892571ffe36ad24d5

Fix max sge calculation for sq, rq, srq for all hardware types.

Signed-off-by: Mahesh Vardhamanaiah <mahesh.vardhamanaiah@emulex.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>





Fix max sge calculation for sq, rq, srq for all hardware types.

Signed-off-by: Mahesh Vardhamanaiah <mahesh.vardhamanaiah@emulex.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>







RDMA/ocrdma: Correct reported max queue sizes
2012-06-11T16:38:34+00:00

Mahesh Vardhamanaiah
mahesh.vardhamanaiah@emulex.com

2012-06-08T15:55:52+00:00

07bb54244e466f1517357f47a498574f97c31e08

Fix code to read the max wqe and max rqe values from mailbox response.

Signed-off-by: Mahesh Vardhamanaiah <mahesh.vardhamanaiah@emulex.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>





Fix code to read the max wqe and max rqe values from mailbox response.

Signed-off-by: Mahesh Vardhamanaiah <mahesh.vardhamanaiah@emulex.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>







RDMA/ocrdma: Fixed GID table for vlan and events
2012-06-11T16:38:32+00:00

Parav Pandit
parav.pandit@emulex.com

2012-06-08T15:55:25+00:00

6ab6827ee99937834cc268298ee4eab1a651569e

1. Fix reporting GID table addition events.
2. Enable vlan based GID entries only when VLAN is enabled at compile
   time (test CONFIG_VLAN_8021Q / CONFIG_VLAN_8021Q_MODULE).

Signed-off-by: Parav Pandit <parav.pandit@emulex.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>





1. Fix reporting GID table addition events.
2. Enable vlan based GID entries only when VLAN is enabled at compile
   time (test CONFIG_VLAN_8021Q / CONFIG_VLAN_8021Q_MODULE).

Signed-off-by: Parav Pandit <parav.pandit@emulex.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>







Merge branches 'cxgb4', 'mlx4' and 'ocrdma' into for-linus
2012-06-06T17:08:11+00:00

Roland Dreier
roland@purestorage.com

2012-06-06T17:08:11+00:00

20952cdd8e79945245be29f8f5ecac5abc99b4ae