linux-stable.git/drivers/infiniband/ulp, branch v4.13.7

Revert "IB/ipoib: Update broadcast object if PKey value was changed in index 0"

2017-10-05T07:47:30+00:00

commit 612601d0013f03de9dc134809f242ba6da9ca252 upstream.

commit 9a9b8112699d will cause core to fail UD QP from being destroyed
on ipoib unload, therefore cause resources leakage.
On pkey change event above patch modifies mgid before calling underlying
driver to detach it from QP. Drivers' detach_mcast() will fail to find
modified mgid it was never given to attach in a first place.
Core qp->usecnt will never go down, so ib_destroy_qp() will fail.

IPoIB driver actually does take care of new broadcast mgid based on new
pkey by destroying an old mcast object in ipoib_mcast_dev_flush())
....
	if (priv->broadcast) {
		rb_erase(&priv->broadcast->rb_node, &priv->multicast_tree);
		list_add_tail(&priv->broadcast->list, &remove_list);
		priv->broadcast = NULL;
	}
...

then in restarted ipoib_macst_join_task() creating a new broadcast mcast
object, sending join request and on completion tells the driver to attach
to reinitialized QP:
...
if (!priv->broadcast) {
...
	broadcast = ipoib_mcast_alloc(dev, 0);
...
	memcpy(broadcast->mcmember.mgid.raw, priv->dev->broadcast + 4,
	       sizeof (union ib_gid));
	priv->broadcast = broadcast;
...

Fixes: 9a9b8112699d ("IB/ipoib: Update broadcast object if PKey value was changed in index 0")
Reviewed-by: Mike Marciniszyn 
Reviewed-by: Dennis Dalessandro 
Signed-off-by: Alex Estrin 
Signed-off-by: Dennis Dalessandro 
Reviewed-by: Feras Daoud 
Signed-off-by: Doug Ledford 
Signed-off-by: Greg Kroah-Hartman

IB/ipoib: Notify on modify QP failure only when relevant

2017-07-23T07:52:00+00:00

Modify QP can fail and it can be acceptable, like when moving from RST to
ERR state, all the rest are not acceptable and a message to the log
should be printed.

The current code prints on all failures and many messages like:
"Failed to modify QP to ERROR state" appear, even when supported by the
state machine of the QP object.

Signed-off-by: Erez Shitrit 
Signed-off-by: Leon Romanovsky

IB/ipoib: Remove double pointer assigning

2017-07-23T07:00:15+00:00

There is no need to assign "p" pointer twice.

This patch fixes the following smatch warning:
drivers/infiniband/ulp/ipoib/ipoib_cm.c:517 ipoib_cm_rx_handler() warn:
	missing break? reassigning 'p->id'

Fixes: 839fcaba355a ("IPoIB: Connected mode experimental support")
Signed-off-by: Leon Romanovsky

IB/ipoib: Clean error paths in add port

2017-07-23T06:45:11+00:00

Refactor error paths in ipoib_add_port() function. The code flow
ensures that the function terminates on every error flow and it makes
redundant all "else" cases.

The functions are called during the flow are returning "result < 0", in
case of error, so there is no need to check it explicitly.

Fixes: 58e9cc90cda7 ("IB/IPoIB: Fix bad error flow in ipoib_add_port()")
Signed-off-by: Leon Romanovsky

IB/ipoib: Add get statistics support to SRIOV VF

2017-07-23T06:45:11+00:00

Add SRIOV VF support to get traffic statistics.

Signed-off-by: Feras Daoud 
Signed-off-by: Leon Romanovsky

IB/ipoib: Add multicast packets statistics

2017-07-23T06:45:11+00:00

Update the multicast counter when multicast packets are received and
provide this information through ethtool support.

Signed-off-by: Alex Vesker 
Signed-off-by: Leon Romanovsky

IB/ipoib: Set IPOIB_NEIGH_TBL_FLUSH after flushed completion initialization

2017-07-23T06:45:11+00:00

Set IPOIB_NEIGH_TBL_FLUSH bit after initializing the neighbor
flushed completion, otherwise the garbage collector may signal
a completion while it is not initialized yet.

Fixes: b63b70d87741 ("IPoIB: Use a private hash table for path lookup in xmit path")
Signed-off-by: Feras Daoud 
Signed-off-by: Alex Vesker 
Signed-off-by: Leon Romanovsky

IB/ipoib: Prevent setting negative values to max_nonsrq_conn_qp

2017-07-23T06:45:11+00:00

Don't allow negative values to max_nonsrq_conn_qp. There is no functional
impact on a negative value but it is logicically incorrect.

Fixes: 68e995a29572 ("IPoIB/cm: Add connected mode support for devices without SRQs")
Signed-off-by: Alex Vesker 
Signed-off-by: Leon Romanovsky

IB/ipoib: Make sure no in-flight joins while leaving that mcast

2017-07-23T06:45:11+00:00

While cleaning neighs and there is a send-only mcast neigh, the driver
should wait to finish its join process before trying to remove it.

Without this patch, we will see messages like: "ipoib_mcast_leave on an
in-flight join" and unexpected results in the join_complete.

Signed-off-by: Erez Shitrit 
Signed-off-by: Leon Romanovsky

IB/ipoib: Use cancel_delayed_work_sync when needed

2017-07-23T06:45:11+00:00

The work mcast_task can re-queue itself, so instead of doing
cancel && flush_workqueue, that still can leave a queued task
on the air, use cancel_delayed_work_sync.

Also, no need to use lock over the cancel, the original lock was
due to bit assignment setting (IPOIB_MCAST_RUN) that is not in use
anymore.

Signed-off-by: Erez Shitrit 
Signed-off-by: Leon Romanovsky