linux-stable.git/drivers/infiniband/ulp, branch linux-5.17.y

RDMA/rtrs-clt: Do stop and failover outside reconnect work.

2022-04-13T17:27:10+00:00

[ Upstream commit c1289d5d8502d62e5bc50ff066c9d6daabfc3264 ]

We can't do instant reconnect, not to DDoS server, but we should stop and
failover earlier, so there is less service interruption.

To avoid deadlock, as error_recovery is called from different callback
like rdma event or hb error handler, add a new err recovery_work.

Link: https://lore.kernel.org/r/20220114154753.983568-6-haris.iqbal@ionos.com
Signed-off-by: Jack Wang 
Reviewed-by: Aleksei Marov 
Reviewed-by: Md Haris Iqbal 
Signed-off-by: Md Haris Iqbal 
Signed-off-by: Jason Gunthorpe 
Signed-off-by: Sasha Levin

RDMA/ib_srp: Fix a deadlock

2022-02-23T19:03:58+00:00

Remove the flush_workqueue(system_long_wq) call since flushing
system_long_wq is deadlock-prone and since that call is redundant with a
preceding cancel_work_sync()

Link: https://lore.kernel.org/r/20220215210511.28303-3-bvanassche@acm.org
Fixes: ef6c49d87c34 ("IB/srp: Eliminate state SRP_TARGET_DEAD")
Reported-by: syzbot+831661966588c802aae9@syzkaller.appspotmail.com
Signed-off-by: Bart Van Assche 
Reviewed-by: Leon Romanovsky 
Signed-off-by: Jason Gunthorpe

RDMA/rtrs-clt: Move free_permit from free_clt to rtrs_clt_close

2022-02-18T15:59:33+00:00

Error path of rtrs_clt_open() calls free_clt(), where free_permit is
called.  This is wrong since error path of rtrs_clt_open() does not need
to call free_permit().

Also, moving free_permits() call to rtrs_clt_close(), makes it more
aligned with the call to alloc_permit() in rtrs_clt_open().

Fixes: 6a98d71daea1 ("RDMA/rtrs: client: main functionality")
Link: https://lore.kernel.org/r/20220217030929.323849-2-haris.iqbal@ionos.com
Signed-off-by: Md Haris Iqbal 
Reviewed-by: Jack Wang 
Signed-off-by: Jason Gunthorpe

RDMA/rtrs-clt: Fix possible double free in error case

2022-02-18T15:59:33+00:00

Callback function rtrs_clt_dev_release() for put_device() calls kfree(clt)
to free memory. We shouldn't call kfree(clt) again, and we can't use the
clt after kfree too.

Replace device_register() with device_initialize() and device_add() so that
dev_set_name can() be used appropriately.

Move mutex_destroy() to the release function so it can be called in
the alloc_clt err path.

Fixes: eab098246625 ("RDMA/rtrs-clt: Refactor the failure cases in alloc_clt")
Link: https://lore.kernel.org/r/20220217030929.323849-1-haris.iqbal@ionos.com
Reported-by: Miaoqian Lin 
Signed-off-by: Md Haris Iqbal 
Reviewed-by: Jack Wang 
Signed-off-by: Jason Gunthorpe

RDMA/rtrs-clt: Rename rtrs_clt to rtrs_clt_sess

2022-01-07T14:07:31+00:00

Structure rtrs_clt is used for sessions. So to avoid confusions rename it
to rtrs_clt_sess.

Transformations are done with the help of following coccinelle script.

@@
@@
struct
- rtrs_clt
+ rtrs_clt_sess

Link: https://lore.kernel.org/r/20220105180708.7774-6-jinpu.wang@ionos.com
Signed-off-by: Vaishali Thakkar 
Signed-off-by: Jack Wang 
Signed-off-by: Jason Gunthorpe

RDMA/rtrs-srv: Rename rtrs_srv to rtrs_srv_sess

2022-01-07T14:07:31+00:00

Structure rtrs_srv is used for sessions so in order to avoid confusions
rename it to rtrs_srv_sess.

All changes were done with the help of following Coccinelle script:

@@
@@
struct
- rtrs_srv
+ rtrs_srv_sess

Link: https://lore.kernel.org/r/20220105180708.7774-5-jinpu.wang@ionos.com
Signed-off-by: Vaishali Thakkar 
Signed-off-by: Jack Wang 
Signed-off-by: Jason Gunthorpe

RDMA/rtrs-clt: Rename rtrs_clt_sess to rtrs_clt_path

2022-01-07T14:07:31+00:00

rtrs_clt_sess is used for paths and not sessions on the client side. This
creates confusion so let's rename it to rtrs_clt_path. Also, rename
related variables and functions.

Coccinelle is used to do the transformations for most of the occurrences
and remaining ones were handled manually.

Link: https://lore.kernel.org/r/20220105180708.7774-4-jinpu.wang@ionos.com
Signed-off-by: Vaishali Thakkar 
Signed-off-by: Jack Wang 
Signed-off-by: Jason Gunthorpe

RDMA/rtrs-srv: Rename rtrs_srv_sess to rtrs_srv_path

2022-01-07T14:07:31+00:00

rtrs_srv_sess is used for paths and not sessions on the server side. This
creates confusion so let's rename it to rtrs_srv_path. Also, rename
related variables and functions.

Coccinelle is used to do the transformations for most of the occurrences
and remaining ones were handled manually.

Link: https://lore.kernel.org/r/20220105180708.7774-3-jinpu.wang@ionos.com
Signed-off-by: Vaishali Thakkar 
Signed-off-by: Jack Wang 
Signed-off-by: Jason Gunthorpe

RDMA/rtrs: Rename rtrs_sess to rtrs_path

2022-01-07T14:07:30+00:00

rtrs_sess is in fact a path. This makes it confusing and difficult to get
into the code. So let's rename the structure and related use cases of it.

Coccinelle was used to do the transformation for most of the occurrences
and remaining ones were handled manually.

Link: https://lore.kernel.org/r/20220105180708.7774-2-jinpu.wang@ionos.com
Signed-off-by: Vaishali Thakkar 
Signed-off-by: Jack Wang 
Signed-off-by: Jason Gunthorpe

IB/iser: Align coding style across driver

2022-01-06T17:47:08+00:00

The following changes were made:
1. Align function signatures to 80 characters per line.
2. Remove tabs for variable assignment and use 1 space instead.
3. Don't compare to NULL in "if" clause.
4. Remove strange indentations.

This will ease on the maintenance of the driver for the future.

Link: https://lore.kernel.org/r/20211215135721.3662-7-mgurtovoy@nvidia.com
Signed-off-by: Max Gurtovoy 
Signed-off-by: Jason Gunthorpe