linux-stable.git/drivers/infiniband/ulp/iser, branch linux-4.15.y

Merge branch 'for-next-early' into for-next

2017-10-18T17:07:13+00:00

The early for-next branch was based on v4.14-rc2, while the shared pull
request I got from Mellanox used a v4.14-rc4 base.  I'm making the
branch that was the shared Mellanox pull request the new for-next branch
and merging the early for-next branch into it.

Signed-off-by: Doug Ledford

IB/{ipoib, iser}: Consistent print format of vendor error

2017-09-29T15:18:56+00:00

Vendor error print should be consistent across protocols to avoid any
confusion.
This patch corrects that.

Suggested-by: Santosh Shilimkar 
Signed-off-by: Ajaykumar Hotchandani 
Reviewed-by: Santosh Shilimkar 
Acked-by: Wengang Wang 
Reviewed-by: Yuval Shaia 
Signed-off-by: Yuval Shaia 
Acked-by: Sagi Grimberg 
Acked-by: Roi Dayan 
Signed-off-by: Doug Ledford

IB: Correct MR length field to be 64-bit

2017-09-25T15:47:23+00:00

The ib_mr->length represents the length of the MR in bytes as per
the IBTA spec 1.3 section 11.2.10.3 (REGISTER PHYSICAL MEMORY REGION).

Currently ib_mr->length field is defined as only 32-bits field.
This might result into truncation and failed WRs of consumers who
registers more than 4GB bytes memory regions and whose WRs accessing
such MRs.

This patch makes the length 64-bit to avoid such truncation.

Cc: Sagi Grimberg 
Cc: Chuck Lever 
Cc: Faisal Latif 
Fixes: 4c67e2bfc8b7 ("IB/core: Introduce new fast registration API")
Signed-off-by: Ilya Lesokhin 
Signed-off-by: Parav Pandit 
Signed-off-by: Leon Romanovsky 
Signed-off-by: Doug Ledford

RDMA/(core, ulp): Convert register/unregister event handler to be void

2017-08-24T20:27:10+00:00

The functions ib_register_event_handler() and
ib_unregister_event_handler() always returned success and they can't fail.

Let's convert those functions to be void, remove redundant checks and
cleanup tons of goto statements.

Signed-off-by: Leon Romanovsky 
Reviewed-by: Dennis Dalessandro 
Signed-off-by: Doug Ledford

RDMA: Remove useless MODULE_VERSION

2017-07-24T12:45:11+00:00

All modules in drivers/infiniband defined and used MODULE_VERSION, which
was pointless because the kernel version describes their state more accurate
then those arbitrary numbers.

Signed-off-by: Leon Romanovsky 
Acked-by: Sagi Grimbrg 
Reviewed-by: Sagi Grimberg 
Acked-by: Dennis Dalessandro 
Reviewed-by: Dennis Dalessandro 
Acked-by: Selvin Xavier 
Acked-by: Ram Amrani 
Reviewed-by: Johannes Thumshirn 
Acked-by: Adit Ranadive 
Signed-off-by: Doug Ledford

RDMA/iser: don't send an rkey if all data is written as immadiate-data

2017-07-20T15:20:50+00:00

We might get some bogus error completions in case the target will
remotely invalidate the rkey and the HCA will need to retransmit
from this buffer.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Doug Ledford

IB/iser: Fix connection teardown race condition

2017-07-17T15:45:25+00:00

Under heavy iser target(scst) start/stop stress during login/logout
on iser intitiator side happened trace call provided below.

The function iscsi_iser_slave_alloc iser_conn pointer could be NULL,
due to the fact that function iscsi_iser_conn_stop can be called before
and free iser connection. Let's protect that flow by introducing global mutex.

BUG: unable to handle kernel paging request at 0000000000001018
IP: [] iscsi_iser_slave_alloc+0x1e/0x50 [ib_iser]
Call Trace:
? scsi_alloc_sdev+0x242/0x300
scsi_probe_and_add_lun+0x9e1/0xea0
? kfree_const+0x21/0x30
? kobject_set_name_vargs+0x76/0x90
? __pm_runtime_resume+0x5b/0x70
__scsi_scan_target+0xf6/0x250
scsi_scan_target+0xea/0x100
iscsi_user_scan_session.part.13+0x101/0x130 [scsi_transport_iscsi]
? iscsi_user_scan_session.part.13+0x130/0x130 [scsi_transport_iscsi]
iscsi_user_scan_session+0x1e/0x30 [scsi_transport_iscsi]
device_for_each_child+0x50/0x90
iscsi_user_scan+0x44/0x60 [scsi_transport_iscsi]
store_scan+0xa8/0x100
? common_file_perm+0x5d/0x1c0
dev_attr_store+0x18/0x30
sysfs_kf_write+0x37/0x40
kernfs_fop_write+0x12c/0x1c0
__vfs_write+0x18/0x40
vfs_write+0xb5/0x1a0
SyS_write+0x55/0xc0

Fixes: 318d311e8f01 ("iser: Accept arbitrary sg lists mapping if the device supports it")
Cc:  # v4.5+
Signed-off-by: Vladimir Neyelov 
Signed-off-by: Leon Romanovsky 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Doug Ledford

IB/iser: Handle lack of memory management extentions correctly

2017-07-11T14:47:16+00:00

max_fast_reg_page_list_len is only valid when the
memory management extentions are signaled by the underlying
driver.

Fix by adjusting iser_calc_scsi_params() to use
ISCSI_ISER_MAX_SG_TABLESIZE when the extentions are not indicated.

Reported-by: Thomas Rosenstein 
Fixes: Commit df749cdc45d9 ("IB/iser: Support up to 8MB data transfer in a single command")
Reviewed-by: Dennis Dalessandro 
Signed-off-by: Mike Marciniszyn 
Acked-by: Sagi Grimberg 
Tested-by: Thomas Rosenstein 
Signed-off-by: Doug Ledford

IB/iser: fix spelling mistake: "unexepected" -> "unexpected"

2017-04-25T18:06:49+00:00

trivial fix to spelling mistake in iser_err error message

Signed-off-by: Colin Ian King 
Reviewed-by: Max Gurtovoy 
Acked-by: Sagi Grimberg 
Signed-off-by: Doug Ledford

RDMA/iser: Fix possible mr leak on device removal event

2017-03-25T02:31:19+00:00

When the rdma device is removed, we must cleanup all
the rdma resources within the DEVICE_REMOVAL event
handler to let the device teardown gracefully. When
this happens with live I/O, some memory regions are
occupied. Thus, track them too and dereg all the mr's.

We are safe with mr access by iscsi_iser_cleanup_task.

Reported-by: Raju Rangoju 
Signed-off-by: Sagi Grimberg 
Reviewed-by: Max Gurtovoy 
Reviewed-by: Max Gurtovoy 
Signed-off-by: Doug Ledford