linux-stable.git/drivers/infiniband/ulp/iser, branch linux-3.19.y

IB/iser: Fix wrong calculation of protection buffer length

2015-05-06T20:02:00+00:00

commit a065fe6aa25ba6ba93c02dc13486131bb3c64d5f upstream.

This length miss-calculation may cause a silent data corruption
in the DIX case and cause the device to reference unmapped area.

Fixes: d77e65350f2d ('libiscsi, iser: Adjust data_length to include protection information')
Signed-off-by: Sagi Grimberg 
Signed-off-by: Doug Ledford 
Signed-off-by: Greg Kroah-Hartman

IB/iser: Use correct dma direction when unmapping SGs

2015-03-18T13:11:06+00:00

commit c6c95ef4cec680f7a10aa425a9970744b35b6489 upstream.

We always unmap SGs with the same direction instead of unmapping
with the direction the mapping was done, fix that.

Fixes: 9a8b08fad2ef ("IB/iser: Generalize iser_unmap_task_data and [...]")
Signed-off-by: Roi Dayan 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier 
Signed-off-by: Greg Kroah-Hartman

IB/iser: Fix memory regions possible leak

2015-03-18T13:11:06+00:00

commit 6606e6a2ff2710b473838b291dc533cd8fc1471f upstream.

When teardown process starts during live IO, we need to keep the
memory regions pool (frmr/fmr) until all in-flight tasks are properly
released, since each task may return a memory region to the pool. In
order to do this, we pass a destroy flag to iser_free_ib_conn_res to
indicate we can destroy the device and the memory regions
pool. iser_conn_release will pass it as true and also DEVICE_REMOVAL
event (we need to let the device to properly remove).

Also, Since we conditionally call iser_free_rx_descriptors,
remove the extra check on iser_conn->rx_descs.

Fixes: 5426b1711fd0 ("IB/iser: Collapse cleanup and disconnect handlers")
Reported-by: Or Gerlitz 
Signed-off-by: Sagi Grimberg 
Signed-off-by: Roland Dreier 
Signed-off-by: Greg Kroah-Hartman

IB/iser: Bump version to 1.5

2014-12-16T02:11:47+00:00

Signed-off-by: Sagi Grimberg 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier

IB/iser: DIX update

2014-12-16T02:11:46+00:00

Following few recent Block integrity updates, we align the iSER data
integrity offload settings with:

- Deprecate pi_guard module param
- Expose support for DIX type 0.
- Use scsi_transfer_length for the transfer length
- Get pi_interval, ref_tag, ref_remap, bg_type and
  check_mask setting from scsi_cmnd

Signed-off-by: Sagi Grimberg 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier

IB/iser: Micro-optimize iser_handle_wc

2014-12-16T02:11:46+00:00

Use likely() for wc.status == IB_WC_SUCCESS

Signed-off-by: Sagi Grimberg 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier

IB/iser: Micro-optimize iser logging

2014-12-16T02:11:46+00:00

And fix a checkpatch warning.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier

IB/iser: Use more completion queues

2014-12-16T02:11:45+00:00

No reason to settle with four, can use the min between device max comp
vectors and number of cores.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier

IB/iser: Remove redundant is_mr indicator

2014-12-16T02:11:45+00:00

It is enough to check mem_h pointer assignment, mem_h == NULL will
indicate that buffer is not registered using mr.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier

IB/iser: Centralize memory region invalidation to a function

2014-12-16T02:11:45+00:00

Eliminates code duplication.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier