linux-stable.git/drivers/infiniband/ulp/iser, branch linux-3.14.y

IB/iser: Fix use after free in iser_snd_completion()

2014-02-14T17:48:09+00:00

We use "tx_desc" again after we free it.

Signed-off-by: Dan Carpenter 
Acked-by: Or Gerlitz 
Signed-off-by: Roland Dreier

IB/iser: Avoid dereferencing iscsi_iser conn object when not bound to iser connection

2014-02-14T17:48:03+00:00

Fix a possible NULL pointer dereference in disconnection flow. This
can happen if the target disconnected/rejected the connection request,
e.g before the binding stage between iscsi connection to the transport
connection.

Signed-off-by: Alex Tabachnik 
Signed-off-by: Roi Dayan 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier

Merge tag 'rdma-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband

2013-09-05T16:39:27+00:00

Pull main batch of InfiniBand/RDMA changes from Roland Dreier:
 - Large ocrdma HW driver update: add "fast register" work requests,
   fixes, cleanups
 - Add receive flow steering support for raw QPs
 - Fix IPoIB neighbour race that leads to crash
 - iSER updates including support for using "fast register" memory
   registration
 - IPv6 support for iWARP
 - XRC transport fixes

* tag 'rdma-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband: (54 commits)
  RDMA/ocrdma: Fix compiler warning about int/pointer size mismatch
  IB/iser: Fix redundant pointer check in dealloc flow
  IB/iser: Fix possible memory leak in iser_create_frwr_pool()
  IB/qib: Move COUNTER_MASK definition within qib_mad.h header guards
  RDMA/ocrdma: Fix passing wrong opcode to modify_srq
  RDMA/ocrdma: Fill PVID in UMC case
  RDMA/ocrdma: Add ABI versioning support
  RDMA/ocrdma: Consider multiple SGES in case of DPP
  RDMA/ocrdma: Fix for displaying proper link speed
  RDMA/ocrdma: Increase STAG array size
  RDMA/ocrdma: Dont use PD 0 for userpace CQ DB
  RDMA/ocrdma: FRMA code cleanup
  RDMA/ocrdma: For ERX2 irrespective of Qid, num_posted offset is 24
  RDMA/ocrdma: Fix to work with even a single MSI-X vector
  RDMA/ocrdma: Remove the MTU check based on Ethernet MTU
  RDMA/ocrdma: Add support for fast register work requests (FRWR)
  RDMA/ocrdma: Create IRD queue fix
  IB/core: Better checking of userspace values for receive flow steering
  IB/mlx4: Add receive flow steering support
  IB/core: Export ib_create/destroy_flow through uverbs
  ...

IB/iser: Fix redundant pointer check in dealloc flow

2013-09-03T04:26:16+00:00

This bug was discovered by Smatch static checker run by Dan Carpenter.
If in free_rx_descriptors(), rx_descs are not NULL then the iser
device is definately not NULL, so no need to check it before
dereferencing it.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier

IB/iser: Fix possible memory leak in iser_create_frwr_pool()

2013-09-03T04:24:08+00:00

Fix leak where desc is not being freed in error flows.

Signed-off-by: Roi Dayan 
Signed-off-by: Sagi Grimberg 
Signed-off-by: Roland Dreier

[SCSI] IB/iser: Add Discovery support

2013-08-26T14:53:49+00:00

To run discovery over iSER we need to advertize the CAP_TEXT_NEGO capability
towards user space. Also need to make sure the login RX buffer is posted when
SendTargets TEXT PDUs are sent. For that end, we use a setting of the
ISCSI_PARAM_DISCOVERY_SESS iscsi param as an indication that this is
discovery session.

Signed-off-by: Or Gerlitz 
Reviewed-by: Mike Christie 
Signed-off-by: James Bottomley

IB/iser: Introduce fast memory registration model (FRWR)

2013-08-10T00:18:10+00:00

Newer HCAs and Virtual functions may not support FMRs but rather a fast
registration model, which we call FRWR - "Fast Registration Work Requests".

This model was introduced in 00f7ec36c ("RDMA/core: Add memory management
extensions support") and works when the IB device supports the
IB_DEVICE_MEM_MGT_EXTENSIONS capability.

Upon creating the iser device iser will test whether the HCA supports
FMRs.  If no support for FMRs, check if IB_DEVICE_MEM_MGT_EXTENSIONS
is supported and assign function pointers that handle fast
registration and allocation of appropriate resources (fast_reg
descriptors).

Registration is done using posting IB_WR_FAST_REG_MR to the QP and
invalidations using posting IB_WR_LOCAL_INV.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier

IB/iser: Place the fmr pool into a union in iser's IB conn struct

2013-08-10T00:18:09+00:00

This is preparation step for other memory registration methods to be
added.  In addition, change reg/unreg routines signature to indicate
they use FMRs.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier

IB/iser: Handle unaligned SG in separate function

2013-08-10T00:18:09+00:00

This routine will be shared with other rdma management schemes.  The
bounce buffer solution for unaligned SG-lists and the sg_to_page_vec
routine are likely to be used for other registration schemes and not
just FMR.

Move them out of the FMR specific code, and call them from there.
Later they will be called also from other reg methods code.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier

IB/iser: Generalize rdma memory registration

2013-08-10T00:18:09+00:00

Currently the driver uses FMRs as the only means to register the
memory pointed by SG provided by the SCSI mid-layer with the RDMA
device.

As preparation step for adding more methods for fast path memory
registration, make the alloc/free and reg/unreg calls function
pointers, which are for now just set to the existing FMR ones.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Or Gerlitz 
Signed-off-by: Roland Dreier