linux-stable.git/drivers/infiniband/ulp/ipoib, branch linux-4.3.y

IB/ipoib: For sendonly join free the multicast group on leave

2015-10-13T20:43:59+00:00

When we leave the multicast group on expiration of a neighbor we
do not free the mcast structure. This results in a memory leak
that causes ib_dealloc_pd to fail and print a WARN_ON message
and backtrace.

Fixes: bd99b2e05c4d (IB/ipoib: Expire sendonly multicast joins)
Signed-off-by: Christoph Lameter 
Tested-by: Sagi Grimberg 
Signed-off-by: Doug Ledford

IB/ipoib: increase the max mcast backlog queue

2015-09-26T02:30:24+00:00

When performing sendonly joins, we queue the packets that trigger
the join until the join completes.  This may take on the order of
hundreds of milliseconds.  It is easy to have many more than three
packets come in during that time.  Expand the maximum queue depth
in order to try and prevent dropped packets during the time it
takes to join the multicast group.

Signed-off-by: Doug Ledford

IB/ipoib: Make sendonly multicast joins create the mcast group

2015-09-25T18:46:58+00:00

Since IPoIB should, as much as possible, emulate how multicast
sends work on Ethernet for regular TCP/IP apps, there should be
no requirement to subscribe to a multicast group before your
sends are properly sent.  However, due to the difference in how
multicast is handled on InfiniBand, we must join the appropriate
multicast group before we can send to it.  Previously we tried
not to trigger the auto-create feature of the subnet manager when
doing this because we didn't have tracking of these sendonly
groups and the auto-creation might never get undone.  The previous
patch added timing to these sendonly joins and allows us to
leave them after a reasonable idle expiration time.  So supply
all of the information needed to auto-create group.

Signed-off-by: Doug Ledford

IB/ipoib: Expire sendonly multicast joins

2015-09-25T18:43:19+00:00

On neighbor expiration, check to see if the neighbor was actually a
sendonly multicast join, and if so, leave the multicast group as we
expire the neighbor.

Signed-off-by: Christoph Lameter 
Signed-off-by: Doug Ledford

IB/ipoib: Suppress warning for send only join failures

2015-09-03T21:11:05+00:00

We expect send only joins to fail, it just means there are no listeners
for the group. The correct thing to do is silently drop the packet
at source.

Eg avahi will full join 224.0.0.251 which causes a send only IGMP packet
to 224.0.0.22, and then a warning level kmessage like this:

 ib0: sendonly multicast join failed for ff12:401b:ffff:0000:0000:0000:0000:0016, status -22

If there is no IP router listening to IGMP.

Signed-off-by: Jason Gunthorpe 
Signed-off-by: Doug Ledford

IB/ipoib: Clean up send-only multicast joins

2015-09-03T21:05:58+00:00

Even though we don't expect the group to be created by the SM we
sill need to provide all the parameters to force the SM to validate
they are correct.

Signed-off-by: Jason Gunthorpe 
Signed-off-by: Doug Ledford

IB/core: Make ib_dealloc_pd return void

2015-08-30T22:12:39+00:00

The majority of callers never check the return value, and even if they
did, they can't do anything about a failure.

All possible failure cases represent a bug in the caller, so just
WARN_ON inside the function instead.

This fixes a few random errors:
 net/rd/iw.c infinite loops while it fails. (racing with EBUSY?)

This also lays the ground work to get rid of error return from the
drivers. Most drivers do not error, the few that do are broken since
it cannot be handled.

Since uverbs can legitimately make use of EBUSY, open code the
check.

Signed-off-by: Jason Gunthorpe 
Reviewed-by: Chuck Lever 
Signed-off-by: Doug Ledford

IB/ipoib: Remove ib_get_dma_mr calls

2015-08-30T22:12:34+00:00

The pd now has a local_dma_lkey member which completely replaces
ib_get_dma_mr, use it instead.

Signed-off-by: Jason Gunthorpe 
Signed-off-by: Doug Ledford

IB/cm: Remove compare_data checks

2015-08-30T19:48:24+00:00

Now that there are no ib_cm clients using the compare_data feature for
matching IB CM requests' private data, remove the compare_data parameter of
ib_cm_listen and remove the code implementing the feature.

Signed-off-by: Haggai Eran 
Signed-off-by: Doug Ledford

IB/ipoib: Return IPoIB devices matching connection parameters

2015-08-30T19:48:21+00:00

Implement the get_net_device_by_port_pkey_ip callback that returns network
device to ib_core according to connection parameters. Check the ipoib
device and iterate over all child devices to look for a match.

For each IPoIB device we iterate through all upper devices when searching
for a matching IP, in order to support bonding.

Signed-off-by: Guy Shapiro 
Signed-off-by: Haggai Eran 
Signed-off-by: Yotam Kenneth 
Signed-off-by: Shachar Raindel 
Signed-off-by: Doug Ledford