linux-stable.git/drivers/infiniband/core/security.c, branch linux-5.0.y

IB/core: Fix potential memory leak while creating MAD agents

2019-05-08T05:22:58+00:00

commit 6e88e672b69f0e627acdae74a527b730ea224b6b upstream.

If the MAD agents isn't allowed to manage the subnet, or fails to register
for the LSM notifier, the security context is leaked. Free the context in
these cases.

Fixes: 47a2b338fe63 ("IB/core: Enforce security on management datagrams")
Signed-off-by: Daniel Jurgens 
Reviewed-by: Parav Pandit 
Reported-by: Parav Pandit 
Signed-off-by: Leon Romanovsky 
Signed-off-by: Jason Gunthorpe 
Signed-off-by: Greg Kroah-Hartman

IB/core: Unregister notifier before freeing MAD security

2019-05-08T05:22:58+00:00

commit d60667fc398ed34b3c7456b020481c55c760e503 upstream.

If the notifier runs after the security context is freed an access of
freed memory can occur.

Fixes: 47a2b338fe63 ("IB/core: Enforce security on management datagrams")
Signed-off-by: Daniel Jurgens 
Reviewed-by: Parav Pandit 
Signed-off-by: Leon Romanovsky 
Signed-off-by: Jason Gunthorpe 
Signed-off-by: Greg Kroah-Hartman

RDMA: Start use ib_device_ops

2018-12-12T14:40:16+00:00

Make all the required change to start use the ib_device_ops structure.

Signed-off-by: Kamal Heib 
Signed-off-by: Jason Gunthorpe

RDMA/core: Use dev_name instead of ibdev->name

2018-09-26T19:51:48+00:00

These return the same thing but dev_name is a more conventional use of the
kernel API.

Signed-off-by: Jason Gunthorpe 
Reviewed-by: Steve Wise 
Reviewed-by: Leon Romanovsky 
Reviewed-by: Dennis Dalessandro

IB/core: Use CONFIG_SECURITY_INFINIBAND to compile out security code

2018-05-01T15:16:36+00:00

Make security.c depends on CONFIG_SECURITY_INFINIBAND.

Reviewed-by: Daniel Jurgens 
Signed-off-by: Parav Pandit 
Signed-off-by: Leon Romanovsky 
Signed-off-by: Doug Ledford

Merge branch 'from-rc' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git

2017-12-28T04:50:46+00:00

Patches for 4.16 that are dependent on patches sent to 4.15-rc.

These are small clean ups for the vmw_pvrdma and i40iw drivers.

* 'from-rc' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git:
  RDMA/vmw_pvrdma: Remove usage of BIT() from UAPI header
  RDMA/vmw_pvrdma: Use refcount_t instead of atomic_t
  RDMA/vmw_pvrdma: Use more specific sizeof in kcalloc
  RDMA/vmw_pvrdma: Clarify QP and CQ is_kernel logic
  RDMA/vmw_pvrdma: Add UAR SRQ macros in ABI header file
  i40iw: Change accelerated flag to bool

IB/core: Verify that QP is security enabled in create and destroy

2017-12-27T22:24:41+00:00

The XRC target QP create flow sets up qp_sec only if there is an IB link with
LSM security enabled. However, several other related uAPI entry points blindly
follow the qp_sec NULL pointer, resulting in a possible oops.

Check for NULL before using qp_sec.

Cc:  # v4.12
Fixes: d291f1a65232 ("IB/core: Enforce PKey security on QPs")
Reviewed-by: Daniel Jurgens 
Signed-off-by: Moni Shoua 
Signed-off-by: Leon Romanovsky 
Signed-off-by: Jason Gunthorpe

IB/core: Avoid exporting module internal function

2017-12-18T20:49:43+00:00

ib_security_modify_qp and ib_security_pkey_access are core internal
function. So avoid exporting them.
ib_security_pkey_access is used only when secuirty hooks are enabled so
avoid defining it otherwise.

Signed-off-by: Parav Pandit 
Reviewed-by: Daniel Jurgens 
Signed-off-by: Leon Romanovsky 
Signed-off-by: Jason Gunthorpe

IB/core: Don't enforce PKey security on SMI MADs

2017-12-07T20:28:06+00:00

Per the infiniband spec an SMI MAD can have any PKey. Checking the pkey
on SMI MADs is not necessary, and it seems that some older adapters
using the mthca driver don't follow the convention of using the default
PKey, resulting in false denials, or errors querying the PKey cache.

SMI MAD security is still enforced, only agents allowed to manage the
subnet are able to receive or send SMI MADs.

Reported-by: Chris Blake 
Cc:  # v4.12
Fixes: 47a2b338fe63 ("IB/core: Enforce security on management datagrams")
Signed-off-by: Daniel Jurgens 
Reviewed-by: Parav Pandit 
Signed-off-by: Leon Romanovsky 
Signed-off-by: Doug Ledford

IB/core: Only enforce security for InfiniBand

2017-12-01T19:21:28+00:00

For now the only LSM security enforcement mechanism available is
specific to InfiniBand. Bypass enforcement for non-IB link types.

This fixes a regression where modify_qp fails for iWARP because
querying the PKEY returns -EINVAL.

Cc: Paul Moore 
Cc: Don Dutile 
Cc: stable@vger.kernel.org
Reported-by: Potnuri Bharat Teja 
Fixes: d291f1a65232("IB/core: Enforce PKey security on QPs")
Fixes: 47a2b338fe63("IB/core: Enforce security on management datagrams")
Signed-off-by: Daniel Jurgens 
Reviewed-by: Parav Pandit 
Tested-by: Potnuri Bharat Teja 
Signed-off-by: Leon Romanovsky 
Signed-off-by: Jason Gunthorpe