linux-stable.git/drivers/infiniband/core/cache.c, branch linux-4.15.y

RDMA/(core, ulp): Convert register/unregister event handler to be void

2017-08-24T20:27:10+00:00

The functions ib_register_event_handler() and
ib_unregister_event_handler() always returned success and they can't fail.

Let's convert those functions to be void, remove redundant checks and
cleanup tons of goto statements.

Signed-off-by: Leon Romanovsky 
Reviewed-by: Dennis Dalessandro 
Signed-off-by: Doug Ledford

IB/core: Enforce PKey security on QPs

2017-05-23T16:26:59+00:00

Add new LSM hooks to allocate and free security contexts and check for
permission to access a PKey.

Allocate and free a security context when creating and destroying a QP.
This context is used for controlling access to PKeys.

When a request is made to modify a QP that changes the port, PKey index,
or alternate path, check that the QP has permission for the PKey in the
PKey table index on the subnet prefix of the port. If the QP is shared
make sure all handles to the QP also have access.

Store which port and PKey index a QP is using. After the reset to init
transition the user can modify the port, PKey index and alternate path
independently. So port and PKey settings changes can be a merge of the
previous settings and the new ones.

In order to maintain access control if there are PKey table or subnet
prefix change keep a list of all QPs are using each PKey index on
each port. If a change occurs all QPs using that device and port must
have access enforced for the new cache settings.

These changes add a transaction to the QP modify process. Association
with the old port and PKey index must be maintained if the modify fails,
and must be removed if it succeeds. Association with the new port and
PKey index must be established prior to the modify and removed if the
modify fails.

1. When a QP is modified to a particular Port, PKey index or alternate
   path insert that QP into the appropriate lists.

2. Check permission to access the new settings.

3. If step 2 grants access attempt to modify the QP.

4a. If steps 2 and 3 succeed remove any prior associations.

4b. If ether fails remove the new setting associations.

If a PKey table or subnet prefix changes walk the list of QPs and
check that they have permission. If not send the QP to the error state
and raise a fatal error event. If it's a shared QP make sure all the
QPs that share the real_qp have permission as well. If the QP that
owns a security structure is denied access the security structure is
marked as such and the QP is added to an error_list. Once the moving
the QP to error is complete the security structure mark is cleared.

Maintaining the lists correctly turns QP destroy into a transaction.
The hardware driver for the device frees the ib_qp structure, so while
the destroy is in progress the ib_qp pointer in the ib_qp_security
struct is undefined. When the destroy process begins the ib_qp_security
structure is marked as destroying. This prevents any action from being
taken on the QP pointer. After the QP is destroyed successfully it
could still listed on an error_list wait for it to be processed by that
flow before cleaning up the structure.

If the destroy fails the QPs port and PKey settings are reinserted into
the appropriate lists, the destroying flag is cleared, and access control
is enforced, in case there were any cache changes during the destroy
flow.

To keep the security changes isolated a new file is used to hold security
related functionality.

Signed-off-by: Daniel Jurgens 
Acked-by: Doug Ledford 
[PM: merge fixup in ib_verbs.h and uverbs_cmd.c]
Signed-off-by: Paul Moore

IB/core: IB cache enhancements to support Infiniband security

2017-05-23T14:24:17+00:00

Cache the subnet prefix and add a function to access it. Enforcing
security requires frequent queries of the subnet prefix and the pkeys in
the pkey table.

Signed-off-by: Daniel Jurgens 
Reviewed-by: Eli Cohen 
Reviewed-by: Leon Romanovsky 
Reviewed-by: James Morris 
Acked-by: Doug Ledford 
Signed-off-by: Paul Moore

IB/core: Add inline function to validate port

2017-01-27T19:33:59+00:00

Signed-off-by: Yuval Shaia 
Reviewed-by: Leon Romanovsky 
Signed-off-by: Doug Ledford

RDMA/core: create struct ib_port_cache

2017-01-24T21:20:37+00:00

As Jason suggested, we have 4 elements for per port arrays,
it's better to have a separate structure to represent them.

It simplifies code a bit, ~ 30 lines of code less :)

Signed-off-by: Jack Wang 
Reviewed-by: Michael Wang 
Signed-off-by: Doug Ledford

RDMA/core: export ib_get_cached_port_state

2017-01-13T04:00:00+00:00

Export function for rdma_cm, patch for rdma_cm to follow.

Signed-off-by: Jack Wang 
Reviewed-by: Michael Wang 
Acked-by: Sean Hefty 
Signed-off-by: Doug Ledford

RDMA/core: add port state cache

2017-01-13T03:59:55+00:00

We need a port state cache in ib_core, later we will use in rdma_cm.

Signed-off-by: Jack Wang 
Reviewed-by: Michael Wang 
Acked-by: Sean Hefty 
Signed-off-by: Doug Ledford

IB/core: Release allocated memory in cache setup failure

2016-12-03T18:12:52+00:00

The failure in ib_cache_setup_one function during
ib_register_device will leave leaked allocated memory.

Fixes: 03db3a2d81e6 ("IB/core: Add RoCE GID table management")
Signed-off-by: Leon Romanovsky 
Signed-off-by: Doug Ledford

IB/core: Fix no default GIDs when netdevice reregisters

2016-06-23T14:03:57+00:00

Currently, when the netdevice returned by get_netdev is unregistered,
we delete all GIDs (including the default GIDs) and reset their
attributes. Therefore, when we re-register it, no default GIDs
will be assigned (as their "default GID") attribute will be reset.
Fixing this by keeping "default GID" attribute.

Fixes: 03db3a2d81e6 ('IB/core: Add RoCE GID table management')
Signed-off-by: Talat Batheesh 
Signed-off-by: Leon Romanovsky 
Signed-off-by: Doug Ledford

IB/core: Fix removal of default GID cache entry

2016-06-07T13:50:53+00:00

When deleting a default GID from the cache, its gid_type field is set
to 0.

This could set the gid_type to RoCE v1 for a RoCE v2 default GID,
essentially making it inaccessible to future modifications, since it
is no longer found by find_gid().

This fix preserves the gid_type value for default gids during cache
operations.

Fixes: b39ffa1df505 ('IB/core: Add gid_type to gid attribute')
Signed-off-by: Aviv Heller 
Signed-off-by: Leon Romanovsky 
Signed-off-by: Doug Ledford