linux-stable.git/drivers/iio, branch v5.16.4

iio: chemical: sunrise_co2: set val parameter only on success

2022-01-27T11:02:09+00:00

[ Upstream commit 38ac2f038666521f94d4fa37b5a9441cef832ccf ]

Clang static analysis reports this representative warning

sunrise_co2.c:410:9: warning: Assigned value is garbage or undefined
  *val = value;
       ^ ~~~~~

The ealier call to sunrise_read_word can fail without setting
value.  So defer setting val until we know the read was successful.

Fixes: c397894e24f1 ("iio: chemical: Add Senseair Sunrise 006-0-007 driver")
Signed-off-by: Tom Rix 
Link: https://lore.kernel.org/r/20211224150833.3278236-1-trix@redhat.com
Signed-off-by: Jonathan Cameron 
Signed-off-by: Sasha Levin

iio: trigger: Fix a scheduling whilst atomic issue seen on tsc2046

2022-01-27T11:01:22+00:00

commit 9020ef659885f2622cfb386cc229b6d618362895 upstream.

IIO triggers are software IRQ chips that split an incoming IRQ into
separate IRQs routed to all devices using the trigger.
When all consumers are done then a trigger callback reenable() is
called.  There are a few circumstances under which this can happen
in atomic context.

1) A single user of the trigger that calls the iio_trigger_done()
function from interrupt context.
2) A race between disconnecting the last device from a trigger and
the trigger itself sucessfully being disabled.

To avoid a resulting scheduling whilst atomic, close this second corner
by using schedule_work() to ensure the reenable is not done in atomic
context.

Note that drivers must be careful to manage the interaction of
set_state() and reenable() callbacks to ensure appropriate reference
counting if they are relying on the same hardware controls.

Deliberately taking this the slow path rather than via a fixes tree
because the error has hard to hit and I would like it to soak for a while
before hitting a release kernel.

Signed-off-by: Jonathan Cameron 
Cc: Pengutronix Kernel Team 
Cc: Dmitry Torokhov 
Tested-by: Oleksij Rempel 
Cc: 
Link: https://lore.kernel.org/r/20211017172209.112387-1-jic23@kernel.org
Signed-off-by: Greg Kroah-Hartman

iio: adc: ti-adc081c: Partial revert of removal of ACPI IDs

2022-01-27T11:01:22+00:00

commit c9791a94384af07592d29504004d2255dbaf8663 upstream.

Unfortuanately a non standards compliant ACPI ID is known to be
in the wild on some AAEON boards.

Partly revert the removal of these IDs so that ADC081C will again
work + add a comment to that affect for future reference.

Whilst here use generic firmware properties rather than the ACPI
specific handling previously found in this driver.

Reported-by: Kunyang Fan 
Fixes: c458b7ca3fd0 ("iio:adc:ti-adc081c: Drop ACPI ids that seem very unlikely to be official.")
Signed-off-by: Jonathan Cameron 
Cc: Andy Shevchenko 
Tested-by: Kunyang Fan  #UP-extremei11
Link: https://lore.kernel.org/r/20211205172728.2826512-1-jic23@kernel.org
Cc: 
Signed-off-by: Greg Kroah-Hartman

iio: trigger: stm32-timer: fix MODULE_ALIAS

2021-12-04T15:37:02+00:00

modprobe can't handle spaces in aliases.

Fixes: 93fbe91b5521 ("iio: Add STM32 timer trigger driver")
Signed-off-by: Alyssa Ross 
Link: https://lore.kernel.org/r/20211125182850.2645424-1-hi@alyssa.is
Cc: 
Signed-off-by: Jonathan Cameron

iio: adc: stm32: fix null pointer on defer_probe error

2021-11-27T16:09:05+00:00

dev_err_probe() calls __device_set_deferred_probe_reason()
on -EPROBE_DEFER error. If device pointer to driver core
private structure is not initialized, an null pointer error occurs.
This pointer is set on iio_device_register() call for iio device.

dev_err_probe() must be called with the device which is probing.
Replace iio device by its parent device.

Fixes: 0e346b2cfa85 ("iio: adc: stm32-adc: add vrefint calibration support")
Signed-off-by: Olivier Moysan 
Reviewed-by: Ahmad Fatoum 
Link: https://lore.kernel.org/r/20211122143809.2332-1-olivier.moysan@foss.st.com
Signed-off-by: Jonathan Cameron

iio: at91-sama5d2: Fix incorrect sign extension

2021-11-21T13:45:23+00:00

Use scan_type when processing raw data which also fixes that the sign
extension was from the wrong bit.

Use channel definition as root of trust and replace constant
when reading elements directly using the raw sysfs attributes.

Fixes: 6794e23fa3fe ("iio: adc: at91-sama5d2_adc: add support for oversampling resolution")
Signed-off-by: Gwendal Grignou 
Reviewed-by: Eugen Hristev 
Cc: 
Link: https://lore.kernel.org/r/20211104082413.3681212-9-gwendal@chromium.org
Signed-off-by: Jonathan Cameron

iio: adc: axp20x_adc: fix charging current reporting on AXP22x

2021-11-21T11:30:54+00:00

Both the charging and discharging currents on AXP22x are stored as
12-bit integers, in accordance with the datasheet.
It's also confirmed by vendor BSP (axp20x_adc.c:axp22_icharge_to_mA).

The scale factor of 0.5 is never mentioned in datasheet, nor in the
vendor source code. I think it was here to compensate for
erroneous addition bit in register width.

Tested on custom A40i+AXP221s board with external ammeter as
a reference.

Fixes: 0e34d5de961d ("iio: adc: add support for X-Powers AXP20X and AXP22X PMICs ADCs")
Signed-off-by: Evgeny Boger 
Acked-by: Chen-Yu Tsai 
Link: https://lore.kernel.org/r/20211116213746.264378-1-boger@wirenboard.com
Cc: 
Signed-off-by: Jonathan Cameron

iio: gyro: adxrs290: fix data signedness

2021-11-21T11:29:50+00:00

Properly sign-extend the rate and temperature data.

Fixes: 2c8920fff1457 ("iio: gyro: Add driver support for ADXRS290")
Signed-off-by: Kister Genesis Jimenez 
Signed-off-by: Nuno Sá 
Reviewed-by: Andy Shevchenko 
Link: https://lore.kernel.org/r/20211115104147.18669-1-nuno.sa@analog.com
Cc: 
Signed-off-by: Jonathan Cameron

iio: ad7768-1: Call iio_trigger_notify_done() on error

2021-11-17T17:52:36+00:00

IIO trigger handlers must call iio_trigger_notify_done() when done. This
must be done even when an error occurred. Otherwise the trigger will be
seen as busy indefinitely and the trigger handler will never be called
again.

The ad7768-1 driver neglects to call iio_trigger_notify_done() when there
is an error reading the converter data. Fix this by making sure that
iio_trigger_notify_done() is included in the error exit path.

Fixes: a5f8c7da3dbe ("iio: adc: Add AD7768-1 ADC basic support")
Signed-off-by: Lars-Peter Clausen 
Link: https://lore.kernel.org/r/20211101144055.13858-2-lars@metafoo.de
Cc: 
Signed-off-by: Jonathan Cameron

iio: itg3200: Call iio_trigger_notify_done() on error

2021-11-17T17:52:36+00:00

IIO trigger handlers must call iio_trigger_notify_done() when done. This
must be done even when an error occurred. Otherwise the trigger will be
seen as busy indefinitely and the trigger handler will never be called
again.

The itg3200 driver neglects to call iio_trigger_notify_done() when there is
an error reading the gyro data. Fix this by making sure that
iio_trigger_notify_done() is included in the error exit path.

Fixes: 9dbf091da080 ("iio: gyro: Add itg3200")
Signed-off-by: Lars-Peter Clausen 
Link: https://lore.kernel.org/r/20211101144055.13858-1-lars@metafoo.de
Cc: 
Signed-off-by: Jonathan Cameron