linux-stable.git/drivers/iio/trigger/stm32-timer-trigger.c, branch linux-5.10.y

iio: trigger: stm32-timer: fix MODULE_ALIAS

2021-12-14T10:32:44+00:00

commit 893621e0606747c5bbefcaf2794d12c7aa6212b7 upstream.

modprobe can't handle spaces in aliases.

Fixes: 93fbe91b5521 ("iio: Add STM32 timer trigger driver")
Signed-off-by: Alyssa Ross 
Link: https://lore.kernel.org/r/20211125182850.2645424-1-hi@alyssa.is
Cc: 
Signed-off-by: Jonathan Cameron 
Signed-off-by: Greg Kroah-Hartman

iio: Remove superfluous of_node assignments

2020-06-14T13:20:08+00:00

If a driver does not assign an of_node to a IIO device to IIO core will
automatically assign the of_node of the parent device. This automatic
assignment is done in the iio_device_register() function.

There is a fair amount of drivers that currently manually assign the
of_node of the IIO device. All but 4 of them can make use of the automatic
assignment though.

The exceptions are:
 * mxs-lradc-adc: Which uses the of_node of the parent of the parent.
 * stm32-dfsdm-adc, stm32-adc and stm32-dac: Which reference the of_node
   assigned to the IIO device before iio_device_register() is called.

All other drivers are updated to use automatic assignment. This reduces
the amount of boilerplate code involved in setting up the IIO device.

The patch has mostly been auto-generated with the following semantic patch

// 
@exists@
expression indio_dev;
expression parent;
@@
indio_dev = \(devm_iio_device_alloc\|iio_device_alloc\)(&parent, ...)
...
-indio_dev->dev.of_node = parent.of_node;

@exists@
expression indio_dev;
expression parent;
@@
indio_dev = \(devm_iio_device_alloc\|iio_device_alloc\)(parent, ...)
...
-indio_dev->dev.of_node = parent->of_node;
// 

Signed-off-by: Lars-Peter Clausen 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Jonathan Cameron

iio: remove explicit IIO device parent assignment

2020-06-14T10:49:59+00:00

This patch applies the semantic patch:
@@
expression I, P, SP;
@@
   I = devm_iio_device_alloc(P, SP);
   ...
-  I->dev.parent = P;

It updates 302 files and does 307 deletions.
This semantic patch also removes some comments like
'/* Establish that the iio_dev is a child of the i2c device */'

But this is is only done in case where the block is left empty.

The patch does not seem to cover all cases. It looks like in some cases a
different variable is used in some cases to assign the parent, but it
points to the same reference.
In other cases, the block covered by ... may be just too big to be covered
by the semantic patch.

However, this looks pretty good as well, as it does cover a big bulk of the
drivers that should remove the parent assignment.

Signed-off-by: Alexandru Ardelean 
Signed-off-by: Jonathan Cameron

Merge 5.6-rc7 into staging-next

2020-03-23T07:01:20+00:00

We need the staging/iio fixes in here as well

Signed-off-by: Greg Kroah-Hartman

iio: trigger: stm32-timer: add power management support

2020-03-08T17:28:53+00:00

Add suspend/resume PM sleep ops to stm32-timer-trigger driver.
Register contents may be lost depending on low power modes.
When going to low power, enforce the timer isn't active. Gracefully
restore its state upon resume in case it's been left enabled prior to
suspend.

Signed-off-by: Fabrice Gasnier 
Signed-off-by: Jonathan Cameron

iio: trigger: stm32-timer: rename enabled flag

2020-03-08T17:28:53+00:00

"clk_enabled" flag reflects enabled state of the timer, for master mode,
slave mode or trigger (with sampling_frequency). So rename it to "enabled".

Signed-off-by: Fabrice Gasnier 
Signed-off-by: Jonathan Cameron

iio: trigger: stm32-timer: enable clock when in master mode

2020-03-08T17:28:35+00:00

Clock should be enabled as soon as using master modes, even before
enabling timer. Or, this may provoke bad behavior on the other end
(slave timer). Then, introduce 'clk_enabled' flag, instead of relying
on CR1 EN bit, to keep track of clock being enabled (balanced refcount).
Propagate this anywhere else in the driver.

Also add 'remove' routine to stop timer and disable clock in case it
has been left enabled. Enforce the user interface has been unregistered
in the remove routine, before disabling the hardware to avoid possible
race. So, remove use of devm_ variant to register triggers and unregister
them before the hardware gets disabled [1].
[1] https://patchwork.kernel.org/patch/9956247/

Signed-off-by: Fabrice Gasnier 
Signed-off-by: Jonathan Cameron

iio: trigger: stm32-timer: disable master mode when stopping

2020-02-15T18:41:00+00:00

Master mode should be disabled when stopping. This mainly impacts
possible other use-case after timer has been stopped. Currently,
master mode remains set (from start routine).

Fixes: 6fb34812c2a2 ("iio: stm32 trigger: Add support for TRGO2 triggers")

Signed-off-by: Fabrice Gasnier 
Cc: 
Signed-off-by: Jonathan Cameron

iio: trigger: stm32-timer: remove unnecessary update event

2019-12-01T10:20:21+00:00

There is no need to explicitly generate update event to update
timer master mode.

Signed-off-by: Fabrice Gasnier 
Signed-off-by: Jonathan Cameron

IIO: stm32: Remove quadrature related functions from trigger driver

2019-07-27T19:11:18+00:00

Quadrature feature is now hosted on it own framework.
Remove quadrature related code from stm32-trigger driver to avoid
code duplication and simplify the ABI.

Signed-off-by: Benjamin Gaignard 
Signed-off-by: Jonathan Cameron