linux-stable.git/drivers/iio/light, branch linux-5.14.y

iio: light: opt3001: Fixed timeout error when 0 lux

2021-10-20T09:57:52+00:00

commit 26d90b5590579def54382a2fc34cfbe8518a9851 upstream.

Reading from sensor returned timeout error under
zero light conditions.

Signed-off-by: Jiri Valek - 2N 
Fixes: ac663db3678a ("iio: light: opt3001: enable operation w/o IRQ")
Link: https://lore.kernel.org/r/20210920125351.6569-1-valek@2n.cz
Cc: 
Signed-off-by: Jonathan Cameron 
Signed-off-by: Greg Kroah-Hartman

iio: light: tcs3472: do not free unallocated IRQ

2021-06-16T13:57:03+00:00

Allocating an IRQ is conditional to the IRQ existence, but freeing it
was not. If no IRQ was allocate, the driver would still try to free
IRQ 0. Add the missing checks.

This fixes the following trace when the driver is removed:

[  100.667788] Trying to free already-free IRQ 0
[  100.667793] WARNING: CPU: 0 PID: 2315 at kernel/irq/manage.c:1826 free_irq+0x1fd/0x370
...
[  100.667914] Call Trace:
[  100.667920]  tcs3472_remove+0x3a/0x90 [tcs3472]
[  100.667927]  i2c_device_remove+0x2b/0xa0

Signed-off-by: frank zago 
Link: https://lore.kernel.org/r/20210427022017.19314-2-frank@zago.net
Fixes: 9d2f715d592e ("iio: light: tcs3472: support out-of-threshold events")
Cc: 
Signed-off-by: Jonathan Cameron

iio: hid-sensors: Update header includes

2021-06-16T13:53:13+00:00

General driver churn doesn't always include updates of header includes.
Manual review of the output of the include-what-you-use checker lead to the
following cleanup. Hopefuly this brings things back to a good state for the
hid-sensor drivers.

Signed-off-by: Jonathan Cameron 
Cc: Jiri Kosina 
Cc: Srinivas Pandruvada 
Acked-by: Srinivas Pandruvada 
Link: https://lore.kernel.org/r/20210608205510.4033887-1-jic23@kernel.org

iio: hid-sensors: lighten exported symbols by moving to IIO_HID namespace

2021-06-16T13:53:13+00:00

A namespace for exported symbols makes clear who is a provider
and who is a consumer of the certain resources. Besides that,
it doesn't pollute the common namespace.

Signed-off-by: Andy Shevchenko 
Acked-by: Alexandre Belloni 
Acked-by: Srinivas Pandruvada 
Link: https://lore.kernel.org/r/20210614162447.5392-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Jonathan Cameron

iio: light: vcnl4035: Fix buffer alignment in iio_push_to_buffers_with_timestamp()

2021-06-16T13:53:08+00:00

Add __aligned(8) to ensure the buffer passed to
iio_push_to_buffers_with_timestamp() is suitable for the naturally
aligned timestamp that will be inserted.

Here an explicit structure is not used, because the holes would
necessitate the addition of an explict memset(), to avoid a potential
kernel data leak, making for a less minimal fix.

Fixes: 55707294c4eb ("iio: light: Add support for vishay vcnl4035")
Signed-off-by: Jonathan Cameron 
Cc: Parthiban Nallathambi 
Reviewed-by: Nuno Sá 
Link: https://lore.kernel.org/r/20210613152301.571002-8-jic23@kernel.org

iio: light: vcnl4000: Fix buffer alignment in iio_push_to_buffers_with_timestamp()

2021-06-14T10:42:41+00:00

Add __aligned(8) to ensure the buffer passed to
iio_push_to_buffers_with_timestamp() is suitable for the naturally
aligned timestamp that will be inserted.

Here an explicit structure is not used, because the holes would
necessitate the addition of an explict memset(), to avoid a kernel
data leak, making for a less minimal fix.

Found during an audit of all callers of iio_push_to_buffers_with_timestamp()

Fixes: 8fe78d5261e7 ("iio: vcnl4000: Add buffer support for VCNL4010/20.")
Signed-off-by: Jonathan Cameron 
Cc: Mathieu Othacehe 
Reviewed-by: Nuno Sá 
Link: https://lore.kernel.org/r/20210613152301.571002-7-jic23@kernel.org

iio: ltr501: mark ltr501_chip_info as const

2021-06-13T16:00:18+00:00

This patch marks the struct ltr501_chip_info as constant.

Reviewed-by: Andy Shevchenko 
Signed-off-by: Marc Kleine-Budde 
Tested-by: Nikita Travkin  # ltr559
Link: https://lore.kernel.org/r/20210610134619.2101372-5-mkl@pengutronix.de
Signed-off-by: Jonathan Cameron

iio: ltr501: ltr501_read_ps(): add missing endianness conversion

2021-06-13T16:00:18+00:00

The PS ADC Channel data is spread over 2 registers in little-endian
form. This patch adds the missing endianness conversion.

Fixes: 2690be905123 ("iio: Add Lite-On ltr501 ambient light / proximity sensor driver")
Signed-off-by: Oliver Lang 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Marc Kleine-Budde 
Tested-by: Nikita Travkin  # ltr559
Link: https://lore.kernel.org/r/20210610134619.2101372-4-mkl@pengutronix.de
Cc: 
Signed-off-by: Jonathan Cameron

iio: ltr501: ltr559: fix initialization of LTR501_ALS_CONTR

2021-06-13T16:00:18+00:00

The ltr559 chip uses only the lowest bit of the ALS_CONTR register to
configure between active and stand-by mode. In the original driver
BIT(1) is used, which does a software reset instead.

This patch fixes the problem by using BIT(0) as als_mode_active for
the ltr559 chip.

Fixes: 8592a7eefa54 ("iio: ltr501: Add support for ltr559 chip")
Signed-off-by: Oliver Lang 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Marc Kleine-Budde 
Tested-by: Nikita Travkin  # ltr559
Link: https://lore.kernel.org/r/20210610134619.2101372-3-mkl@pengutronix.de
Cc: 
Signed-off-by: Jonathan Cameron

iio: ltr501: mark register holding upper 8 bits of ALS_DATA{0,1} and PS_DATA as volatile, too

2021-06-13T16:00:18+00:00

The regmap is configured for 8 bit registers, uses a RB-Tree cache and
marks several registers as volatile (i.e. do not cache).

The ALS and PS data registers in the chip are 16 bit wide and spans
two regmap registers. In the current driver only the base register is
marked as volatile, resulting in the upper register only read once.

Further the data sheet notes:

| When the I2C read operation starts, all four ALS data registers are
| locked until the I2C read operation of register 0x8B is completed.

Which results in the registers never update after the 2nd read.

This patch fixes the problem by marking the upper 8 bits of the ALS
and PS registers as volatile, too.

Fixes: 2f2c96338afc ("iio: ltr501: Add regmap support.")
Reported-by: Oliver Lang 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Marc Kleine-Budde 
Tested-by: Nikita Travkin  # ltr559
Link: https://lore.kernel.org/r/20210610134619.2101372-2-mkl@pengutronix.de
Cc: 
Signed-off-by: Jonathan Cameron