linux-stable.git/drivers/i2c, branch v6.6.2

i2c: iproc: handle invalid slave state

2023-11-20T10:59:36+00:00

[ Upstream commit ba15a14399c262f91ce30c19fcbdc952262dd1be ]

Add the code to handle an invalid state when both bits S_RX_EVENT
(indicating a transaction) and S_START_BUSY (indicating the end
of transaction - transition of START_BUSY from 1 to 0) are set in
the interrupt status register during a slave read.

Signed-off-by: Roman Bacik 
Fixes: 1ca1b4516088 ("i2c: iproc: handle Master aborted error")
Acked-by: Ray Jui 
Signed-off-by: Wolfram Sang 
Signed-off-by: Sasha Levin

i2c: stm32f7: Fix PEC handling in case of SMBUS transfers

2023-10-21T18:31:04+00:00

In case of SMBUS byte read with PEC enabled, the whole transfer
is split into two commands.  A first write command, followed by
a read command.  The write command does not have any PEC byte
and a PEC byte is appended at the end of the read command.
(cf Read byte protocol with PEC in SMBUS specification)

Within the STM32 I2C controller, handling (either sending
or receiving) of the PEC byte is done via the PECBYTE bit in
register CR2.

Currently, the PECBYTE is set at the beginning of a transfer,
which lead to sending a PEC byte at the end of the write command
(hence losing the real last byte), and also does not check the
PEC byte received during the read command.

This patch corrects the function stm32f7_i2c_smbus_xfer_msg
in order to only set the PECBYTE during the read command.

Fixes: 9e48155f6bfe ("i2c: i2c-stm32f7: Add initial SMBus protocols support")
Signed-off-by: Alain Volmat 
Reviewed-by: Pierre-Yves MORDRET 
Acked-by: Andi Shyti 
Signed-off-by: Wolfram Sang

i2c: muxes: i2c-mux-gpmux: Use of_get_i2c_adapter_by_node()

2023-10-21T17:57:18+00:00

i2c-mux-gpmux uses the pair of_find_i2c_adapter_by_node() /
i2c_put_adapter(). These pair alone is not correct to properly lock the
I2C parent adapter.

Indeed, i2c_put_adapter() decrements the module refcount while
of_find_i2c_adapter_by_node() does not increment it. This leads to an
underflow of the parent module refcount.

Use the dedicated function, of_get_i2c_adapter_by_node(), to handle
correctly the module refcount.

Fixes: ac8498f0ce53 ("i2c: i2c-mux-gpmux: new driver")
Signed-off-by: Herve Codina 
Cc: stable@vger.kernel.org
Acked-by: Peter Rosin 
Reviewed-by: Jonathan Cameron 
Signed-off-by: Wolfram Sang

i2c: muxes: i2c-demux-pinctrl: Use of_get_i2c_adapter_by_node()

2023-10-21T17:56:55+00:00

i2c-demux-pinctrl uses the pair of_find_i2c_adapter_by_node() /
i2c_put_adapter(). These pair alone is not correct to properly lock the
I2C parent adapter.

Indeed, i2c_put_adapter() decrements the module refcount while
of_find_i2c_adapter_by_node() does not increment it. This leads to an
underflow of the parent module refcount.

Use the	dedicated function, of_get_i2c_adapter_by_node(), to handle
correctly the module refcount.

Fixes: 50a5ba876908 ("i2c: mux: demux-pinctrl: add driver")
Signed-off-by: Herve Codina 
Cc: stable@vger.kernel.org
Acked-by: Peter Rosin 
Reviewed-by: Jonathan Cameron 
Signed-off-by: Wolfram Sang

i2c: muxes: i2c-mux-pinctrl: Use of_get_i2c_adapter_by_node()

2023-10-21T17:56:43+00:00

i2c-mux-pinctrl uses the pair of_find_i2c_adapter_by_node() /
i2c_put_adapter(). These pair alone is not correct to properly lock the
I2C parent adapter.

Indeed, i2c_put_adapter() decrements the module refcount while
of_find_i2c_adapter_by_node() does not increment it. This leads to an
underflow of the parent module refcount.

Use the dedicated function, of_get_i2c_adapter_by_node(), to handle
correctly the module refcount.

Fixes: c4aee3e1b0de ("i2c: mux: pinctrl: remove platform_data")
Signed-off-by: Herve Codina 
Cc: stable@vger.kernel.org
Acked-by: Peter Rosin 
Reviewed-by: Jonathan Cameron 
Signed-off-by: Wolfram Sang

i2c: aspeed: Fix i2c bus hang in slave read

2023-10-10T19:34:02+00:00

When the `CONFIG_I2C_SLAVE` option is enabled and the device operates
as a slave, a situation arises where the master sends a START signal
without the accompanying STOP signal. This action results in a
persistent I2C bus timeout. The core issue stems from the fact that
the i2c controller remains in a slave read state without a timeout
mechanism. As a consequence, the bus perpetually experiences timeouts.

In this case, the i2c bus will be reset, but the slave_state reset is
missing.

Fixes: fee465150b45 ("i2c: aspeed: Reset the i2c controller when timeout occurs")
Signed-off-by: Jian Zhang 
Acked-by: Andi Shyti 
Tested-by: Andrew Jeffery 
Reviewed-by: Andrew Jeffery 
Signed-off-by: Wolfram Sang

i2c: npcm7xx: Fix callback completion ordering

2023-09-27T19:32:06+00:00

Sometimes, our completions race with new master transfers and override
the bus->operation and bus->master_or_slave variables. This causes
transactions to timeout and kernel crashes less frequently.

To remedy this, we re-order all completions to the very end of the
function.

Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver")
Signed-off-by: William A. Kennington III 
Reviewed-by: Tali Perry 
Signed-off-by: Wolfram Sang

i2c: mux: Avoid potential false error message in i2c_mux_add_adapter

2023-09-25T06:22:02+00:00

I2C_CLASS_DEPRECATED is a flag and not an actual class.
There's nothing speaking against both, parent and child, having
I2C_CLASS_DEPRECATED set. Therefore exclude it from the check.

Signed-off-by: Heiner Kallweit 
Acked-by: Peter Rosin 
Signed-off-by: Wolfram Sang

i2c: xiic: Correct return value check for xiic_reinit()

2023-09-22T10:04:39+00:00

The error paths for xiic_reinit() return negative values on failure
and 0 on success - this error message therefore is triggered on
_success_ rather than failure. Correct the condition so it's only
shown on failure as intended.

Fixes: 8fa9c9388053 ("i2c: xiic: return value of xiic_reinit")
Signed-off-by: Daniel Scally 
Acked-by: Michal Simek 
Reviewed-by: Andi Shyti 
Signed-off-by: Wolfram Sang

i2c: mux: gpio: Add missing fwnode_handle_put()

2023-09-21T08:48:03+00:00

In i2c_mux_gpio_probe_fw(), we should add fwnode_handle_put()
when break out of the iteration device_for_each_child_node()
as it will automatically increase and decrease the refcounter.

Fixes: 98b2b712bc85 ("i2c: i2c-mux-gpio: Enable this driver in ACPI land")
Signed-off-by: Liang He 
Signed-off-by: Wolfram Sang