linux-stable.git/drivers/i2c, branch v4.7.3

i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()

2016-09-07T06:34:52+00:00

commit 4d01d88019261d05ec3bff5f1a6013393faa3b9e upstream.

cros_ec_cmd_xfer returns success status if the command transport
completes successfully, but the execution result is incorrectly ignored.
In many cases, the execution result is assumed to be successful, leading
to ignored errors and operating on uninitialized data.

We've recently introduced the cros_ec_cmd_xfer_status() helper to avoid these
problems. Let's use it.

[Regarding the 'Fixes' tag; there is significant refactoring since the driver's
introduction, but the underlying logical error exists throughout I believe]

Fixes: 9d230c9e4f4e ("i2c: ChromeOS EC tunnel driver")
Signed-off-by: Brian Norris 
Reviewed-by: Javier Martinez Canillas 
Reviewed-by: Guenter Roeck 
Signed-off-by: Wolfram Sang 
Signed-off-by: Greg Kroah-Hartman

i2c: mux: demux-pinctrl: properly roll back when adding adapter fails

2016-09-07T06:34:49+00:00

commit ce8cb803d8b90458495f23606c706f0c0c857cdc upstream.

We also need to revert the dynamic OF change, so we get a consistent
state again. Otherwise, we might have two devices enabled e.g. after
pinctrl setup fails.

Signed-off-by: Wolfram Sang 
Signed-off-by: Wolfram Sang 
Signed-off-by: Greg Kroah-Hartman

i2c: efm32: fix a failure path in efm32_i2c_probe()

2016-08-20T16:10:53+00:00

commit 7dd91d52a813f99a95d20f539b777e9e6198b931 upstream.

There is the only failure path in efm32_i2c_probe(),
where clk_disable_unprepare() is missed.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Acked-by: Uwe Kleine-König 
Signed-off-by: Wolfram Sang 
Fixes: 1b5b23718b84 ("i2c: efm32: new bus driver")
Signed-off-by: Greg Kroah-Hartman

i2c: mux: reg: wrong condition checked for of_address_to_resource return value

2016-07-05T15:33:49+00:00

of_address_to_resource return 0 on successful call but
devm_ioremap_resource is called only if it returns non-zero value

Signed-off-by: Lukasz Gemborowski 
Reviewed-by: Alexander Sverdlin 
Signed-off-by: Wolfram Sang 
Cc: stable@kernel.org

i2c: tegra: Correct error path in probe

2016-07-05T15:20:37+00:00

Commit 497fbe24987b ("i2c: tegra: enable multi master mode for tegra210")
enables the Tegra I2C 'div_clk' for adapters using the multi-master mode
during the device probe. Although the probe error path was updated to
disable the clock on probe failure, there is one place after calling
tegra_i2c_init() where the clock will not be disabled on failure. Correct
the error path so that the 'div_clk' is disabled if calling
tegra_i2c_init() fails.

Fixes: 497fbe24987b ("i2c: tegra: enable multi master mode for tegra210")

Signed-off-by: Jon Hunter 
Acked-by: Laxman Dewangan 
Signed-off-by: Wolfram Sang

i2c: remove __init from i2c_register_board_info()

2016-06-19T12:13:50+00:00

As of next-20160607 with allyesconfig we get this linker failure:

  MODPOST vmlinux.o
WARNING: vmlinux.o(.text+0x21bc0d): Section mismatch in reference from
the function intel_scu_devices_create() to the function
.init.text:i2c_register_board_info()

This is caused by the fact that intel_scu_devices_create() calls
i2c_register_board_info() and intel_scu_devices_create() is not
annotated with __init. This typically involves manual code
inspection and if one is certain this is correct we would
just peg intel_scu_devices_create() with a __ref annotation.

In this case this would be wrong though as the
intel_scu_devices_create() call is exported, and used in
the ipc_probe() on drivers/platform/x86/intel_scu_ipc.c.
The issue is that even though builtin_pci_driver(ipc_driver)
is used this just exposes the probe routine, which can occur
at any point in time if this bus supports hotplug. A race
can happen between kernel_init_freeable() that calls the init
calls (in this case registeres the intel_scu_ipc.c driver, and
later free_initmem(), which would free the i2c_register_board_info().
If a probe happens later in boot i2c_register_board_info() would
not be present and we should get a page fault.

Signed-off-by: Luis R. Rodriguez 
[wsa: made function declaration a one-liner]
Signed-off-by: Wolfram Sang

i2c: qup: Fix wrong value of index variable

2016-06-18T16:33:13+00:00

index gets incremented during check to determine if the
messages can be transferred with dma. But not reset after
that, resulting in wrong start value in subsequent loop,
causing failure. Fix it.

Signed-off-by: Sricharan R 
Signed-off-by: Wolfram Sang 
Cc: stable@kernel.org

i2c: mux: reg: Provide of_match_table

2016-06-09T20:38:16+00:00

of_match_table was not filled which prevents device to be
instantiated from device tree node.

Signed-off-by: Lukasz Gemborowski 
Reviewed-by: Alexander Sverdlin 
Signed-off-by: Wolfram Sang

i2c: octeon: Avoid printk after too long SMBUS message

2016-06-09T20:07:57+00:00

Remove the warning about a too long SMBUS message because
the ipmi_ssif driver triggers this warning too frequently so it
spams the message log.

Signed-off-by: Jan Glauber 
Signed-off-by: Wolfram Sang

i2c: octeon: Missing AAK flag in case of I2C_M_RECV_LEN

2016-06-09T20:05:32+00:00

During receive the controller requires the AAK flag for all
bytes but the final one. This was wrong in case of I2C_M_RECV_LEN,
where the decision if the final byte is to be transmitted
happened before adding the additional received length byte.

Set the AAK flag if additional bytes are to be received.

Signed-off-by: Jan Glauber 
Signed-off-by: Wolfram Sang