linux-stable.git/drivers/i2c, branch linux-5.14.y

i2c: xlr: Fix a resource leak in the error handling path of 'xlr_i2c_probe()'

2021-11-17T10:04:37+00:00

[ Upstream commit 7f98960c046ee1136e7096aee168eda03aef8a5d ]

A successful 'clk_prepare()' call should be balanced by a corresponding
'clk_unprepare()' call in the error handling path of the probe, as already
done in the remove function.

More specifically, 'clk_prepare_enable()' is used, but 'clk_disable()' is
also already called. So just the unprepare step has still to be done.

Update the error handling path accordingly.

Fixes: 75d31c2372e4 ("i2c: xlr: add support for Sigma Designs controller variant")
Signed-off-by: Christophe JAILLET 
Signed-off-by: Wolfram Sang 
Signed-off-by: Sasha Levin

i2c: mediatek: fixing the incorrect register offset

2021-11-17T10:04:32+00:00

[ Upstream commit b8228aea5a19d5111a7bf44f7de6749d1f5d487a ]

The reason for the modification here is that the previous
offset information is incorrect, OFFSET_DEBUGSTAT = 0xE4 is
the correct value.

Fixes: 25708278f810 ("i2c: mediatek: Add i2c support for MediaTek MT8183")
Signed-off-by: Kewei Xu 
Reviewed-by: Chen-Yu Tsai 
Reviewed-by: Qii Wang 
Signed-off-by: Wolfram Sang 
Signed-off-by: Sasha Levin

i2c: mlxcpld: Modify register setting for 400KHz frequency

2021-10-13T07:42:02+00:00

[ Upstream commit fa1049135c15b4930ce7ea757a81b1b78908f304 ]

Change setting for 400KHz frequency support by more accurate value.

Fixes: 66b0c2846ba8 ("i2c: mlxcpld: Add support for I2C bus frequency setting")
Signed-off-by: Vadim Pasternak 
Signed-off-by: Wolfram Sang 
Signed-off-by: Sasha Levin

i2c: mlxcpld: Fix criteria for frequency setting

2021-10-13T07:42:01+00:00

[ Upstream commit 52f57396c75acd77ebcdf3d20aed24ed248e9f79 ]

Value for getting frequency capability wrongly has been taken from
register offset instead of register value.

Fixes: 66b0c2846ba8 ("i2c: mlxcpld: Add support for I2C bus frequency setting")
Signed-off-by: Vadim Pasternak 
Signed-off-by: Wolfram Sang 
Signed-off-by: Sasha Levin

i2c: mediatek: Add OFFSET_EXT_CONF setting back

2021-10-13T07:42:01+00:00

[ Upstream commit 3bce7703c7ba648bd9e174dc1413f422b7998833 ]

In the commit be5ce0e97cc7 ("i2c: mediatek: Add i2c ac-timing adjust
support"), we miss setting OFFSET_EXT_CONF register if
i2c->dev_comp->timing_adjust is false, now add it back.

Fixes: be5ce0e97cc7 ("i2c: mediatek: Add i2c ac-timing adjust support")
Signed-off-by: Kewei Xu 
Reviewed-by: Qii Wang 
Signed-off-by: Wolfram Sang 
Signed-off-by: Sasha Levin

i2c: acpi: fix resource leak in reconfiguration device addition

2021-10-13T07:42:01+00:00

[ Upstream commit 6558b646ce1c2a872fe1c2c7cb116f05a2c1950f ]

acpi_i2c_find_adapter_by_handle() calls bus_find_device() which takes a
reference on the adapter which is never released which will result in a
reference count leak and render the adapter unremovable.  Make sure to
put the adapter after creating the client in the same manner that we do
for OF.

Fixes: 525e6fabeae2 ("i2c / ACPI: add support for ACPI reconfigure notifications")
Signed-off-by: Jamie Iles 
Acked-by: Mika Westerberg 
[wsa: fixed title]
Signed-off-by: Wolfram Sang 
Signed-off-by: Sasha Levin

i2c: xlp9xx: fix main IRQ check

2021-09-15T08:02:28+00:00

[ Upstream commit 661e8a88e8317eb9ffe69c69d6cb4876370fe7e2 ]

Iff platform_get_irq() returns 0 for the main IRQ, the driver's probe()
method will return 0 early (as if the method's call was successful).
Let's consider IRQ0 valid for simplicity -- devm_request_irq() can always
override that decision...

Fixes: 2bbd681ba2b ("i2c: xlp9xx: Driver for Netlogic XLP9XX/5XX I2C controller")
Signed-off-by: Sergey Shtylyov 
Reviewed-by: George Cherian 
Signed-off-by: Wolfram Sang 
Signed-off-by: Sasha Levin

i2c: mt65xx: fix IRQ check

2021-09-15T08:02:28+00:00

[ Upstream commit 58fb7c643d346e2364404554f531cfa6a1a3917c ]

Iff platform_get_irq() returns 0, the driver's probe() method will return 0
early (as if the method's call was successful).  Let's consider IRQ0 valid
for simplicity -- devm_request_irq() can always override that decision...

Fixes: ce38815d39ea ("I2C: mediatek: Add driver for MediaTek I2C controller")
Signed-off-by: Sergey Shtylyov 
Reviewed-by: Qii Wang 
Signed-off-by: Wolfram Sang 
Signed-off-by: Sasha Levin

i2c: hix5hd2: fix IRQ check

2021-09-15T08:02:25+00:00

[ Upstream commit f9b459c2ba5edfe247e86b45ad5dea8da542f3ea ]

Iff platform_get_irq() returns 0, the driver's probe() method will return 0
early (as if the method's call was successful).  Let's consider IRQ0 valid
for simplicity -- devm_request_irq() can always override that decision...

Fixes: 15ef27756b23 ("i2c: hix5hd2: add i2c controller driver")
Signed-off-by: Sergey Shtylyov 
Signed-off-by: Wolfram Sang 
Signed-off-by: Sasha Levin

i2c: s3c2410: fix IRQ check

2021-09-15T08:02:25+00:00

[ Upstream commit d6840a5e370b7ea4fde16ce2caf431bcc87f9a75 ]

Iff platform_get_irq() returns 0, the driver's probe() method will return 0
early (as if the method's call was successful).  Let's consider IRQ0 valid
for simplicity -- devm_request_irq() can always override that decision...

Fixes: e0d1ec97853f ("i2c-s3c2410: Change IRQ to be plain integer.")
Signed-off-by: Sergey Shtylyov 
Reviewed-by: Krzysztof Kozlowski 
Signed-off-by: Wolfram Sang 
Signed-off-by: Sasha Levin