linux-stable.git/drivers/i2c, branch linux-4.15.y

i2c: i2c-stm32f7: fix no check on returned setup

2018-04-08T12:27:33+00:00

commit 771b7bf05339081019d22452ebcab6929372e13e upstream.

Before assigning returned setup structure check if not null

Fixes: 463a9215f3ca7600b5ff ("i2c: stm32f7: fix setup structure")
Signed-off-by: Pierre-Yves MORDRET 
Acked-by: Alexandre TORGUE 
Signed-off-by: Wolfram Sang 
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman

i2c: bcm2835: Set up the rising/falling edge delays

2018-02-28T09:21:32+00:00

commit fe32a815f05c8568669a062587435e15f9345764 upstream.

We were leaving them in the power on state (or the state the firmware
had set up for some client, if we were taking over from them).  The
boot state was 30 core clocks, when we actually want to sample some
time after (to make sure that the new input bit has actually arrived).

Signed-off-by: Eric Anholt 
Signed-off-by: Boris Brezillon 
Signed-off-by: Wolfram Sang 
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman

i2c: designware: must wait for enable

2018-02-28T09:21:32+00:00

commit fba4adbbf670577e605f9ad306629db6031cd48b upstream.

One I2C bus on my Atom E3845 board has been broken since 4.9.
It has two devices, both declared by ACPI and with built-in drivers.

There are two back-to-back transactions originating from the kernel, one
targeting each device. The first transaction works, the second one locks
up the I2C controller. The controller never recovers.

These kernel logs show up whenever an I2C transaction is attempted after
this failure.
i2c-designware-pci 0000:00:18.3: timeout in disabling adapter
i2c-designware-pci 0000:00:18.3: timeout waiting for bus ready

Waiting for the I2C controller status to indicate that it is enabled
before programming it fixes the issue.

I have tested this patch on 4.14 and 4.15.

Fixes: commit 2702ea7dbec5 ("i2c: designware: wait for disable/enable only if necessary")
Cc: linux-stable  #4.13+
Signed-off-by: Ben Gardner 
Acked-by: Jarkko Nikula 
Reviewed-by: José Roberto de Souza 
Signed-off-by: Wolfram Sang 
Signed-off-by: Greg Kroah-Hartman

i2c: core-smbus: prevent stack corruption on read I2C_BLOCK_DATA

2018-01-17T14:35:21+00:00

On a I2C_SMBUS_I2C_BLOCK_DATA read request, if data->block[0] is
greater than I2C_SMBUS_BLOCK_MAX + 1, the underlying I2C driver writes
data out of the msgbuf1 array boundary.

It is possible from a user application to run into that issue by
calling the I2C_SMBUS ioctl with data.block[0] greater than
I2C_SMBUS_BLOCK_MAX + 1.

This patch makes the code compliant with
Documentation/i2c/dev-interface by raising an error when the requested
size is larger than 32 bytes.

Call Trace:
 [] dump_stack+0x67/0x92
 [] panic+0xc5/0x1eb
 [] ? vprintk_default+0x1f/0x30
 [] ? i2cdev_ioctl_smbus+0x303/0x320
 [] __stack_chk_fail+0x1b/0x20
 [] i2cdev_ioctl_smbus+0x303/0x320
 [] i2cdev_ioctl+0x4d/0x1e0
 [] do_vfs_ioctl+0x2ba/0x490
 [] ? security_file_ioctl+0x43/0x60
 [] SyS_ioctl+0x79/0x90
 [] entry_SYSCALL_64_fastpath+0x12/0x6a

Signed-off-by: Jeremy Compostella 
Signed-off-by: Wolfram Sang 
Cc: stable@kernel.org

i2c: core: decrease reference count of device node in i2c_unregister_device

2018-01-17T14:23:31+00:00

Reference count of device node was increased in of_i2c_register_device,
but without decreasing it in i2c_unregister_device. Then the added
device node will never be released. Fix this by adding the of_node_put.

Signed-off-by: Lixin Wang 
Tested-by: Wolfram Sang 
Signed-off-by: Wolfram Sang 
Cc: stable@kernel.org

i2c: piix4: Fix port number check on release

2017-12-12T22:27:04+00:00

The port number shift is still hard-coded to 1 while it now depends
on the hardware.

Thankfully 0 is always 0 no matter how you shift it, so this was a
bug without consequences.

Signed-off-by: Jean Delvare 
Fixes: 0fe16195f891 ("i2c: piix4: Fix SMBus port selection for AMD Family 17h chips")
Reviewed-by: Guenter Roeck 
Signed-off-by: Wolfram Sang

i2c: stm32: Fix copyrights

2017-12-12T22:16:04+00:00

Uniformize STMicroelectronics copyrights headers and add SPDX
identifier.

Signed-off-by: Benjamin Gaignard 
Acked-by: Alexandre TORGUE 
Acked-by: Pierre-Yves MORDRET 
Acked-by: M'boumba Cedric Madianga 
Signed-off-by: Wolfram Sang

i2c-cht-wc: constify platform_device_id

2017-12-07T11:00:35+00:00

platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by 
work with const platform_device_id. So mark the non-const structs as
const.

Signed-off-by: Arvind Yadav 
Reviewed-by: Hans de Goede 
Signed-off-by: Wolfram Sang

i2c: i2c-boardinfo: fix memory leaks on devinfo

2017-11-27T18:14:29+00:00

Currently when an error occurs devinfo is still allocated but is
unused when the error exit paths break out of the for-loop. Fix
this by kfree'ing devinfo to avoid the leak.

Detected by CoverityScan, CID#1416590 ("Resource Leak")

Fixes: 4124c4eba402 ("i2c: allow attaching IRQ resources to i2c_board_info")
Fixes: 0daaf99d8424 ("i2c: copy device properties when using i2c_register_board_info()")
Signed-off-by: Colin Ian King 
Signed-off-by: Wolfram Sang

i2c: i801: Fix Failed to allocate irq -2147483648 error

2017-11-27T18:11:27+00:00

On Apollo Lake devices the BIOS does not set up IRQ routing for the i801
SMBUS controller IRQ, so we end up with dev->irq set to IRQ_NOTCONNECTED.

Detect this and do not try to use the irq in this case silencing:
i801_smbus 0000:00:1f.1: Failed to allocate irq -2147483648: -107

Cc: stable@vger.kernel.org
BugLink: https://communities.intel.com/thread/114759
Signed-off-by: Hans de Goede 
Reviewed-by: Jean Delvare 
Signed-off-by: Wolfram Sang