linux-stable.git/drivers/i2c, branch linux-3.8.y

i2c: xiic: must always write 16-bit words to TX_FIFO

2013-05-08T03:08:19+00:00

commit c39e8e4354ce4daf23336de5daa28a3b01f00aa6 upstream.

The TX_FIFO register is 10 bits wide.  The lower 8 bits are the data to be
written, while the upper two bits are flags to indicate stop/start.

The driver apparently attempted to optimize write access, by only writing a
byte in those cases where the stop/start bits are zero.  However, we have
seen cases where the lower byte is duplicated onto the upper byte by the
hardware, which causes inadvertent stop/starts.

This patch changes the write access to the transmit FIFO to always be 16 bits
wide.

Signed off by: Steven A. Falco 
Signed-off-by: Wolfram Sang 
Signed-off-by: Greg Kroah-Hartman

i2c: tegra: check the clk_prepare_enable() return value

2013-03-28T19:17:47+00:00

commit 132c803f7b70b17322579f6f4f3f65cf68e55135 upstream.

NVIDIA's Tegra SoC allows read/write of controller register only
if controller clock is enabled. System hangs if read/write happens
to registers without enabling clock.

clk_prepare_enable() can be fail due to unknown reason and hence
adding check for return value of this function. If this function
success then only access register otherwise return to caller with
error.

Signed-off-by: Laxman Dewangan 
Reviewed-by: Stephen Warren 
Signed-off-by: Wolfram Sang 
Signed-off-by: Greg Kroah-Hartman

i2c-designware: add missing MODULE_LICENSE

2013-01-22T15:43:34+00:00

The driver can also be built as a module so add MODULE_LICENSE for it. In
addition add MODULE_DESCRIPTION as well.

Signed-off-by: Mika Westerberg 
Signed-off-by: Wolfram Sang

i2c: omap: fix draining irq handling

2013-01-22T15:17:05+00:00

Commit 0bdfe0cb803dce699ff337c35d8e97ac355fa417 (i2c: omap: sanitize
exit path) changed the interrupt handler to exit early and complete
the transfer after the draining IRQ is handled. As a result, the ARDY
may not be cleared properly, and it may cause all future I2C transfers
to timeout with "timeout waiting for bus ready". This is reproducible
at least with N900 when twl4030_gpio makes a long write (> FIFO size)
during the probe (http://marc.info/?l=linux-omap&m=135818882610432&w=2).

The fix is to continue until we get ARDY interrupt that completes the
transfer. Tested with 3.8-rc4 + N900: 20 boots in a row without errors;
without the patch the problem triggers after few reboots.

Signed-off-by: Aaro Koskinen 
Acked-by: Felipe Balbi 
Signed-off-by: Wolfram Sang

i2c: omap: errata i462: fix incorrect ack for arbitration lost interrupt

2013-01-22T15:17:04+00:00

The errata handling function acks wrong interrupt in case of "Arbitration
lost". Fix it.

Discovered during code review, the real impact of the bug is unknown.

Signed-off-by: Aaro Koskinen 
Reviewed-by: Felipe Balbi 
Signed-off-by: Wolfram Sang

i2c: muxes: fix wrong use of sizeof(ptr)

2013-01-22T08:54:32+00:00

sizeof when applied to a pointer typed expression gives the size of
the pointer

The semantic patch that makes this output is available
in scripts/coccinelle/misc/noderef.cocci.

More information about semantic patching is available at
http://coccinelle.lip6.fr/

Signed-off-by: Laurent Navet 
Acked-by: Jean Delvare 
Signed-off-by: Wolfram Sang

i2c: sirf: register i2c_client from dt child-nodes in probe entry

2013-01-22T08:54:31+00:00

in probe() entry of i2c_driver, set the of node of adapter and
call of_i2c_register_devices to register all i2c_client from
dt child-nodes

Signed-off-by: Barry Song 
Signed-off-by: Wolfram Sang

i2c: mxs: Fix type of error code

2013-01-22T08:54:23+00:00

cmd_err is used to handle error code, so it should not be unsigned.

This fixes the following warning when building with W=1 option:

drivers/i2c/busses/i2c-mxs.c: In function 'mxs_i2c_xfer_msg':
drivers/i2c/busses/i2c-mxs.c:331:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Signed-off-by: Fabio Estevam 
Acked-by: Marek Vasut 
Signed-off-by: Wolfram Sang 
Cc: stable@kernel.org

i2c: mxs: Fix misuse init_completion

2013-01-21T15:26:29+00:00

The init_completion() call does reinit not only the variable carrying
the flag that the completion finished, but also initialized the
waitqueue associated with the completion. On the contrary, the
INIT_COMPLETION() call only reinits the flag.

In case there was anything still stuck in the waitqueue, subsequent call
to init_completion() would be able to create possible race condition. This
patch uses the proper function and moves init_completion() into .probe() call
of the driver, to be issued only once.

Note that such scenario is impossible, since two threads can never enter the
mxs_i2c_xfer_msg(), since whole this section is protected by mutex in I2C core.
This by no means allows this issue to exit though.

Signed-off-by: Marek Vasut 
Signed-off-by: Wolfram Sang

i2c: remove __dev* attributes from subsystem

2012-12-22T19:13:45+00:00

CONFIG_HOTPLUG is going away as an option.  As result the __dev*
markings will be going away.

Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst,
and __devexit.

Signed-off-by: Bill Pemberton 
Acked-by: Peter Korsgaard  (for ocores and mux-gpio)
Acked-by: Havard Skinnemoen  (for i2c-gpio)
Acked-by: Guan Xuetao  (for puf3)
Acked-by: Barry Song  (for sirf)
Reviewed-by: Jean Delvare 
[wsa: Fixed "foo* bar" flaws while we are here]
Signed-off-by: Wolfram Sang